25367 2009-04-24 09:50:39 -0700 wrong key code conversion in Gtk 2009-04-27 08:09:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned oldest_to_newest 118662 0 ukai 2009-04-24 09:50:39 -0700 in Gtk, WebKit converts some native key codes wrongly. For GDK_exclaim ('!'), no conversion so it would have keyIdentifier U+0000. For GDK_parenleft ('(') and GDK_parenright (')') will be converted into opposite key: should be '9' and '0', but is '0' and '9' respectively now. 118663 1 29745 ukai 2009-04-24 09:54:17 -0700 Created attachment 29745 Fix wrong key code conversion. WebCore/ChangeLog | 15 +++++++++++++++ WebCore/platform/chromium/KeyCodeConversionGtk.cpp | 5 +++-- WebCore/platform/gtk/KeyEventGtk.cpp | 5 +++-- 3 files changed, 21 insertions(+), 4 deletions(-) 118664 2 29746 ukai 2009-04-24 09:57:25 -0700 Created attachment 29746 Fix wrong key code conversion. WebCore/ChangeLog | 16 ++++++++++++++++ WebCore/platform/chromium/KeyCodeConversionGtk.cpp | 5 +++-- WebCore/platform/gtk/KeyEventGtk.cpp | 5 +++-- 3 files changed, 22 insertions(+), 4 deletions(-) 118909 3 29746 xan.lopez 2009-04-26 08:28:31 -0700 Comment on attachment 29746 Fix wrong key code conversion. Looks good to me. 118977 4 jmalonzo 2009-04-27 08:09:51 -0700 Landed in r42893 29745 2009-04-24 09:54:17 -0700 2009-04-26 08:28:05 -0700 Fix wrong key code conversion. Fix-wrong-key-code-conversion..patch text/plain 2572 ukai MmNiOTA4MTFiYTg5MTFlMjE0ODRmYWM0YjU1ODUzOGI4YTU5OWQ0NApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlODA3ZTNkLi5jM2I5Njc1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDA5LTA0LTIzICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggd3Jvbmcga2V5IGNvZGUgY29udmVyc2lvbi4KKworCU1pc3NpbmcgY29udmVyc2lvbiBmb3Ig R0RLX2V4bGFpbSAoJyEnKS4KKwlQYXJlbnMgYXJlIG9wcG9zaXRlOiBHREtfcGFyZW5sZWZ0IGlz IG9wZW4gcGFyZW4gJygnCisgICAgICAgIGFuZCBHREtfcGFyZW5yaWdodCBpcyBjbG9zZSBwYXJl biAnKScuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0 ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 d2luZG93c0tleUNvZGVGb3JLZXlFdmVudCk6CisKIDIwMDktMDQtMjQgIERhcmluIEFkbGVyICA8 ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252ZXJzaW9uR3RrLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCmlu ZGV4IGEzZWZlNDQuLjJjZGUwNmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCkBAIC0xNTAsOSArMTUwLDEwIEBAIGludCB3aW5k b3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2lnbmVkIGtleWNvZGUpCiAgICAgY2FzZSBHREtfSGVs cDoKICAgICAgICAgcmV0dXJuIFZLRVlfSEVMUDsgLy8gKDJGKSBIRUxQIGtleQogICAgIGNhc2Ug R0RLXzA6Ci0gICAgY2FzZSBHREtfcGFyZW5sZWZ0OgorICAgIGNhc2UgR0RLX3BhcmVucmlnaHQ6 CiAgICAgICAgIHJldHVybiBWS0VZXzA7ICAgIC8vICAoMzApIDApIGtleQogICAgIGNhc2UgR0RL XzE6CisgICAgY2FzZSBHREtfZXhjbGFpbToKICAgICAgICAgcmV0dXJuIFZLRVlfMTsgLy8gICgz MSkgMSAhIGtleQogICAgIGNhc2UgR0RLXzI6CiAgICAgY2FzZSBHREtfYXQ6CkBAIC0xNzYsNyAr MTc3LDcgQEAgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQga2V5Y29kZSkK ICAgICBjYXNlIEdES19hc3RlcmlzazoKICAgICAgICAgcmV0dXJuIFZLRVlfODsgLy8gICgzOCkg OCBrZXkgICcqJwogICAgIGNhc2UgR0RLXzk6Ci0gICAgY2FzZSBHREtfcGFyZW5yaWdodDoKKyAg ICBjYXNlIEdES19wYXJlbmxlZnQ6CiAgICAgICAgIHJldHVybiBWS0VZXzk7IC8vICAoMzkpIDkg a2V5ICcoJwogICAgIGNhc2UgR0RLX2E6CiAgICAgY2FzZSBHREtfQToKZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L0tleUV2ZW50R3RrLmNwcAppbmRleCBmZDMzNzY1Li5kYjhjZmY2IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvS2V5RXZlbnRHdGsuY3BwCkBAIC0yNTcsOSArMjU3LDEwIEBAIHN0YXRpYyBpbnQgd2luZG93 c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQga2V5Y29kZSkKICAgICAgICAgY2FzZSBH REtfSGVscDoKICAgICAgICAgICAgIHJldHVybiBWS19IRUxQOyAvLyAoMkYpIEhFTFAga2V5CiAg ICAgICAgIGNhc2UgR0RLXzA6Ci0gICAgICAgIGNhc2UgR0RLX3BhcmVubGVmdDoKKyAgICAgICAg Y2FzZSBHREtfcGFyZW5yaWdodDoKICAgICAgICAgICAgIHJldHVybiBWS18wOyAgICAvLyAgKDMw KSAwKSBrZXkKICAgICAgICAgY2FzZSBHREtfMToKKyAgICAgICAgY2FzZSBHREtfZXhjbGFpbToK ICAgICAgICAgICAgIHJldHVybiBWS18xOyAvLyAgKDMxKSAxICEga2V5CiAgICAgICAgIGNhc2Ug R0RLXzI6CiAgICAgICAgIGNhc2UgR0RLX2F0OgpAQCAtMjgzLDcgKzI4NCw3IEBAIHN0YXRpYyBp bnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQga2V5Y29kZSkKICAgICAg ICAgY2FzZSBHREtfYXN0ZXJpc2s6CiAgICAgICAgICAgICByZXR1cm4gVktfODsgLy8gICgzOCkg OCBrZXkgICcqJwogICAgICAgICBjYXNlIEdES185OgotICAgICAgICBjYXNlIEdES19wYXJlbnJp Z2h0OgorICAgICAgICBjYXNlIEdES19wYXJlbmxlZnQ6CiAgICAgICAgICAgICByZXR1cm4gVktf OTsgLy8gICgzOSkgOSBrZXkgJygnCiAgICAgICAgIGNhc2UgR0RLX2E6CiAgICAgICAgIGNhc2Ug R0RLX0E6Cg== 29746 2009-04-24 09:57:25 -0700 2009-04-26 08:28:31 -0700 Fix wrong key code conversion. Fix-wrong-key-code-conversion..patch text/plain 2644 ukai YmRkNTVkMTdkNDc4MDAyYzNmYWZkZGY5NWJiMDNjMTdmNzk3ZWZhNQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlODA3ZTNkLi5jZDllMWEx IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE5IEBACisyMDA5LTA0LTIzICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggd3Jvbmcga2V5IGNvZGUgY29udmVyc2lvbi4KKworICAgICAgICBNaXNzaW5nIGNvbnZlcnNp b24gZm9yIEdES19leGxhaW0gKCchJykuCisgICAgICAgIFBhcmVucyBhcmUgb3Bwb3NpdGU6IEdE S19wYXJlbmxlZnQgaXMgb3BlbiBwYXJlbiAnKCcKKyAgICAgICAgYW5kIEdES19wYXJlbnJpZ2h0 IGlzIGNsb3NlIHBhcmVuICcpJy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI1MzY3ICAgCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9LZXlD b2RlQ29udmVyc2lvbkd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3aW5kb3dzS2V5Q29kZUZv cktleUV2ZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6d2luZG93c0tleUNvZGVGb3JLZXlFdmVudCk6CisKIDIwMDktMDQtMjQg IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gUm9iZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVD b252ZXJzaW9uR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZl cnNpb25HdGsuY3BwCmluZGV4IGEzZWZlNDQuLjJjZGUwNmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCkBAIC0xNTAsOSArMTUw LDEwIEBAIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2lnbmVkIGtleWNvZGUpCiAg ICAgY2FzZSBHREtfSGVscDoKICAgICAgICAgcmV0dXJuIFZLRVlfSEVMUDsgLy8gKDJGKSBIRUxQ IGtleQogICAgIGNhc2UgR0RLXzA6Ci0gICAgY2FzZSBHREtfcGFyZW5sZWZ0OgorICAgIGNhc2Ug R0RLX3BhcmVucmlnaHQ6CiAgICAgICAgIHJldHVybiBWS0VZXzA7ICAgIC8vICAoMzApIDApIGtl eQogICAgIGNhc2UgR0RLXzE6CisgICAgY2FzZSBHREtfZXhjbGFpbToKICAgICAgICAgcmV0dXJu IFZLRVlfMTsgLy8gICgzMSkgMSAhIGtleQogICAgIGNhc2UgR0RLXzI6CiAgICAgY2FzZSBHREtf YXQ6CkBAIC0xNzYsNyArMTc3LDcgQEAgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5z aWduZWQga2V5Y29kZSkKICAgICBjYXNlIEdES19hc3RlcmlzazoKICAgICAgICAgcmV0dXJuIFZL RVlfODsgLy8gICgzOCkgOCBrZXkgICcqJwogICAgIGNhc2UgR0RLXzk6Ci0gICAgY2FzZSBHREtf cGFyZW5yaWdodDoKKyAgICBjYXNlIEdES19wYXJlbmxlZnQ6CiAgICAgICAgIHJldHVybiBWS0VZ Xzk7IC8vICAoMzkpIDkga2V5ICcoJwogICAgIGNhc2UgR0RLX2E6CiAgICAgY2FzZSBHREtfQToK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcCBiL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAppbmRleCBmZDMzNzY1Li5kYjhjZmY2IDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCkBAIC0yNTcsOSArMjU3LDEwIEBAIHN0 YXRpYyBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQga2V5Y29kZSkK ICAgICAgICAgY2FzZSBHREtfSGVscDoKICAgICAgICAgICAgIHJldHVybiBWS19IRUxQOyAvLyAo MkYpIEhFTFAga2V5CiAgICAgICAgIGNhc2UgR0RLXzA6Ci0gICAgICAgIGNhc2UgR0RLX3BhcmVu bGVmdDoKKyAgICAgICAgY2FzZSBHREtfcGFyZW5yaWdodDoKICAgICAgICAgICAgIHJldHVybiBW S18wOyAgICAvLyAgKDMwKSAwKSBrZXkKICAgICAgICAgY2FzZSBHREtfMToKKyAgICAgICAgY2Fz ZSBHREtfZXhjbGFpbToKICAgICAgICAgICAgIHJldHVybiBWS18xOyAvLyAgKDMxKSAxICEga2V5 CiAgICAgICAgIGNhc2UgR0RLXzI6CiAgICAgICAgIGNhc2UgR0RLX2F0OgpAQCAtMjgzLDcgKzI4 NCw3IEBAIHN0YXRpYyBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQg a2V5Y29kZSkKICAgICAgICAgY2FzZSBHREtfYXN0ZXJpc2s6CiAgICAgICAgICAgICByZXR1cm4g VktfODsgLy8gICgzOCkgOCBrZXkgICcqJwogICAgICAgICBjYXNlIEdES185OgotICAgICAgICBj YXNlIEdES19wYXJlbnJpZ2h0OgorICAgICAgICBjYXNlIEdES19wYXJlbmxlZnQ6CiAgICAgICAg ICAgICByZXR1cm4gVktfOTsgLy8gICgzOSkgOSBrZXkgJygnCiAgICAgICAgIGNhc2UgR0RLX2E6 CiAgICAgICAgIGNhc2UgR0RLX0E6Cg==