253610 2023-03-08 15:11:16 -0800 [margin-trim] Trimmed block-end margins for block-level boxes in a block container should be reflected in computed style 2023-04-25 20:08:32 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/39673 InRadar P2 Normal --- 253454 255736 1 sgill26 sgill26 webkit-bug-importer oldest_to_newest 1939872 0 sgill26 2023-03-08 15:11:16 -0800 The web inspector shows the untrimmed margins for a box even if has been trimmed by the containing block's margin-trim property. 1939873 1 webkit-bug-importer 2023-03-08 15:11:43 -0800 <rdar://problem/106454992> 1940227 2 sgill26 2023-03-09 14:32:07 -0800 This scenario is actually slightly more tricky than the block-start one. By the time we get to the end of the block container, we have propagated some margin information from the top that will be used to determine the final margin of the block container. At this point we actually haven’t trimmed any of the block-end margins of the children (the m_marginBox in the renderer still contains the used value of the margin), but we only consider the propagated value to update/trim the block containers block-end margin. I think in order for this to be correct, we need to walk back up the container's children and trim the block-end margins (and block-start if the child is self collapsing) until we get to a child that is not self collapsing. I think this means that we also need to update the position for the self-collapsing children, which may be just below the first non self-collapsing child. 1950099 3 sgill26 2023-04-20 09:45:21 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12977 1950936 4 sgill26 2023-04-24 20:51:04 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/39673 1951238 5 ews-feeder 2023-04-25 20:08:30 -0700 Committed 263398@main (e44bd7f346a1): <https://commits.webkit.org/263398@main> Reviewed commits have been landed. Closing PR #12977 and removing active labels.