253601 2023-03-08 13:38:51 -0800 Improve build time by reducing includes of GraphicsLayer.h 2023-03-20 16:58:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 253837 1 bfulgham bfulgham webkit-bug-importer oldest_to_newest 1939836 0 bfulgham 2023-03-08 13:38:51 -0800 Benchmarking indicates that WebPage.h and WebPageProxy.h are expensive: 976056 ms: /Users/bfulgham/Projects/WebKit/OpenSource/Source/WebKit/UIProcess/WebPageProxy.h (included 78 times, avg 12513 ms), included via: 726039 ms: /Users/bfulgham/Projects/WebKit/OpenSource/Source/WebKit/WebProcess/WebPage/WebPage.h (included 60 times, avg 12100 ms), included via: Code review shows that they are included in many places they are not needed, and that they include expensive headers that increase build time. This patch improves build times by resolving some of these cases. 1939854 1 bfulgham 2023-03-08 14:33:03 -0800 WebPage.h drops from 12.1 seconds to about 7.4 seconds 1939857 2 webkit-bug-importer 2023-03-08 14:38:00 -0800 <rdar://problem/106453112> 1939860 3 bfulgham 2023-03-08 14:40:44 -0800 Pull request: https://github.com/WebKit/WebKit/pull/11258 1939891 4 bfulgham 2023-03-08 16:23:26 -0800 Pull request: https://github.com/Webkit/WebKit/pull/11258 1939964 5 bfulgham 2023-03-08 22:04:04 -0800 Current PR: Original Build (M1 Pro) **** Time summary: Compilation (10257 times): Parsing (frontend): 8924.2 s Codegen & opts (backend): 3158.1 s Revised Build (M1 Pro) **** Time summary: Compilation (10188 times): Parsing (frontend): 8529.2 s Codegen & opts (backend): 3150.0 s 1940988 6 bfulgham 2023-03-13 13:33:20 -0700 I split this into a second patch: Bug 253837 1942722 7 ews-feeder 2023-03-20 16:58:03 -0700 Committed 261897@main (308d27ada88a): <https://commits.webkit.org/261897@main> Reviewed commits have been landed. Closing PR #11258 and removing active labels.