<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>253537</bug_id>
          
          <creation_ts>2023-03-07 15:07:53 -0800</creation_ts>
          <short_desc>[buildbot] Move SFTP upload code from generate-bundle script to a new script for uploads and document it</short_desc>
          <delta_ts>2023-03-09 10:31:17 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=252864</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1939567</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2023-03-07 15:07:53 -0800</bug_when>
    <thetext>The current way we are uploading the built-products from the workers to the master is really slow and is causing problems (see bug 252864).

On the GTK/WPE Packaging bots, on the step `generate-bundle` we upload the bundle created via SFTP to the production server. See: https://build.webkit.org/#/builders/30

The SSH server accepting the uploads is configured in a restricted way: the clients connecting to it are only allowed to run the `sftp-internal` command and are restricted inside a chroot so they can only modify their own files.

As an extra security measure the server can be configured to move the files that the bots upload out of that directory as soon as the upload is finished.

After talking with Aakash we agreed that it would be a good idea if I can factorize this code out of this script and make it useful also for uploading the built-products to the post-commit and EWS servers

Let&apos;s try it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1939570</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2023-03-07 15:20:07 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/11193</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1940115</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-03-09 10:30:15 -0800</bug_when>
    <thetext>Committed 261448@main (c3827e6cc0dc): &lt;https://commits.webkit.org/261448@main&gt;

Reviewed commits have been landed. Closing PR #11193 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1940116</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-03-09 10:31:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/106508921&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>