25353 2009-04-23 20:45:12 -0700 Support the back/forward/stop/refresh multimedia keys 2009-06-15 19:13:46 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ben webkit-unassigned staikos oldest_to_newest 118588 0 ben 2009-04-23 20:45:12 -0700 Support the back/forward/stop/refresh multimedia keys and accept the event when handling backspace and shift backspace as we should. 118589 1 29725 ben 2009-04-23 20:45:38 -0700 Created attachment 29725 patch to fix the bug 119322 2 29725 eric 2009-04-29 13:16:43 -0700 Comment on attachment 29725 patch to fix the bug This was r+'d without a ChangeLog. Please don't do that unless you plan to land it yourself. :( 119340 3 staikos 2009-04-29 14:14:44 -0700 Are you really afraid this is going to be checked in without a changelog? 125942 4 31290 ben 2009-06-15 08:08:39 -0700 Created attachment 31290 patch to fix the bug with prepare-changelog run 126043 5 eric 2009-06-15 14:54:21 -0700 (In reply to comment #3) > Are you really afraid this is going to be checked in without a changelog? No. :) It's just I went to try and land it, and I couldn't easily because it didn't have a ChangeLog. :) The ChangeLog doesn't have a link to the bug in question. We really need to fix prepare-ChangeLog to add those for you. :) 126056 6 ben 2009-06-15 15:21:37 -0700 (In reply to comment #5) > (In reply to comment #3) > > Are you really afraid this is going to be checked in without a changelog? > > No. :) It's just I went to try and land it, and I couldn't easily because it > didn't have a ChangeLog. :) As this was a git patch the changelog text was there to be reviewed even if it wasn't in the changelog file, I didn't write a changelog, just ran the script to create it for the second patch. 126116 7 eric 2009-06-15 19:13:46 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/qt/Api/qwebpage.cpp M WebKit/qt/ChangeLog Committed r44704 M WebKit/qt/ChangeLog M WebKit/qt/Api/qwebpage.cpp r44704 = cfd7be9b10bab318302b163d42d971858c6e87f8 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk 29725 2009-04-23 20:45:38 -0700 2009-06-15 08:08:39 -0700 patch to fix the bug 0001-Support-the-back-forward-stop-refresh-multimedia-key.patch text/plain 1557 ben RnJvbSBjNGNmODE3ZmRkMjBhMWYxOTM0OTQ5ZjY4MzEwOTJmN2E1OTNhZDA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFRodSwgMjMgQXByIDIwMDkgMjI6MjY6MDkgLTA0MDAKU3ViamVj dDogW1BBVENIXSBTdXBwb3J0IHRoZSBiYWNrL2ZvcndhcmQvc3RvcC9yZWZyZXNoIG11bHRpbWVk aWEga2V5cyBhbmQgYWNjZXB0IHRoZQogZXZlbnQgd2hlbiBoYW5kbGluZyBiYWNrc3BhY2UgYW5k IHNoaWZ0IGJhY2tzcGFjZSBhcyB3ZSBzaG91bGQuCgotLS0KIFdlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwIHwgICAxMyArKysrKysrKysrKysrCiAxIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlv bnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2VicGFn ZS5jcHAgYi9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRleCBjZTJlMDEwLi44YzYyMDYy IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAorKysgYi9XZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmNwcApAQCAtNzk5LDExICs3OTksMjQgQEAgdm9pZCBRV2ViUGFnZVByaXZh dGU6OmtleVByZXNzRXZlbnQoUUtleUV2ZW50ICpldikKICAgICAgICAgaW50IGZvbnRIZWlnaHQg PSBmbS5oZWlnaHQoKTsKICAgICAgICAgaWYgKCFoYW5kbGVTY3JvbGxpbmcoZXYpKSB7CiAgICAg ICAgICAgICBzd2l0Y2ggKGV2LT5rZXkoKSkgeworICAgICAgICAgICAgY2FzZSBRdDo6S2V5X0Jh Y2s6CisgICAgICAgICAgICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6QmFjayk7Cisg ICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlIFF0OjpLZXlfRm9yd2FyZDoK KyAgICAgICAgICAgICAgICBxLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpGb3J3YXJkKTsKKyAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgUXQ6OktleV9TdG9wOgorICAg ICAgICAgICAgICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OlN0b3ApOworICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSBRdDo6S2V5X1JlZnJlc2g6CisgICAgICAg ICAgICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6UmVsb2FkKTsKKyAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgUXQ6OktleV9CYWNrc3BhY2U6CiAgICAgICAg ICAgICAgICAgaWYgKGV2LT5tb2RpZmllcnMoKSA9PSBRdDo6U2hpZnRNb2RpZmllcikKICAgICAg ICAgICAgICAgICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6Rm9yd2FyZCk7CiAgICAg ICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBxLT50cmlnZ2VyQWN0aW9uKFFX ZWJQYWdlOjpCYWNrKTsKKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1 bHQ6CiAgICAgICAgICAgICAgICAgaGFuZGxlZCA9IGZhbHNlOwogICAgICAgICAgICAgICAgIGJy ZWFrOwotLSAKMS42LjAuNAoK 31290 2009-06-15 08:08:39 -0700 2009-06-15 08:12:34 -0700 patch to fix the bug 0001-Support-the-back-forward-stop-refresh-multimedia-key.patch text/plain 2176 ben RnJvbSAwZjZiMDQ1Njk2YjEyOGU3YjZmYjgyMTUzYmVjNjIxNmUyN2JmM2JhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFRodSwgMjMgQXByIDIwMDkgMjI6MjY6MDkgLTA0MDAKU3ViamVj dDogW1BBVENIXSBTdXBwb3J0IHRoZSBiYWNrL2ZvcndhcmQvc3RvcC9yZWZyZXNoIG11bHRpbWVk aWEga2V5cyBhbmQgYWNjZXB0IHRoZQogZXZlbnQgd2hlbiBoYW5kbGluZyBiYWNrc3BhY2UgYW5k IHNoaWZ0IGJhY2tzcGFjZSBhcyB3ZSBzaG91bGQuCgotLS0KIFdlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICB8 ICAgMTAgKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2Vi S2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKaW5kZXggM2I0OGZhOC4uYjMyNjliNCAxMDA2NDQKLS0t IGEvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFn ZS5jcHAKQEAgLTc5OCwxMSArNzk4LDI0IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjprZXlQcmVz c0V2ZW50KFFLZXlFdmVudCAqZXYpCiAgICAgICAgIGludCBmb250SGVpZ2h0ID0gZm0uaGVpZ2h0 KCk7CiAgICAgICAgIGlmICghaGFuZGxlU2Nyb2xsaW5nKGV2KSkgewogICAgICAgICAgICAgc3dp dGNoIChldi0+a2V5KCkpIHsKKyAgICAgICAgICAgIGNhc2UgUXQ6OktleV9CYWNrOgorICAgICAg ICAgICAgICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkJhY2spOworICAgICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSBRdDo6S2V5X0ZvcndhcmQ6CisgICAgICAgICAg ICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6Rm9yd2FyZCk7CisgICAgICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlIFF0OjpLZXlfU3RvcDoKKyAgICAgICAgICAgICAg ICBxLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpTdG9wKTsKKyAgICAgICAgICAgICAgICBicmVh azsKKyAgICAgICAgICAgIGNhc2UgUXQ6OktleV9SZWZyZXNoOgorICAgICAgICAgICAgICAgIHEt PnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OlJlbG9hZCk7CisgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICBjYXNlIFF0OjpLZXlfQmFja3NwYWNlOgogICAgICAgICAgICAgICAgIGlm IChldi0+bW9kaWZpZXJzKCkgPT0gUXQ6OlNoaWZ0TW9kaWZpZXIpCiAgICAgICAgICAgICAgICAg ICAgIHEtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OkZvcndhcmQpOwogICAgICAgICAgICAgICAg IGVsc2UKICAgICAgICAgICAgICAgICAgICAgcS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6QmFj ayk7CisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAg ICAgICAgICAgIGhhbmRsZWQgPSBmYWxzZTsKICAgICAgICAgICAgICAgICBicmVhazsKZGlmZiAt LWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGQ3 N2M1NWYuLjc4NTUwM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA2LTE1ICBCZW5qYW1pbiBD IE1leWVyICA8YmVuamFtaW4ubWV5ZXJAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gVHJlYXQuCisKKyAgICAgICAgU3VwcG9ydCB0aGUgYmFjay9mb3J3YXJkL3N0 b3AvcmVmcmVzaCBtdWx0aW1lZGlhIGtleXMgYW5kIGFjY2VwdCB0aGUKKyAgICAgICAgZXZlbnQg d2hlbiBoYW5kbGluZyBiYWNrc3BhY2UgYW5kIHNoaWZ0IGJhY2tzcGFjZSBhcyB3ZSBzaG91bGQu CisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRl OjprZXlQcmVzc0V2ZW50KToKKwogMjAwOS0wNi0xNSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5o YXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBUcmVhdC4KLS0g CjEuNi4wLjQKCg==