253481 2023-03-06 19:00:12 -0800 Fold CallFrameClosure into CachedCall. 2023-03-06 23:29:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam webkit-bug-importer oldest_to_newest 1939314 0 mark.lam 2023-03-06 19:00:12 -0800 CallFrameClosure is always embedded into and used with a CachedCall. This patch makes the following changes: 1. By folding it into CachedCall, we can remove many redundancies e.g. a protoCallFrame pointer, a JSFunction pointer, a VM pointer, and argumentCountIncludingThis. 2. CallFrameClosure::parameterCountIncludingThis was also never used. So, remove it. 3. Remove CachedCall::m_interpreter because it is always as an offset from CachedCall::m_vm. 4. Added an optimization to compute VM& from Interpreter*. This eliminates the need to pass globalObject to a few Interpreter::executeXXX functions where the sole purpose of the globalObject is for computing VM&. 5. Add an optimization in Interpreter::executeCachedCall where we can skip the call to ScriptExecutable::prepareForExecution if the addressForCall is unchanged. 6. Remove the now unneeded CallFrameClosure. 7. Rename Interpreter::prepareForRepeatCall to prepareForCachedCall to match what it's actually preparing for. 1939315 1 webkit-bug-importer 2023-03-06 19:00:56 -0800 <rdar://problem/106341933> 1939320 2 mark.lam 2023-03-06 19:08:00 -0800 Pull request: https://github.com/WebKit/WebKit/pull/11147 1939358 3 ews-feeder 2023-03-06 23:29:40 -0800 Committed 261311@main (dd4b91af70c5): <https://commits.webkit.org/261311@main> Reviewed commits have been landed. Closing PR #11147 and removing active labels.