<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>253462</bug_id>
          
          <creation_ts>2023-03-06 13:56:33 -0800</creation_ts>
          <short_desc>CSS @imports in HTML missing semi-colon and space are mistakenly hidden from CSSPreload Scanner</short_desc>
          <delta_ts>2023-08-26 03:12:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Page Loading</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BrowserCompat, InRadar, WPTImpact</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>beidson</cc>
    
    <cc>karlcow</cc>
    
    <cc>koivisto</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1939232</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-03-06 13:56:33 -0800</bug_when>
    <thetext>Hi Team,

This is continuation bug from bug 191466, where merging Chromium / Blink patch has now resolved one case from our CSS Preloader where &apos;quote-marks&apos; work.

Attaching Chromium / Blink patch resulted in failing following testcase:

http/tests/loading/preload-css-import-layer.html

______

Antti suggested that it could be because of following:

I think this is wrong since there may be more things to parse after the first ) like in

url(&quot;foo.css&quot;) layer(foo)

This is causing the test failure.

_____

WPT Test Case - https://wpt.fyi/results/loading?label=master&amp;label=experimental&amp;aligned=&amp;view=subtest&amp;q=loading%2F

preloader-css-import-no-space.tentative.html &amp; preloader-css-import-no-semicolon.tentative.html

_____

Following was skipped from Chromium / Blink patch:

// When reading the rule and hitting &apos;)&apos;, which signifies the URL end, emit the rule.
            if (c == &apos;)&apos;)
                emitRule();  

While this patch seems to suggest &apos;Chromium&apos; support of layers in CSS Preloader:

https://chromium.googlesource.com/chromium/src/+/d53bf2d989eb0756ae2689f1b16c2875e5384e5e

_________

Just wanted to raise this so we can track failing test cases and fix them since all other browsers are passing them.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1941011</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-03-13 14:57:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/106666050&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1973384</commentid>
    <comment_count>2</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-08-24 16:09:23 -0700</bug_when>
    <thetext>I have local patch, which progress these two tests but don&apos;t know if it cause any other regression, I will do draft PR to test and document (if I couldn&apos;t manage to land for any reason).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1973763</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-08-26 03:12:20 -0700</bug_when>
    <thetext>Committed 267322@main (af134e645543): &lt;https://commits.webkit.org/267322@main&gt;

Reviewed commits have been landed. Closing PR #17043 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>