<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>253454</bug_id>
          
          <creation_ts>2023-03-06 12:08:51 -0800</creation_ts>
          <short_desc>Web Inspector: Box model should indicate that a margin has been &quot;trimmed&quot; by its containing block&apos;s `margin-trim` property</short_desc>
          <delta_ts>2023-04-26 16:01:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>253606</dependson>
    
    <dependson>253610</dependson>
    
    <dependson>253712</dependson>
    
    <dependson>253713</dependson>
    
    <dependson>253714</dependson>
    
    <dependson>253715</dependson>
    
    <dependson>253716</dependson>
    
    <dependson>253717</dependson>
    
    <dependson>253718</dependson>
    
    <dependson>253719</dependson>
    
    <dependson>255736</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sammy Gill">sgill26</reporter>
          <assigned_to name="Sammy Gill">sgill26</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1939200</commentid>
    <comment_count>0</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2023-03-06 12:08:51 -0800</bug_when>
    <thetext>Web Inspector currently does not take into account the rendered box for showing the element’s box model, but with `margin-trim`, the computed margins may no longer be the same as the used margins, as they might be trimmed by the parent container. We should provide some sort of treatment to indicate this - we should also think a bit more deeply about how to do so, since we currently allow editing margins in the box model, but now that edit may not visually affect anything if that margin was trimmed.

Without this work, the box model may show a margin for an edge of an element where no margin was applied at layout time. Not a horrible regression, but odd.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1939201</commentid>
    <comment_count>1</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2023-03-06 12:09:31 -0800</bug_when>
    <thetext>I think the solution for this will be to update the margin computed value when we do any trimming</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1939202</commentid>
    <comment_count>2</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2023-03-06 12:09:50 -0800</bug_when>
    <thetext>rdar://103374677</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1951467</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2023-04-26 16:01:54 -0700</bug_when>
    <thetext>All subtasks are now complete.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>