25343 2009-04-23 07:50:48 -0700 -webkit-box-shadow with 0,0 offset ignores blur 2009-04-24 11:44:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet dglazkov japhet oldest_to_newest 118494 0 japhet 2009-04-23 07:50:48 -0700 Regression introduced in http://trac.webkit.org/changeset/42375 If -webkit-box-shadow is used with height and width of 0, the blur value is being ignored. This is causing LayoutTests/fast/repaint/box-shadow-h.html and LayoutTests/fast/repaint/box-shadow-v.html to fail. 118495 1 29711 japhet 2009-04-23 07:54:30 -0700 Created attachment 29711 Patch 118665 2 29711 dglazkov 2009-04-24 10:05:23 -0700 Comment on attachment 29711 Patch Good work and welcome :) A couple of things about ChangeLog contents. It's actually very handy (like when perusing trac), so we really try to put more details there. This would be a good ChangeLog entry: 2009-04-22 Nate Chapin <japhet@google.com> Reviewed by NOBODY (OOPS!). https://bugs.webkit.org/show_bug.cgi?id=25343 Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset ignores blur. * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Added an extra check for blur. In other words: * URL of the bug * Brief description of the bug * For each change, brief documentation of what it is. r-, but only because of this. > +2009-04-22 Nate Chapin <japhet@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp > +: > + > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 42752) > +++ ChangeLog (working copy) > @@ -1,3 +1,10 @@ > +2009-04-22 Nate Chapin <japhet@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp > +: > + > 2009-04-14 Xan Lopez <xlopez@igalia.com> > > Unreviewed version bump in preparation for 1.1.5 release. > Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp > =================================================================== > --- WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (revision 42752) > +++ WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (working copy) > @@ -963,7 +963,7 @@ void GraphicsContext::setPlatformShadow( > return; > > // Detect when there's no effective shadow and clear the looper. > - if (size.width() == 0 && size.height() == 0) { > + if (size.width() == 0 && size.height() == 0 && blurInt == 0) { > platformContext()->setDrawLooper(NULL); > return; > } 118667 3 29747 japhet 2009-04-24 10:19:05 -0700 Created attachment 29747 Patch2 118669 4 29747 dglazkov 2009-04-24 10:23:25 -0700 Comment on attachment 29747 Patch2 There's an errant floatey colon at the end of ChangeLog, but I'll clean up when landing. 118685 5 dglazkov 2009-04-24 11:44:05 -0700 Landed as http://trac.webkit.org/changeset/42833. 29711 2009-04-23 07:54:30 -0700 2009-04-24 10:22:24 -0700 Patch patch.txt text/plain 1060 japhet SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNDI3 NTIpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMCBAQAorMjAwOS0w NC0yMiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVccGxhdGZvcm1cZ3JhcGhp Y3Ncc2tpYVxHcmFwaGljc0NvbnRleHRTa2lhLmNwcAorOgorCiAyMDA5LTA0LTE0ICBYYW4gTG9w ZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHZlcnNpb24gYnVt cCBpbiBwcmVwYXJhdGlvbiBmb3IgMS4xLjUgcmVsZWFzZS4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcA0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAko cmV2aXNpb24gNDI3NTIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhp Y3NDb250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2Myw3ICs5NjMsNyBAQCB2b2lk IEdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1TaGFkb3coCiAgICAgICAgIHJldHVybjsKIAog ICAgIC8vIERldGVjdCB3aGVuIHRoZXJlJ3Mgbm8gZWZmZWN0aXZlIHNoYWRvdyBhbmQgY2xlYXIg dGhlIGxvb3Blci4KLSAgICBpZiAoc2l6ZS53aWR0aCgpID09IDAgJiYgc2l6ZS5oZWlnaHQoKSA9 PSAwKSB7CisgICAgaWYgKHNpemUud2lkdGgoKSA9PSAwICYmIHNpemUuaGVpZ2h0KCkgPT0gMCAm JiBibHVySW50ID09IDApIHsKICAgICAgICAgcGxhdGZvcm1Db250ZXh0KCktPnNldERyYXdMb29w ZXIoTlVMTCk7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg== 29747 2009-04-24 10:19:05 -0700 2009-04-24 10:23:25 -0700 Patch2 patch2.txt text/plain 1327 japhet SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNDI3 NTIpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0w NC0yMiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjUzNDMKKyAgICAgICAgRml4IENocm9taXVtL1NraWEgYnVnIHdoZXJl IC13ZWJraXQtYm94LXNoYWRvdyB3aXRoIDAsMCBvZmZzZXQgCisgICAgICAgIGlnbm9yZXMgYmx1 ci4KKworICAgICAgICAqIFdlYkNvcmVccGxhdGZvcm1cZ3JhcGhpY3Ncc2tpYVxHcmFwaGljc0Nv bnRleHRTa2lhLmNwcAorICAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0UGxh dGZvcm1TaGFkb3cpOiBBZGQgY2hlY2sgYWdhaW5zdAorICAgICAgICAgYmx1ciBiZWZvcmUgY2xl YXJpbmcgbG9vcGVyLgorOgorCiAyMDA5LTA0LTE0ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlh LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHZlcnNpb24gYnVtcCBpbiBwcmVwYXJhdGlvbiBm b3IgMS4xLjUgcmVsZWFzZS4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9H cmFwaGljc0NvbnRleHRTa2lhLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gNDI3NTIpCisr KyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTk2Myw3ICs5NjMsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6 c2V0UGxhdGZvcm1TaGFkb3coCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIERldGVjdCB3aGVu IHRoZXJlJ3Mgbm8gZWZmZWN0aXZlIHNoYWRvdyBhbmQgY2xlYXIgdGhlIGxvb3Blci4KLSAgICBp ZiAoc2l6ZS53aWR0aCgpID09IDAgJiYgc2l6ZS5oZWlnaHQoKSA9PSAwKSB7CisgICAgaWYgKHNp emUud2lkdGgoKSA9PSAwICYmIHNpemUuaGVpZ2h0KCkgPT0gMCAmJiBibHVySW50ID09IDApIHsK ICAgICAgICAgcGxhdGZvcm1Db250ZXh0KCktPnNldERyYXdMb29wZXIoTlVMTCk7CiAgICAgICAg IHJldHVybjsKICAgICB9Cg==