253348 2023-03-03 15:10:05 -0800 Use smart pointers for PageConfiguration 2023-03-07 09:05:56 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen dpino dpino webkit-bug-importer oldest_to_newest 1938659 0 achristensen 2023-03-03 15:10:05 -0800 ... 1938660 1 webkit-bug-importer 2023-03-03 15:10:19 -0800 <rdar://problem/106214366> 1938664 2 achristensen 2023-03-03 15:19:16 -0800 Pull request: https://github.com/WebKit/WebKit/pull/11033 1938842 3 ews-feeder 2023-03-04 09:35:47 -0800 Committed 261225@main (c4ee0780b398): <https://commits.webkit.org/261225@main> Reviewed commits have been landed. Closing PR #11033 and removing active labels. 1939321 4 dpino 2023-03-06 19:15:01 -0800 After this patch, I'm getting the following build error in WinCairo: ``` 57>WebPage.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl WebKit::WebChromeClient::~WebChromeClient(void)" (??1WebChromeClient@WebKit@@UEAA@XZ) referenced in function "public: virtual void * __cdecl WebKit::WebChromeClient::`scalar deleting destructor'(unsigned int)" (??_GWebChromeClient@WebKit@@UEAAPEAXI@Z) ``` Apparently WinCairo build bot hasn't detected this build error. https://build.webkit.org/#/builders/731 I'm doing a clean build. I wonder whether a clean build in the CI bot may trigger the issue. My environment is: - OS: Windows10. - Compiler: Microsoft Visual Studio 2022. 1939322 5 dpino 2023-03-06 19:18:25 -0800 Re-opening for pull request https://github.com/webkit/webkit/pull/11148 1939466 6 ews-feeder 2023-03-07 09:05:37 -0800 Committed 261327@main (89cc5666c25a): <https://commits.webkit.org/261327@main> Reviewed commits have been landed. Closing PR #11148 and removing active labels.