253298 2023-03-02 23:06:30 -0800 Fix control flow with multiple exits on single-pass BBQ JIT 2023-03-03 01:03:38 -0800 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 252209 1 d_degazio d_degazio webkit-bug-importer oldest_to_newest 1938417 0 d_degazio 2023-03-02 23:06:30 -0800 rdar://106182518 Currently, in control flow instructions with multiple exits (namely br_if and br_table), we assume that the calling convention for each target’s block arguments will be the same. This is not the case universally though: - When targeting the top level block, the results are allocated according to the WASM calling convention, not the block calling convention. - If we run out of registers to use for the block calling convention, we pass arguments through WASM canonical stack slots. But the stack height of these may vary between target blocks, even if they have the same signature. To fix this, we need to modify the ControlData methods currently used to manage control flow blocks, to permit setting up for multiple distinct exit branches per block. 1938418 1 d_degazio 2023-03-02 23:19:51 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10988 1938429 2 ews-feeder 2023-03-03 01:03:36 -0800 Committed 261122@main (bc648d25c5aa): <https://commits.webkit.org/261122@main> Reviewed commits have been landed. Closing PR #10988 and removing active labels.