25329 2009-04-22 12:32:30 -0700 v8 binding of ClientRectList doesn't have indexed access method 2014-04-24 16:45:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ukai ukai oldest_to_newest 118403 0 ukai 2009-04-22 12:32:30 -0700 v8 binding of ClientRectList doesn't have indexed access method. For example, on translate.google.com chromium doesn't show balloon because of the following code throws JavaScript exception. p = a.getClientRects(); ... ; ... p[0].top // p[0] is undefined in chromium According to CSSOM View Module spec, ClientRectList must provide indexed access method that acts like item() method. http://dev.w3.org/csswg/cssom-view/#clientrectlist 118440 1 29695 ukai 2009-04-22 16:19:43 -0700 Created attachment 29695 Add V8ClientRectListCustom.cpp WebCore/ChangeLog | 9 +++ .../bindings/v8/custom/V8ClientRectListCustom.cpp | 55 ++++++++++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) 118442 2 29695 dglazkov 2009-04-22 16:42:44 -0700 Comment on attachment 29695 Add V8ClientRectListCustom.cpp Looks good, except for: Add Bug URL (https://bugs.webkit.org/show_bug.cgi?id=25329) here.. > + Add indexed access method in v8 binding of ClientRectList. > + > + * bindings/v8/custom/V8ClientRectListCustom.cpp: Added. > + (WebCore::INDEXED_PROPERTY_GETTER): 118444 3 29696 ukai 2009-04-22 16:48:44 -0700 Created attachment 29696 Add V8ClientRectListCustom.cpp WebCore/ChangeLog | 9 +++ .../bindings/v8/custom/V8ClientRectListCustom.cpp | 55 ++++++++++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) 118445 4 29697 ukai 2009-04-22 16:48:46 -0700 Created attachment 29697 add bug URL in ChangeLog WebCore/ChangeLog | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) 118681 5 dglazkov 2009-04-24 11:36:45 -0700 Landed as http://trac.webkit.org/changeset/42829. 1003841 6 darin 2014-04-24 16:45:01 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 29695 2009-04-22 16:19:43 -0700 2009-04-22 16:42:44 -0700 Add V8ClientRectListCustom.cpp Add-V8ClientRectListCustom.cpp.patch text/plain 3069 ukai NDUwOTBhNjAwMDg4M2JiMjU3MTYwZGJjNDQyMzEzZTIzMzZjMGZmYgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZWFkYTYzLi5iZTFjNjIy IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDA5LTA0LTIyICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgaW5kZXhlZCBhY2Nlc3MgbWV0aG9kIGluIHY4IGJpbmRpbmcgb2YgQ2xpZW50UmVjdExpc3Qu CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhDbGllbnRSZWN0TGlzdEN1c3RvbS5j cHA6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6SU5ERVhFRF9QUk9QRVJUWV9HRVRURVIpOgor CiAyMDA5LTA0LTIyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggYSBjcmFzaCBpbiBNYWlsIHdoZW4gZm9yd2FyZGluZyBhIHNwZWNpZmljIEhUTUwg ZW1haWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENsaWVudFJl Y3RMaXN0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q2xpZW50UmVj dExpc3RDdXN0b20uY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmUzZjg5 YjkKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENsaWVu dFJlY3RMaXN0Q3VzdG9tLmNwcApAQCAtMCwwICsxLDU1IEBACisvKgorICogQ29weXJpZ2h0IChD KSAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6CisgKgorICogICAgICogUmVkaXN0cmlidXRpb25z IG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4K KyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0 aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlvbi4KKyAq ICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBp dHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJv ZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJp b3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQg QlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAqICJBUyBJUyIgQU5E IEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisg KiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBB TkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJ TiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBDT05UUklCVVRPUlMg QkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyAqIFNQRUNJ QUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBO T1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS VklDRVM7IExPU1MgT0YgVVNFLAorICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVPUlkgT0YgTElBQklM SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAo SU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VU IE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgor I2luY2x1ZGUgIkNsaWVudFJlY3RMaXN0LmgiCisKKyNpbmNsdWRlICJDbGllbnRSZWN0LmgiCisK KyNpbmNsdWRlICJWOEJpbmRpbmcuaCIKKyNpbmNsdWRlICJWOEN1c3RvbUJpbmRpbmcuaCIKKyNp bmNsdWRlICJWOFByb3h5LmgiCisKKyNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CisKK25hbWVzcGFj ZSBXZWJDb3JlIHsKKworSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoQ2xpZW50UmVjdExpc3QpCit7 CisgICAgSU5DX1NUQVRTKCJET00uQ2xpZW50UmVjdExpc3QuSW5kZXhlZFByb3BlcnR5R2V0dGVy Iik7CisgICAgQ2xpZW50UmVjdExpc3QqIGltcCA9IFY4UHJveHk6OlRvTmF0aXZlT2JqZWN0PENs aWVudFJlY3RMaXN0PihWOENsYXNzSW5kZXg6OkNMSUVOVFJFQ1RMSVNULCBpbmZvLkhvbGRlcigp KTsKKyAgICBSZWZQdHI8Q2xpZW50UmVjdD4gcmVzdWx0ID0gaW1wLT5pdGVtKGluZGV4KTsKKyAg ICBpZiAoIXJlc3VsdCkKKyAgICAgICAgcmV0dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7 CisKKyAgICByZXR1cm4gVjhQcm94eTo6VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OkNMSUVOVFJF Q1QsIHJlc3VsdC5nZXQoKSk7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 29696 2009-04-22 16:48:44 -0700 2009-04-24 11:33:48 -0700 Add V8ClientRectListCustom.cpp Add-V8ClientRectListCustom.cpp.patch text/plain 3069 ukai NDUwOTBhNjAwMDg4M2JiMjU3MTYwZGJjNDQyMzEzZTIzMzZjMGZmYgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZWFkYTYzLi5iZTFjNjIy IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDA5LTA0LTIyICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgaW5kZXhlZCBhY2Nlc3MgbWV0aG9kIGluIHY4IGJpbmRpbmcgb2YgQ2xpZW50UmVjdExpc3Qu CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhDbGllbnRSZWN0TGlzdEN1c3RvbS5j cHA6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6SU5ERVhFRF9QUk9QRVJUWV9HRVRURVIpOgor CiAyMDA5LTA0LTIyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggYSBjcmFzaCBpbiBNYWlsIHdoZW4gZm9yd2FyZGluZyBhIHNwZWNpZmljIEhUTUwg ZW1haWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENsaWVudFJl Y3RMaXN0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q2xpZW50UmVj dExpc3RDdXN0b20uY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmUzZjg5 YjkKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENsaWVu dFJlY3RMaXN0Q3VzdG9tLmNwcApAQCAtMCwwICsxLDU1IEBACisvKgorICogQ29weXJpZ2h0IChD KSAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6CisgKgorICogICAgICogUmVkaXN0cmlidXRpb25z IG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4K KyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0 aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlvbi4KKyAq ICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBp dHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJv ZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJp b3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQg QlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAqICJBUyBJUyIgQU5E IEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisg KiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBB TkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJ TiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBDT05UUklCVVRPUlMg QkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyAqIFNQRUNJ QUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBO T1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS VklDRVM7IExPU1MgT0YgVVNFLAorICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVPUlkgT0YgTElBQklM SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAo SU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VU IE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgor I2luY2x1ZGUgIkNsaWVudFJlY3RMaXN0LmgiCisKKyNpbmNsdWRlICJDbGllbnRSZWN0LmgiCisK KyNpbmNsdWRlICJWOEJpbmRpbmcuaCIKKyNpbmNsdWRlICJWOEN1c3RvbUJpbmRpbmcuaCIKKyNp bmNsdWRlICJWOFByb3h5LmgiCisKKyNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CisKK25hbWVzcGFj ZSBXZWJDb3JlIHsKKworSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoQ2xpZW50UmVjdExpc3QpCit7 CisgICAgSU5DX1NUQVRTKCJET00uQ2xpZW50UmVjdExpc3QuSW5kZXhlZFByb3BlcnR5R2V0dGVy Iik7CisgICAgQ2xpZW50UmVjdExpc3QqIGltcCA9IFY4UHJveHk6OlRvTmF0aXZlT2JqZWN0PENs aWVudFJlY3RMaXN0PihWOENsYXNzSW5kZXg6OkNMSUVOVFJFQ1RMSVNULCBpbmZvLkhvbGRlcigp KTsKKyAgICBSZWZQdHI8Q2xpZW50UmVjdD4gcmVzdWx0ID0gaW1wLT5pdGVtKGluZGV4KTsKKyAg ICBpZiAoIXJlc3VsdCkKKyAgICAgICAgcmV0dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7 CisKKyAgICByZXR1cm4gVjhQcm94eTo6VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OkNMSUVOVFJF Q1QsIHJlc3VsdC5nZXQoKSk7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 29697 2009-04-22 16:48:46 -0700 2009-04-24 11:33:56 -0700 add bug URL in ChangeLog add-bug-URL-in-ChangeLog.patch text/plain 453 ukai ZGJlYTAyN2ZkOTZlYmY4YTNkN2ZlOTdhMGEzYzFhYjMyYWNhNDBjMApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiZTFjNjIyLi5kNjA3YzI5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMyw2ICszLDcgQEAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKICAg ICAgICAgQWRkIGluZGV4ZWQgYWNjZXNzIG1ldGhvZCBpbiB2OCBiaW5kaW5nIG9mIENsaWVudFJl Y3RMaXN0LgorCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTMyOQog CiAgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q2xpZW50UmVjdExpc3RDdXN0b20uY3Bw OiBBZGRlZC4KICAgICAgICAgKFdlYkNvcmU6OklOREVYRURfUFJPUEVSVFlfR0VUVEVSKToK