253287 2023-03-02 18:06:21 -0800 AX: Enable XCTests to run in isolated tree mode. 2023-03-03 11:57:51 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white tyler_w webkit-bug-importer oldest_to_newest 1938368 0 andresg_22 2023-03-02 18:06:21 -0800 At the moment XCTests only run in Non-ITM. 1938369 1 webkit-bug-importer 2023-03-02 18:07:08 -0800 <rdar://problem/106174406> 1938370 2 465270 andresg_22 2023-03-02 18:10:31 -0800 Created attachment 465270 Patch 1938384 3 465270 tyler_w 2023-03-02 18:45:34 -0800 Comment on attachment 465270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465270&action=review > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666 > + || client == kAXClientTypeXCTest); Should this have UNLIKELY to help the branch predictor? 1938387 4 andresg_22 2023-03-02 18:57:46 -0800 (In reply to Tyler Wilcock from comment #3) > Comment on attachment 465270 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465270&action=review > > > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666 > > + || client == kAXClientTypeXCTest); > > Should this have UNLIKELY to help the branch predictor? It does, UNLIKELY(...) encompasses WebKitTesting || SCTest. 1938388 5 tyler_w 2023-03-02 18:58:46 -0800 (In reply to Andres Gonzalez from comment #4) > (In reply to Tyler Wilcock from comment #3) > > Comment on attachment 465270 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=465270&action=review > > > > > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666 > > > + || client == kAXClientTypeXCTest); > > > > Should this have UNLIKELY to help the branch predictor? > > It does, UNLIKELY(...) encompasses WebKitTesting || SCTest. Oops! Sorry. 1938596 6 ews-feeder 2023-03-03 11:57:45 -0800 Committed 261159@main (2ab27dd5700e): <https://commits.webkit.org/261159@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465270. 465270 2023-03-02 18:10:31 -0800 2023-03-03 11:57:47 -0800 Patch bug-253287-20230302211030.patch text/plain 1256 andresg_22 RnJvbSBjNDZiY2YxNWUwOGQ3NDQ5MzA2ODJhYTMyMDdmNWVkOWFmYzg0YmVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXMgR29uemFsZXogPGFuZHJlc2dfMjJAYXBwbGUuY29t PgpEYXRlOiBUaHUsIDIgTWFyIDIwMjMgMjE6MDM6MjUgLTA1MDAKU3ViamVjdDogW1BBVENIXSBB WDogRW5hYmxlIFhDVGVzdHMgdG8gcnVuIGluIGlzb2xhdGVkIHRyZWUgbW9kZS4KIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTMyODcgPHJkYXI6Ly9wcm9ibGVtLzEw NjE3NDQwNj4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L21hYy9BWE9iamVjdENhY2hlTWFjLm1tOgooV2ViQ29yZTo6QVhPYmplY3RD YWNoZTo6Y2xpZW50U3VwcG9ydHNJc29sYXRlZFRyZWUpOgpJbmNsdWRlIHRoZSBjYXNlIGtBWENs aWVudFR5cGVYQ1Rlc3QuCi0tLQogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvQVhP YmplY3RDYWNoZU1hYy5tbSB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9tYWMvQVhPYmplY3RDYWNoZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv bWFjL0FYT2JqZWN0Q2FjaGVNYWMubW0KaW5kZXggYzEzZDZhODg1N2E5Li4wNmIyZmRmNGM5OGYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FYT2JqZWN0Q2Fj aGVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvQVhPYmplY3RD YWNoZU1hYy5tbQpAQCAtNjYyLDcgKzY2Miw4IEBAIGJvb2wgQVhPYmplY3RDYWNoZTo6Y2xpZW50 U3VwcG9ydHNJc29sYXRlZFRyZWUoKQogewogICAgIGF1dG8gY2xpZW50ID0gX0FYR2V0Q2xpZW50 Rm9yQ3VycmVudFJlcXVlc3RVbnRydXN0ZWQoKTsKICAgICByZXR1cm4gY2xpZW50ID09IGtBWENs aWVudFR5cGVWb2ljZU92ZXIKLSAgICAgICAgfHwgVU5MSUtFTFkoY2xpZW50ID09IGtBWENsaWVu dFR5cGVXZWJLaXRUZXN0aW5nKTsKKyAgICAgICAgfHwgVU5MSUtFTFkoY2xpZW50ID09IGtBWENs aWVudFR5cGVXZWJLaXRUZXN0aW5nCisgICAgICAgIHx8IGNsaWVudCA9PSBrQVhDbGllbnRUeXBl WENUZXN0KTsKIH0KIAogYm9vbCBBWE9iamVjdENhY2hlOjppc0lzb2xhdGVkVHJlZUVuYWJsZWQo KQo=