25325 2009-04-22 08:53:05 -0700 Make sure pthread_self() is declared before it gets called 2009-05-14 07:27:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned zecke oldest_to_newest 118380 0 laszlo.gombos 2009-04-22 08:53:05 -0700 On some Unix-like platforms Collector.cpp fails to compile because pthread.h does not get included. The problem might be specific to those WebKit ports where neither WTF_USE_PTHREADS nor JSC_MULTIPLE_THREADS is defined (e.g. Qt port on Linux/FREEBSD/NETBSD). The currentThreadStackBase() in Collector.cpp calls pthread_self() on most Unix-like platforms. OPENBSD includes pthread.h explicitly but none of the other Unix-like platforms do so. On the Qt Linux WebKit build, pthread.h gets implicitly included from algorithm, which makes the Qt Unix-like builds dependent on a particular STL implementation. 118381 1 29680 laszlo.gombos 2009-04-22 08:59:43 -0700 Created attachment 29680 Proposed fix to include pthread.h in most Unix-like platforms (not just for OPENBSD) in Collector.cpp. 120782 2 29680 zecke 2009-05-11 20:37:37 -0700 Comment on attachment 29680 Proposed fix to include pthread.h in most Unix-like platforms (not just for OPENBSD) in Collector.cpp. > > #if PLATFORM(SOLARIS) > #include <thread.h> > -#endif > - > -#if PLATFORM(OPENBSD) > +#else > #include <pthread.h> > #endif > I'm not convinced why including this for WINDOWS and DARWIN is a good idea. 120783 3 laszlo.gombos 2009-05-11 20:46:52 -0700 (In reply to comment #2) > (From update of attachment 29680 [review]) > > > > #if PLATFORM(SOLARIS) > > #include <thread.h> > > -#endif > > - > > -#if PLATFORM(OPENBSD) > > +#else > > #include <pthread.h> > > #endif > > > I'm not convinced why including this for WINDOWS and DARWIN is a good idea. This entire code segment is guarded with #if PLATFORM(DARWIN) #elif PLATFORM(WIN_OS) #elif PLATFORM(UNIX) so pthread.h won't be included for WIN_OS and DARWIN. I realize that the diff does not show enough context in this case. With this additional information, I will put up the patch for review again. 120848 4 29680 darin 2009-05-12 07:48:17 -0700 Comment on attachment 29680 Proposed fix to include pthread.h in most Unix-like platforms (not just for OPENBSD) in Collector.cpp. Seems OK, r=me But maybe HAVE_PTHREAD_H would be an even more reliable way of doing this. 121288 5 zecke 2009-05-14 07:27:06 -0700 Landed in r43698. 29680 2009-04-22 08:59:43 -0700 2009-05-12 07:48:17 -0700 Proposed fix to include pthread.h in most Unix-like platforms (not just for OPENBSD) in Collector.cpp. patch_25325.txt text/plain 1012 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQyNzQ5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMjIgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNTMyNQorCisgICAgICAgIE1ha2Ugc3VyZSBwdGhyZWFkX3NlbGYoKSBpcyBk ZWNsYXJlZCBiZWZvcmUgaXQgZ2V0cyBjYWxsZWQgaW4gQ29sbGVjdG9yLmNwcAorCisgICAgICAg ICogcnVudGltZS9Db2xsZWN0b3IuY3BwOiBJbmNsdWRlIHB0aHJlYWQuaCBpbiBtb3N0IFVuaXgt bGlrZSBwbGF0Zm9ybXMgCisgICAgICAgIChub3QganVzdCBmb3IgT1BFTkJTRCkKKwogMjAwOS0w NC0yMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoQnVpbGRmaXgpLgpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xs ZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9y LmNwcAkocmV2aXNpb24gNDI3NDgpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rv ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5LDkgKzU5LDcgQEAKIAogI2lmIFBMQVRGT1JNKFNP TEFSSVMpCiAjaW5jbHVkZSA8dGhyZWFkLmg+Ci0jZW5kaWYKLQotI2lmIFBMQVRGT1JNKE9QRU5C U0QpCisjZWxzZQogI2luY2x1ZGUgPHB0aHJlYWQuaD4KICNlbmRpZgogCg==