25320 2009-04-21 17:35:58 -0700 Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers) 2009-05-03 17:01:49 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 justin.garcia justin.garcia mitz oldest_to_newest 118341 0 justin.garcia 2009-04-21 17:35:58 -0700 moveParagraphToNewBlockIfNecessary can lead to a crash if the paragraph is in an editable root that contains no visible content. <rdar://problem/6806475> 118342 1 29672 justin.garcia 2009-04-21 17:44:42 -0700 Created attachment 29672 patch 118346 2 29672 mitz 2009-04-21 18:25:53 -0700 Comment on attachment 29672 patch r=me > \ No newline at end of file Please add a newline to the test before checking in. 118348 3 justin.garcia 2009-04-21 18:53:45 -0700 http://trac.webkit.org/changeset/42735 119748 4 ddkilzer 2009-05-03 17:01:49 -0700 See also: <rdar://problem/6831340> 29672 2009-04-21 17:44:42 -0700 2009-04-21 18:25:53 -0700 patch 25320.txt text/plain 3710 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjczNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDQtMjEgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUzMjAKKyAgICAg ICAgQ3Jhc2ggd2hlbiBjaGFuZ2luZyBibG9jayBzdHlsZXMgaW4gYSByb290IHRoYXQgY29udGFp bnMgbm8gdmlzaWJsZSBjb250ZW50IChidXQgY29udGFpbnMgbm9kZXMgd2l0aCByZW5kZXJlcnMp CisKKyAgICAgICAgKiBlZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBoQ29udGVudHNUb05l d0Jsb2NrSWZOZWNlc3NhcnkpOiBJZiB0aGUgZW5jbG9zaW5nIGJsb2NrIGlzIHRoZSAKKyAgICAg ICAgcm9vdCBlZGl0YWJsZSBlbGVtZW50IGFuZCBpdCBjb250YWlucyBubyB2aXNpYmxlIGNvbnRl bnQsIGNyZWF0ZSBhIG5ldyBibG9jayBidXQgZG9uJ3QgdHJ5IGFuZCBtb3ZlIAorICAgICAgICBj b250ZW50IGludG8gaXQsIHNpbmNlIHRoZXJlJ3Mgbm90aGluZyBmb3IgbW92ZVBhcmFncmFwaHMg dG8gbW92ZS4KKyAgICAgICAgCisKIDIwMDktMDQtMjEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJD b3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAJKHJldmlzaW9uIDQyNzIxKQorKysg V2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjU2LDkgKzY1Niw5IEBACiAgICAgICAgIC8vIElmIHRoZSBibG9jayBpcyB0aGUgcm9vdCBl ZGl0YWJsZSBlbGVtZW50LCBhbHdheXMgbW92ZSBjb250ZW50IHRvIGEgbmV3IGJsb2NrLAogICAg ICAgICAvLyBzaW5jZSBpdCBpcyBpbGxlZ2FsIHRvIG1vZGlmeSBhdHRyaWJ1dGVzIG9uIHRoZSBy b290IGVkaXRhYmxlIGVsZW1lbnQgZm9yIGVkaXRpbmcuCiAgICAgICAgIGlmICh1cHN0cmVhbVN0 YXJ0Lm5vZGUoKSA9PSBlZGl0YWJsZVJvb3RGb3JQb3NpdGlvbih1cHN0cmVhbVN0YXJ0KSkgewot ICAgICAgICAgICAgLy8gSWYgdGhlIGJsb2NrIGlzIHRoZSByb290IGVkaXRhYmxlIGVsZW1lbnQg YW5kIGl0IGNvbnRhaW5zIG5vIHJlbmRlcmVkIGNvbnRlbnQsIGNyZWF0ZSBhIG5ldwotICAgICAg ICAgICAgLy8gYmxvY2sgYnV0IGRvbid0IHRyeSBhbmQgbW92ZSBjb250ZW50IGludG8gaXQsIHNp bmNlIHRoZXJlJ3Mgbm90aGluZyB0byBtb3ZlLgotICAgICAgICAgICAgaWYgKCFoYXNBUmVuZGVy ZWREZXNjZW5kYW50KHVwc3RyZWFtU3RhcnQubm9kZSgpKSkKKyAgICAgICAgICAgIC8vIElmIHRo ZSBibG9jayBpcyB0aGUgcm9vdCBlZGl0YWJsZSBlbGVtZW50IGFuZCBpdCBjb250YWlucyBubyB2 aXNpYmxlIGNvbnRlbnQsIGNyZWF0ZSBhIG5ldworICAgICAgICAgICAgLy8gYmxvY2sgYnV0IGRv bid0IHRyeSBhbmQgbW92ZSBjb250ZW50IGludG8gaXQsIHNpbmNlIHRoZXJlJ3Mgbm90aGluZyBm b3IgbW92ZVBhcmFncmFwaHMgdG8gbW92ZS4KKyAgICAgICAgICAgIGlmICghUG9zaXRpb246Omhh c1JlbmRlcmVkTm9uQW5vbnltb3VzRGVzY2VuZGFudHNXaXRoSGVpZ2h0KHVwc3RyZWFtU3RhcnQu bm9kZSgpLT5yZW5kZXJlcigpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gaW5zZXJ0TmV3RGVm YXVsdFBhcmFncmFwaEVsZW1lbnRBdCh1cHN0cmVhbVN0YXJ0KTsKICAgICAgICAgfSBlbHNlIGlm IChpc0Jsb2NrKHVwc3RyZWFtRW5kLm5vZGUoKSkpIHsKICAgICAgICAgICAgIGlmICghdXBzdHJl YW1FbmQubm9kZSgpLT5pc0Rlc2NlbmRhbnRPZih1cHN0cmVhbVN0YXJ0Lm5vZGUoKSkpIHsKSW5k ZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvMjUzMjAtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvMjUzMjAtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC8y NTMyMC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0 cyBmb3IgYSBjcmFzaCB3aGVuIGRvaW5nIGEgYmxvY2sgc3R5bGUgY2hhbmdlIGluc2lkZSBhbiBl ZGl0YWJsZSByb290IHRoYXQgY29udGFpbnMgcmVuZGVyZWQsIGJ1dCBpbnZpc2libGUgY29udGVu dC4gVGhpcyB0ZXN0IHNob3VsZG4ndCBjcmFzaCBhbmQgdGhlIHRleHQtYWxpZ246Y2VudGVyIHNo b3VsZCBnbyBvbnRvIGEgbmV3IHBhcmFncmFwaCBlbGVtZW50LCBub3QgdGhlIGJvZHkuCisKKzxk aXYgc3R5bGU9InRleHQtYWxpZ246IGNlbnRlcjsiPjxicj48L2Rpdj48ZGl2IHN0eWxlPSJwYWRk aW5nLWxlZnQ6IDVweDsiPjwvZGl2PgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29t bWFuZC8yNTMyMC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0Nv bW1hbmQvMjUzMjAuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhl Y0NvbW1hbmQvMjUzMjAuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBAQAorPGhlYWQ+ Cis8c2NyaXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBpZiAobGF5b3V0VGVzdENvbnRy b2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBk b2N1bWVudC5ib2R5LmZvY3VzKCk7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkp1c3RpZnlD ZW50ZXIiKTsKKyAgICBkb2N1bWVudC5ib2R5LmlubmVyVGV4dCA9ICJUaGlzIHRlc3RzIGZvciBh IGNyYXNoIHdoZW4gZG9pbmcgYSBibG9jayBzdHlsZSBjaGFuZ2UgaW5zaWRlIGFuIGVkaXRhYmxl IHJvb3QgdGhhdCBjb250YWlucyByZW5kZXJlZCwgYnV0IGludmlzaWJsZSBjb250ZW50LiBUaGlz IHRlc3Qgc2hvdWxkbid0IGNyYXNoIGFuZCB0aGUgdGV4dC1hbGlnbjpjZW50ZXIgc2hvdWxkIGdv IG9udG8gYSBuZXcgcGFyYWdyYXBoIGVsZW1lbnQsIG5vdCB0aGUgYm9keS4iICsgIlxuXG4iICsg ZG9jdW1lbnQuYm9keS5pbm5lckhUTUw7Cit9Cis8L3NjcmlwdD4gICAgCis8L2hlYWQ+Cis8Ym9k eSBvbkxvYWQ9InJ1blRlc3QoKTsiIGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSI+PGRpdiBzdHlsZT0i cGFkZGluZy1sZWZ0OiA1cHg7Ij48L2Rpdj48L2JvZHk+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2Yg ZmlsZQo=