25318 2009-04-21 16:26:36 -0700 Add a method to Chromium's port to reset the plugin cache 2009-04-29 13:21:58 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jam jam dglazkov oldest_to_newest 118331 0 jam 2009-04-21 16:26:36 -0700 To allow plugins to be installed while Chromium is running, I need to add a method to PluginDataChromium.cpp to flush the plugin list cache. 118334 1 29668 jam 2009-04-21 16:31:35 -0700 Created attachment 29668 Patch 118356 2 29668 dglazkov 2009-04-21 21:17:22 -0700 Comment on attachment 29668 Patch > +void resetChromiumPluginCache() { Brace goes on new line. But this is tiny -- I'll fix up and land. 118357 3 dglazkov 2009-04-21 21:20:29 -0700 Landed as http://trac.webkit.org/changeset/42739. 118360 4 29668 fishd 2009-04-21 23:25:28 -0700 Comment on attachment 29668 Patch > Index: WebCore/plugins/chromium/PluginDataChromium.cpp > +void resetChromiumPluginCache() { > + pluginCache.reset(false); > +} > + Shouldn't there be a header file change as well? 118361 5 fishd 2009-04-21 23:27:17 -0700 > Shouldn't there be a header file change as well? Actually, I think this should be a static method on PluginData. It seems like you want a method that is like PluginData::refresh but works slightly differently? 118362 6 jam 2009-04-21 23:30:16 -0700 I was forward declaring it and using it from render_thread.cc. The reason I didn't add it to a header (i.e. PluginData.h) is that I thought it seemed specific to Chromium's implementation, since the cache is only in PluginDataChromium.cc. Not sure if other platforms do similar caching. For background, here's the Chromium change: http://codereview.chromium.org/88020 118363 7 fishd 2009-04-21 23:58:23 -0700 > I was forward declaring it and using it from render_thread.cc. I see... that won't work in the future when we optionally build WebKit as a DLL. We will need a WebKit API corresponding to this, and I think it would be a lot cleaner to have something on PluginData as a static method corresponding to that. (I think it leads to maintenance problems if we have undeclared global functions being used by various parts of the product, so we should anyways avoid it.) It seems like all implementations of PluginData should be conceptually similar, such that a function like this would be appropriate. Otherwise, maybe we have built our cache at the wrong place? At the very least, we can put a #if PLATFORM(CHROMIUM) specific method on PluginData. 118392 8 jam 2009-04-22 11:22:41 -0700 I see your point about adding it to the WebKit API, I can do that. I don't think this should be added to PluginData, as it's not a general method that would be used by other ports. It's only in Chromium's case that we double cache the list (once in PluginData, and another in the browser process), but that's a result of our multi-process architecture and I don't think other ports need it. I checked them and didn't find any of them doing caching in their PluginData implementation. Also, I think the current location is a good place to cache, since moving our plugin list from outside WebKit code to WebKit code entails a lot of string conversion (over 500 on my machine). 118393 9 jam 2009-04-22 11:32:55 -0700 thinking about it more, I agree that it could be in PluginData but with an ifdef CHROMIUM. I'll add a patch to this bug. 118400 10 29686 jam 2009-04-22 11:50:47 -0700 Created attachment 29686 move resetChromiumPluginCache() to PluginData 118409 11 29686 sam 2009-04-22 12:52:48 -0700 Comment on attachment 29686 move resetChromiumPluginCache() to PluginData Why not just call the function resetPluginCache. If other platforms use a pluginCache in the future and need to reset it, wouldn't they use the same function? 118410 12 29687 jam 2009-04-22 13:04:48 -0700 Created attachment 29687 renamed to resetPluginCache 118413 13 29687 sam 2009-04-22 13:36:52 -0700 Comment on attachment 29687 renamed to resetPluginCache > + * plugins/PluginData.h: > + * plugins/chromium/PluginDataChromium.cpp: > + (WebCore::PluginData::resetChromiumPluginCache): This is no longer the name of the function. Otherwise, it seems fine. r=me 118427 14 29690 jam 2009-04-22 15:39:35 -0700 Created attachment 29690 updated comment 118428 15 29691 jam 2009-04-22 15:40:48 -0700 Created attachment 29691 removed comment about no test 118451 16 jam 2009-04-22 17:32:33 -0700 While testing this out, I found a problem on youtube. Looks like it's caused by the fact that the Page* objects remains the same during refresh. I think I have a better fix than this. I'll test and upload soon. 118528 17 29713 jam 2009-04-23 12:59:08 -0700 Created attachment 29713 revert previous change OK after some more investigation, I realized that the cache purge needs to happen to all the Page* instances. Page::refreshPlugins does that, although it also causes a call to the browser process (in Chromium's case) from each renderer process. I've come up with a change that's all in Chromium's source code, so this change isn't needed anymore. 119161 18 jam 2009-04-28 14:35:13 -0700 ping? can anyone submit my patch to revert this? It's not needed anymore. Thanks. 119169 19 jam 2009-04-28 14:49:46 -0700 Thanks Dimitri, when you get a chance, can you commit this for me? 119327 20 eric 2009-04-29 13:21:58 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/plugins/chromium/PluginDataChromium.cpp Committed r43004 29668 2009-04-21 16:31:35 -0700 2009-04-23 12:59:08 -0700 Patch plugins.txt text/plain 1121 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjczMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDQtMjEgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGEgbWV0aG9kIHRvIHB1cmdlIHRoZSBDaHJvbWl1bSBwbHVnaW4gbGlzdCBjYWNoZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MzE4CisKKyAg ICAgICAgKiBwbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1bS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpyZXNldENocm9taXVtUGx1Z2luQ2FjaGUpOgorCiAyMDA5LTA0LTE3ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgcGVuZGlu ZyB1bmxvYWQgYW5kIGJlZm9yZXVubG9hZCBjb3VudHMgdG8gc3RvcmUgdGhlIGxpc3RlbmVycwpJ bmRleDogV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1bS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1bS5j cHAJKHJldmlzaW9uIDQyNzMxKQorKysgV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRh dGFDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1LDYgKzg1LDEwIEBAIHByaXZhdGU6 CiAKIHN0YXRpYyBQbHVnaW5DYWNoZSBwbHVnaW5DYWNoZTsKIAordm9pZCByZXNldENocm9taXVt UGx1Z2luQ2FjaGUoKSB7CisgICAgcGx1Z2luQ2FjaGUucmVzZXQoZmFsc2UpOworfQorCiB2b2lk IFBsdWdpbkRhdGE6OmluaXRQbHVnaW5zKCkKIHsKICAgICBjb25zdCBWZWN0b3I8UGx1Z2luSW5m byo+JiBwbHVnaW5zID0gcGx1Z2luQ2FjaGUucGx1Z2lucygpOwo= 29686 2009-04-22 11:50:47 -0700 2009-04-22 13:04:48 -0700 move resetChromiumPluginCache() to PluginData plugins2.txt text/plain 1890 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjc1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMjIgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHJlc2V0Q2hyb21pdW1QbHVnaW5DYWNoZSgpIHRvIFBsdWdpbkRhdGEuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTMxOAorCisgICAgICAgICog cGx1Z2lucy9QbHVnaW5EYXRhLmg6CisgICAgICAgICogcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5E YXRhQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luRGF0YTo6cmVzZXRDaHJv bWl1bVBsdWdpbkNhY2hlKToKKwogMjAwOS0wNC0yMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRGF2aWQgSHlhdHQuCkluZGV4OiBX ZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lu cy9QbHVnaW5EYXRhLmgJKHJldmlzaW9uIDQyNzUxKQorKysgV2ViQ29yZS9wbHVnaW5zL1BsdWdp bkRhdGEuaAkod29ya2luZyBjb3B5KQpAQCAtNjAsNiArNjAsMTAgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiAgICAgICAgIHN0YXRpYyB2b2lkIHJlZnJlc2goKTsKIAorI2lmIFBMQVRGT1JNKENI Uk9NSVVNKQorICAgICAgICBzdGF0aWMgdm9pZCByZXNldENocm9taXVtUGx1Z2luQ2FjaGUoKTsK KyNlbmRpZgorCiAgICAgcHJpdmF0ZToKICAgICAgICAgUGx1Z2luRGF0YShjb25zdCBQYWdlKik7 CiAgICAgICAgIHZvaWQgaW5pdFBsdWdpbnMoKTsKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9jaHJv bWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lu cy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA0Mjc1MSkKKysrIFdl YkNvcmUvcGx1Z2lucy9jaHJvbWl1bS9QbHVnaW5EYXRhQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC04NSwxMSArODUsNiBAQCBwcml2YXRlOgogCiBzdGF0aWMgUGx1Z2luQ2FjaGUgcGx1 Z2luQ2FjaGU7CiAKLXZvaWQgcmVzZXRDaHJvbWl1bVBsdWdpbkNhY2hlKCkKLXsKLSAgICBwbHVn aW5DYWNoZS5yZXNldChmYWxzZSk7Ci19Ci0KIHZvaWQgUGx1Z2luRGF0YTo6aW5pdFBsdWdpbnMo KQogewogICAgIGNvbnN0IFZlY3RvcjxQbHVnaW5JbmZvKj4mIHBsdWdpbnMgPSBwbHVnaW5DYWNo ZS5wbHVnaW5zKCk7CkBAIC0xMDMsNiArOTgsMTEgQEAgdm9pZCBQbHVnaW5EYXRhOjpyZWZyZXNo KCkKICAgICBwbHVnaW5DYWNoZS5wbHVnaW5zKCk7ICAvLyBGb3JjZSB0aGUgcGx1Z2lucyB0byBi ZSByZWxvYWRlZCBub3cuCiB9CiAKK3ZvaWQgUGx1Z2luRGF0YTo6cmVzZXRDaHJvbWl1bVBsdWdp bkNhY2hlKCkKK3sKKyAgICBwbHVnaW5DYWNoZS5yZXNldChmYWxzZSk7Cit9CisKIFN0cmluZyBn ZXRQbHVnaW5NaW1lVHlwZUZyb21FeHRlbnNpb24oY29uc3QgU3RyaW5nJiBleHRlbnNpb24pCiB7 CiAgICAgY29uc3QgVmVjdG9yPFBsdWdpbkluZm8qPiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBs dWdpbnMoKTsK 29687 2009-04-22 13:04:48 -0700 2009-04-22 15:39:35 -0700 renamed to resetPluginCache plugins2.txt text/plain 1866 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjc1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMjIgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHJlc2V0UGx1Z2luQ2FjaGUoKSB0byBQbHVnaW5EYXRhLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUzMTgKKworICAgICAgICAqIHBsdWdpbnMv UGx1Z2luRGF0YS5oOgorICAgICAgICAqIHBsdWdpbnMvY2hyb21pdW0vUGx1Z2luRGF0YUNocm9t aXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpbkRhdGE6OnJlc2V0Q2hyb21pdW1QbHVn aW5DYWNoZSk6CisKIDIwMDktMDQtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERhdmlkIEh5YXR0LgpJbmRleDogV2ViQ29yZS9w bHVnaW5zL1BsdWdpbkRhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2lu RGF0YS5oCShyZXZpc2lvbiA0Mjc1MSkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhLmgJ KHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog ICAgICAgICBzdGF0aWMgdm9pZCByZWZyZXNoKCk7CiAKKyNpZiBQTEFURk9STShDSFJPTUlVTSkK KyAgICAgICAgc3RhdGljIHZvaWQgcmVzZXRQbHVnaW5DYWNoZSgpOworI2VuZGlmCisKICAgICBw cml2YXRlOgogICAgICAgICBQbHVnaW5EYXRhKGNvbnN0IFBhZ2UqKTsKICAgICAgICAgdm9pZCBp bml0UGx1Z2lucygpOwpJbmRleDogV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFD aHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdp bkRhdGFDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDQyNzUxKQorKysgV2ViQ29yZS9wbHVnaW5zL2No cm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1LDExICs4 NSw2IEBAIHByaXZhdGU6CiAKIHN0YXRpYyBQbHVnaW5DYWNoZSBwbHVnaW5DYWNoZTsKIAotdm9p ZCByZXNldENocm9taXVtUGx1Z2luQ2FjaGUoKQotewotICAgIHBsdWdpbkNhY2hlLnJlc2V0KGZh bHNlKTsKLX0KLQogdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiB7CiAgICAgY29uc3Qg VmVjdG9yPFBsdWdpbkluZm8qPiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBsdWdpbnMoKTsKQEAg LTEwMyw2ICs5OCwxMSBAQCB2b2lkIFBsdWdpbkRhdGE6OnJlZnJlc2goKQogICAgIHBsdWdpbkNh Y2hlLnBsdWdpbnMoKTsgIC8vIEZvcmNlIHRoZSBwbHVnaW5zIHRvIGJlIHJlbG9hZGVkIG5vdy4K IH0KIAordm9pZCBQbHVnaW5EYXRhOjpyZXNldFBsdWdpbkNhY2hlKCkKK3sKKyAgICBwbHVnaW5D YWNoZS5yZXNldChmYWxzZSk7Cit9CisKIFN0cmluZyBnZXRQbHVnaW5NaW1lVHlwZUZyb21FeHRl bnNpb24oY29uc3QgU3RyaW5nJiBleHRlbnNpb24pCiB7CiAgICAgY29uc3QgVmVjdG9yPFBsdWdp bkluZm8qPiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBsdWdpbnMoKTsK 29690 2009-04-22 15:39:35 -0700 2009-04-22 15:40:48 -0700 updated comment plugins3.txt text/plain 1803 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjc1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDQtMjIgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwbHVn aW5zL1BsdWdpbkRhdGEuaDoKKyAgICAgICAgKiBwbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFD aHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5EYXRhOjpyZXNldFBsdWdpbkNh Y2hlKToKKwogMjAwOS0wNC0yMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbHVnaW5z L1BsdWdpbkRhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5o CShyZXZpc2lvbiA0Mjc1MSkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhLmgJKHdvcmtp bmcgY29weSkKQEAgLTYwLDYgKzYwLDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAg ICBzdGF0aWMgdm9pZCByZWZyZXNoKCk7CiAKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICAg ICAgc3RhdGljIHZvaWQgcmVzZXRQbHVnaW5DYWNoZSgpOworI2VuZGlmCisKICAgICBwcml2YXRl OgogICAgICAgICBQbHVnaW5EYXRhKGNvbnN0IFBhZ2UqKTsKICAgICAgICAgdm9pZCBpbml0UGx1 Z2lucygpOwpJbmRleDogV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1 bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFD aHJvbWl1bS5jcHAJKHJldmlzaW9uIDQyNzUxKQorKysgV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVt L1BsdWdpbkRhdGFDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1LDExICs4NSw2IEBA IHByaXZhdGU6CiAKIHN0YXRpYyBQbHVnaW5DYWNoZSBwbHVnaW5DYWNoZTsKIAotdm9pZCByZXNl dENocm9taXVtUGx1Z2luQ2FjaGUoKQotewotICAgIHBsdWdpbkNhY2hlLnJlc2V0KGZhbHNlKTsK LX0KLQogdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiB7CiAgICAgY29uc3QgVmVjdG9y PFBsdWdpbkluZm8qPiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBsdWdpbnMoKTsKQEAgLTEwMyw2 ICs5OCwxMSBAQCB2b2lkIFBsdWdpbkRhdGE6OnJlZnJlc2goKQogICAgIHBsdWdpbkNhY2hlLnBs dWdpbnMoKTsgIC8vIEZvcmNlIHRoZSBwbHVnaW5zIHRvIGJlIHJlbG9hZGVkIG5vdy4KIH0KIAor dm9pZCBQbHVnaW5EYXRhOjpyZXNldFBsdWdpbkNhY2hlKCkKK3sKKyAgICBwbHVnaW5DYWNoZS5y ZXNldChmYWxzZSk7Cit9CisKIFN0cmluZyBnZXRQbHVnaW5NaW1lVHlwZUZyb21FeHRlbnNpb24o Y29uc3QgU3RyaW5nJiBleHRlbnNpb24pCiB7CiAgICAgY29uc3QgVmVjdG9yPFBsdWdpbkluZm8q PiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBsdWdpbnMoKTsK 29691 2009-04-22 15:40:48 -0700 2009-04-23 12:59:08 -0700 removed comment about no test plugins3.txt text/plain 1752 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjc1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDQtMjIgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwbHVnaW5zL1BsdWdpbkRhdGEuaDoKKyAgICAgICAgKiBwbHVnaW5zL2Nocm9taXVtL1BsdWdp bkRhdGFDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5EYXRhOjpyZXNldFBs dWdpbkNhY2hlKToKKwogMjAwOS0wNC0yMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9w bHVnaW5zL1BsdWdpbkRhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2lu RGF0YS5oCShyZXZpc2lvbiA0Mjc1MSkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhLmgJ KHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog ICAgICAgICBzdGF0aWMgdm9pZCByZWZyZXNoKCk7CiAKKyNpZiBQTEFURk9STShDSFJPTUlVTSkK KyAgICAgICAgc3RhdGljIHZvaWQgcmVzZXRQbHVnaW5DYWNoZSgpOworI2VuZGlmCisKICAgICBw cml2YXRlOgogICAgICAgICBQbHVnaW5EYXRhKGNvbnN0IFBhZ2UqKTsKICAgICAgICAgdm9pZCBp bml0UGx1Z2lucygpOwpJbmRleDogV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFD aHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL2Nocm9taXVtL1BsdWdp bkRhdGFDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDQyNzUxKQorKysgV2ViQ29yZS9wbHVnaW5zL2No cm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1LDExICs4 NSw2IEBAIHByaXZhdGU6CiAKIHN0YXRpYyBQbHVnaW5DYWNoZSBwbHVnaW5DYWNoZTsKIAotdm9p ZCByZXNldENocm9taXVtUGx1Z2luQ2FjaGUoKQotewotICAgIHBsdWdpbkNhY2hlLnJlc2V0KGZh bHNlKTsKLX0KLQogdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiB7CiAgICAgY29uc3Qg VmVjdG9yPFBsdWdpbkluZm8qPiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBsdWdpbnMoKTsKQEAg LTEwMyw2ICs5OCwxMSBAQCB2b2lkIFBsdWdpbkRhdGE6OnJlZnJlc2goKQogICAgIHBsdWdpbkNh Y2hlLnBsdWdpbnMoKTsgIC8vIEZvcmNlIHRoZSBwbHVnaW5zIHRvIGJlIHJlbG9hZGVkIG5vdy4K IH0KIAordm9pZCBQbHVnaW5EYXRhOjpyZXNldFBsdWdpbkNhY2hlKCkKK3sKKyAgICBwbHVnaW5D YWNoZS5yZXNldChmYWxzZSk7Cit9CisKIFN0cmluZyBnZXRQbHVnaW5NaW1lVHlwZUZyb21FeHRl bnNpb24oY29uc3QgU3RyaW5nJiBleHRlbnNpb24pCiB7CiAgICAgY29uc3QgVmVjdG9yPFBsdWdp bkluZm8qPiYgcGx1Z2lucyA9IHBsdWdpbkNhY2hlLnBsdWdpbnMoKTsK 29713 2009-04-23 12:59:08 -0700 2009-04-28 14:43:50 -0700 revert previous change plugins4.txt text/plain 1046 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Mjc4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDQtMjMgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmV2ZXJ0ZWQgbXkgcHJldmlvdXMgY2hhbmdlIHRvIGFkZCByZXNldENocm9taXVtUGx1Z2luQ2Fj aGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1 MzE4CisKKyAgICAgICAgKiBwbHVnaW5zL2Nocm9taXVtL1BsdWdpbkRhdGFDaHJvbWl1bS5jcHA6 CisKIDIwMDktMDQtMjMgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL3BsdWdp bnMvY2hyb21pdW0vUGx1Z2luRGF0YUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsdWdpbnMvY2hyb21pdW0vUGx1Z2luRGF0YUNocm9taXVtLmNwcAkocmV2aXNpb24gNDI3NTEp CisrKyBXZWJDb3JlL3BsdWdpbnMvY2hyb21pdW0vUGx1Z2luRGF0YUNocm9taXVtLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODUsMTEgKzg1LDYgQEAgcHJpdmF0ZToKIAogc3RhdGljIFBsdWdpbkNh Y2hlIHBsdWdpbkNhY2hlOwogCi12b2lkIHJlc2V0Q2hyb21pdW1QbHVnaW5DYWNoZSgpCi17Ci0g ICAgcGx1Z2luQ2FjaGUucmVzZXQoZmFsc2UpOwotfQotCiB2b2lkIFBsdWdpbkRhdGE6OmluaXRQ bHVnaW5zKCkKIHsKICAgICBjb25zdCBWZWN0b3I8UGx1Z2luSW5mbyo+JiBwbHVnaW5zID0gcGx1 Z2luQ2FjaGUucGx1Z2lucygpOwo=