25313 2009-04-21 15:32:13 -0700 Missing scrollbars in GMail 2009-04-23 15:34:29 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov hyatt oldest_to_newest 118318 0 dglazkov 2009-04-21 15:32:13 -0700 This bug manifested itself most drastically in Chromium ToT, where GMail would never gain scrollbars. The condition occurs because the html element in the GMail canvas frame is given "overflow-y: scroll" dynamically (and repeatedly). Because of the "never one scrollbar at a time" check, even though it's already set to ScrollbarAlwaysOn, the vertical scrollbar may be occasionally disabled. I am still trying to figure out how to write a layout test for this :). 118319 1 29663 dglazkov 2009-04-21 15:37:05 -0700 Created attachment 29663 GMail scroll bars missing, v1 WebCore/ChangeLog | 11 +++++++++++ WebCore/platform/ScrollView.cpp | 22 +++++++++++----------- 2 files changed, 22 insertions(+), 11 deletions(-) 118321 2 29663 dglazkov 2009-04-21 15:39:54 -0700 Comment on attachment 29663 GMail scroll bars missing, v1 Oops. Some extra changes snuck in. 118322 3 29665 dglazkov 2009-04-21 15:40:44 -0700 Created attachment 29665 GMail scroll bars missing, v1.1 WebCore/ChangeLog | 11 +++++++++++ WebCore/platform/ScrollView.cpp | 20 ++++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-) 118328 4 29667 dglazkov 2009-04-21 16:12:13 -0700 Created attachment 29667 GMail scroll bars missing, v2. WebCore/ChangeLog | 11 +++++++++++ WebCore/platform/ScrollView.cpp | 17 +++++++++-------- WebKit/mac/ChangeLog | 11 +++++++++++ WebKit/mac/WebView/WebDynamicScrollBarsView.m | 19 ++++++++++--------- 4 files changed, 41 insertions(+), 17 deletions(-) 118332 5 darin 2009-04-21 16:27:50 -0700 Is there a way to make a regression test for this? I don't want it to break again. 118335 6 29669 dglazkov 2009-04-21 16:34:40 -0700 Created attachment 29669 Deficient layout test attempt I haven't yet been able to come up with a good layout test. This is how far I've gotten, but I can only trigger failure on Safari/Win and Chromium. I'll think on this some more. Obviously, appreciate any ideas. 118432 7 29667 dglazkov 2009-04-22 15:56:30 -0700 Comment on attachment 29667 GMail scroll bars missing, v2. Better patch coming up. 118439 8 29694 dglazkov 2009-04-22 16:09:49 -0700 Created attachment 29694 GMail scroll bars missing, v3. LayoutTests/ChangeLog | 9 +++++ .../fast/overflow/overflow-y-scroll-expected.txt | 3 ++ LayoutTests/fast/overflow/overflow-y-scroll.html | 39 ++++++++++++++++++++ WebCore/ChangeLog | 13 +++++++ WebCore/platform/ScrollView.cpp | 17 +++++---- WebKit/mac/ChangeLog | 11 ++++++ WebKit/mac/WebView/WebDynamicScrollBarsView.m | 19 +++++----- 7 files changed, 94 insertions(+), 17 deletions(-) 118447 9 29694 darin 2009-04-22 16:57:08 -0700 Comment on attachment 29694 GMail scroll bars missing, v3. r=me Hyatt should probably look at this too. 118512 10 dglazkov 2009-04-23 10:02:40 -0700 Hyatt says fine. 118549 11 dglazkov 2009-04-23 15:34:29 -0700 Landed as http://trac.webkit.org/changeset/42791. 29663 2009-04-21 15:37:05 -0700 2009-04-21 15:40:02 -0700 GMail scroll bars missing, v1 GMail-scroll-bars-missing-v1.patch text/plain 2937 dglazkov YWMxMjA2ZWQzZmUxOTZiNzc2NGE0MmI1ODUyZGIxYzNiNDJhZDFmNQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2OWM0ZGMzLi45MjVlMmM3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA0LTIxICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MzEzCisgICAg ICAgIE1pc3Npbmcgc2Nyb2xsIGJhcnMgaW4gR01haWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9T Y3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9s bGJhcnMpOiBBZGRlZCBjaGVjayBmb3IgdGhlIFNjcm9sbGJhckFsd2F5c09uCisgICAgICAgIHNj cm9sbCBtb2RlLgorCiAyMDA5LTA0LTE3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAogICAgICAgICBDaGFuZ2UgcGVuZGluZyB1bmxvYWQgYW5kIGJlZm9yZXVubG9hZCBj b3VudHMgdG8gc3RvcmUgdGhlIGxpc3RlbmVycwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5kZXgg NDk0ODQ4Mi4uMjIxZDBkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0zMzAsNyArMzMw LDcgQEAgdm9pZCBTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKGNvbnN0IEludFNpemUmIGRl c2lyZWRPZmZzZXQpCiAgICAgU2Nyb2xsYmFyTW9kZSBoU2Nyb2xsID0gbV9ob3Jpem9udGFsU2Ny b2xsYmFyTW9kZTsKICAgICBTY3JvbGxiYXJNb2RlIHZTY3JvbGwgPSBtX3ZlcnRpY2FsU2Nyb2xs YmFyTW9kZTsKIAotICAgIGlmIChtX3Njcm9sbGJhcnNTdXBwcmVzc2VkIHx8IChoU2Nyb2xsICE9 IFNjcm9sbGJhckF1dG8gJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBdXRvKSkgeworICAgIGlmICgh bV9zY3JvbGxiYXJzU3VwcHJlc3NlZCAmJiAoaFNjcm9sbCA9PSBTY3JvbGxiYXJBdXRvIHx8IHZT Y3JvbGwgPT0gU2Nyb2xsYmFyQXV0bykpIHsKICAgICAgICAgaWYgKGhTY3JvbGwgIT0gU2Nyb2xs YmFyQXV0bykKICAgICAgICAgICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgPSAoaFNjcm9s bCA9PSBTY3JvbGxiYXJBbHdheXNPbik7CiAgICAgICAgIGlmICh2U2Nyb2xsICE9IFNjcm9sbGJh ckF1dG8pCkBAIC0zNTUsMTkgKzM1NSwxOSBAQCB2b2lkIFNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9s bGJhcnMoY29uc3QgSW50U2l6ZSYgZGVzaXJlZE9mZnNldCkKICAgICAgICAgICAgIG5ld0hhc0hv cml6b250YWxTY3JvbGxiYXIgPSBkb2NTaXplLndpZHRoKCkgPiB2aXNpYmxlV2lkdGgoKTsKICAg ICAgICAgaWYgKHZTY3JvbGwgPT0gU2Nyb2xsYmFyQXV0bykKICAgICAgICAgICAgIG5ld0hhc1Zl cnRpY2FsU2Nyb2xsYmFyID0gZG9jU2l6ZS5oZWlnaHQoKSA+IHZpc2libGVIZWlnaHQoKTsKLSAg ICAgICAgCi0gICAgICAgIC8vIElmIHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwgYWx3 YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9vLiAgTmV2ZXIgZXZlcgotICAgICAgICAvLyB0 cnkgdG8gYm90aCBnYWluL2xvc2UgYSBzY3JvbGxiYXIgaW4gdGhlIHNhbWUgcGFzcy4KLSAgICAg ICAgaWYgKCFuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyICYmIGhhc0hvcml6b250YWxTY3JvbGxi YXIpCisKKyAgICAgICAgLy8gVW5sZXNzIGluIFNjcm9sbGJhckFsd2F5c09uIG1vZGUsIGlmIHdl IGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwgYWx3YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBv ZmYgdG9vLgorICAgICAgICAvLyBOZXZlciBldmVyIHRyeSB0byBib3RoIGdhaW4vbG9zZSBhIHNj cm9sbGJhciBpbiB0aGUgc2FtZSBwYXNzLgorICAgICAgICBpZiAodlNjcm9sbCA9PSBTY3JvbGxi YXJBbHdheXNPbikKKyAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gdHJ1ZTsK KyAgICAgICAgZWxzZSBpZiAoIW5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgJiYgaGFzSG9yaXpv bnRhbFNjcm9sbGJhcikKICAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZmFs c2U7Ci0gICAgICAgIGlmICghbmV3SGFzVmVydGljYWxTY3JvbGxiYXIgJiYgaGFzVmVydGljYWxT Y3JvbGxiYXIpCisKKyAgICAgICAgaWYgKGhTY3JvbGwgPT0gU2Nyb2xsYmFyQWx3YXlzT24pCisg ICAgICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyID0gdHJ1ZTsKKyAgICAgICAgZWxz ZSBpZiAoIW5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyICYmIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyKQog ICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IGZhbHNlOwogCi0gICAgICAg IGlmIChoYXNIb3Jpem9udGFsU2Nyb2xsYmFyICE9IG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIp IHsKLSAgICAgICAgICAgIHNldEhhc0hvcml6b250YWxTY3JvbGxiYXIobmV3SGFzSG9yaXpvbnRh bFNjcm9sbGJhcik7Ci0gICAgICAgICAgICBzZW5kQ29udGVudFJlc2l6ZWROb3RpZmljYXRpb24g PSB0cnVlOwotICAgICAgICB9Ci0gCiAgICAgICAgIGlmIChoYXNWZXJ0aWNhbFNjcm9sbGJhciAh PSBuZXdIYXNWZXJ0aWNhbFNjcm9sbGJhcikgewogICAgICAgICAgICAgc2V0SGFzVmVydGljYWxT Y3JvbGxiYXIobmV3SGFzVmVydGljYWxTY3JvbGxiYXIpOwogICAgICAgICAgICAgc2VuZENvbnRl bnRSZXNpemVkTm90aWZpY2F0aW9uID0gdHJ1ZTsK 29665 2009-04-21 15:40:44 -0700 2009-04-21 16:12:29 -0700 GMail scroll bars missing, v1.1 GMail-scroll-bars-missing-v1.1.patch text/plain 2403 dglazkov OTJjMjZmNGUyYTU2YWFjMDA4ODg4YzU2NzkwNzI4Yjk2M2NhNThhYwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2OWM0ZGMzLi45MjVlMmM3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA0LTIxICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MzEzCisgICAg ICAgIE1pc3Npbmcgc2Nyb2xsIGJhcnMgaW4gR01haWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9T Y3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9s bGJhcnMpOiBBZGRlZCBjaGVjayBmb3IgdGhlIFNjcm9sbGJhckFsd2F5c09uCisgICAgICAgIHNj cm9sbCBtb2RlLgorCiAyMDA5LTA0LTE3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAogICAgICAgICBDaGFuZ2UgcGVuZGluZyB1bmxvYWQgYW5kIGJlZm9yZXVubG9hZCBj b3VudHMgdG8gc3RvcmUgdGhlIGxpc3RlbmVycwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5kZXgg NDk0ODQ4Mi4uMTI4MzI5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0zNTUsMTkgKzM1 NSwxOSBAQCB2b2lkIFNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9sbGJhcnMoY29uc3QgSW50U2l6ZSYg ZGVzaXJlZE9mZnNldCkKICAgICAgICAgICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgPSBk b2NTaXplLndpZHRoKCkgPiB2aXNpYmxlV2lkdGgoKTsKICAgICAgICAgaWYgKHZTY3JvbGwgPT0g U2Nyb2xsYmFyQXV0bykKICAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZG9j U2l6ZS5oZWlnaHQoKSA+IHZpc2libGVIZWlnaHQoKTsKLSAgICAgICAgCi0gICAgICAgIC8vIElm IHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwgYWx3YXlzIHR1cm4gdGhlIG90aGVyIG9u ZSBvZmYgdG9vLiAgTmV2ZXIgZXZlcgotICAgICAgICAvLyB0cnkgdG8gYm90aCBnYWluL2xvc2Ug YSBzY3JvbGxiYXIgaW4gdGhlIHNhbWUgcGFzcy4KLSAgICAgICAgaWYgKCFuZXdIYXNIb3Jpem9u dGFsU2Nyb2xsYmFyICYmIGhhc0hvcml6b250YWxTY3JvbGxiYXIpCisKKyAgICAgICAgLy8gVW5s ZXNzIGluIFNjcm9sbGJhckFsd2F5c09uIG1vZGUsIGlmIHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xs YmFyIG9mZiwgYWx3YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9vLgorICAgICAgICAvLyBO ZXZlciBldmVyIHRyeSB0byBib3RoIGdhaW4vbG9zZSBhIHNjcm9sbGJhciBpbiB0aGUgc2FtZSBw YXNzLgorICAgICAgICBpZiAodlNjcm9sbCA9PSBTY3JvbGxiYXJBbHdheXNPbikKKyAgICAgICAg ICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gdHJ1ZTsKKyAgICAgICAgZWxzZSBpZiAoIW5l d0hhc0hvcml6b250YWxTY3JvbGxiYXIgJiYgaGFzSG9yaXpvbnRhbFNjcm9sbGJhcikKICAgICAg ICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZmFsc2U7Ci0gICAgICAgIGlmICghbmV3 SGFzVmVydGljYWxTY3JvbGxiYXIgJiYgaGFzVmVydGljYWxTY3JvbGxiYXIpCisKKyAgICAgICAg aWYgKGhTY3JvbGwgPT0gU2Nyb2xsYmFyQWx3YXlzT24pCisgICAgICAgICAgICBuZXdIYXNIb3Jp em9udGFsU2Nyb2xsYmFyID0gdHJ1ZTsKKyAgICAgICAgZWxzZSBpZiAoIW5ld0hhc1ZlcnRpY2Fs U2Nyb2xsYmFyICYmIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyKQogICAgICAgICAgICAgbmV3SGFzSG9y aXpvbnRhbFNjcm9sbGJhciA9IGZhbHNlOwogCi0gICAgICAgIGlmIChoYXNIb3Jpem9udGFsU2Ny b2xsYmFyICE9IG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIpIHsKLSAgICAgICAgICAgIHNldEhh c0hvcml6b250YWxTY3JvbGxiYXIobmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhcik7Ci0gICAgICAg ICAgICBzZW5kQ29udGVudFJlc2l6ZWROb3RpZmljYXRpb24gPSB0cnVlOwotICAgICAgICB9Ci0g CiAgICAgICAgIGlmIChoYXNWZXJ0aWNhbFNjcm9sbGJhciAhPSBuZXdIYXNWZXJ0aWNhbFNjcm9s bGJhcikgewogICAgICAgICAgICAgc2V0SGFzVmVydGljYWxTY3JvbGxiYXIobmV3SGFzVmVydGlj YWxTY3JvbGxiYXIpOwogICAgICAgICAgICAgc2VuZENvbnRlbnRSZXNpemVkTm90aWZpY2F0aW9u ID0gdHJ1ZTsK 29667 2009-04-21 16:12:13 -0700 2009-04-22 15:56:30 -0700 GMail scroll bars missing, v2. GMail-scroll-bars-missing-v2..patch text/plain 5856 dglazkov MWRkYmI3NGIyMTNiYjI5OTM0NGRlZDEwZDgxOWQ5OWMyN2VkNzlhZApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2OWM0ZGMzLi45MjVlMmM3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA0LTIxICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MzEzCisgICAg ICAgIE1pc3Npbmcgc2Nyb2xsIGJhcnMgaW4gR01haWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9T Y3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9s bGJhcnMpOiBBZGRlZCBjaGVjayBmb3IgdGhlIFNjcm9sbGJhckFsd2F5c09uCisgICAgICAgIHNj cm9sbCBtb2RlLgorCiAyMDA5LTA0LTE3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAogICAgICAgICBDaGFuZ2UgcGVuZGluZyB1bmxvYWQgYW5kIGJlZm9yZXVubG9hZCBj b3VudHMgdG8gc3RvcmUgdGhlIGxpc3RlbmVycwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5kZXgg NDk0ODQ4Mi4uNzUxZDBlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0zMzAsMTEgKzMz MCwxMiBAQCB2b2lkIFNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9sbGJhcnMoY29uc3QgSW50U2l6ZSYg ZGVzaXJlZE9mZnNldCkKICAgICBTY3JvbGxiYXJNb2RlIGhTY3JvbGwgPSBtX2hvcml6b250YWxT Y3JvbGxiYXJNb2RlOwogICAgIFNjcm9sbGJhck1vZGUgdlNjcm9sbCA9IG1fdmVydGljYWxTY3Jv bGxiYXJNb2RlOwogCisgICAgaWYgKGhTY3JvbGwgIT0gU2Nyb2xsYmFyQXV0bykKKyAgICAgICAg bmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IChoU2Nyb2xsID09IFNjcm9sbGJhckFsd2F5c09u KTsKKyAgICBpZiAodlNjcm9sbCAhPSBTY3JvbGxiYXJBdXRvKQorICAgICAgICBuZXdIYXNWZXJ0 aWNhbFNjcm9sbGJhciA9ICh2U2Nyb2xsID09IFNjcm9sbGJhckFsd2F5c09uKTsKKwogICAgIGlm IChtX3Njcm9sbGJhcnNTdXBwcmVzc2VkIHx8IChoU2Nyb2xsICE9IFNjcm9sbGJhckF1dG8gJiYg dlNjcm9sbCAhPSBTY3JvbGxiYXJBdXRvKSkgewotICAgICAgICBpZiAoaFNjcm9sbCAhPSBTY3Jv bGxiYXJBdXRvKQotICAgICAgICAgICAgbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IChoU2Ny b2xsID09IFNjcm9sbGJhckFsd2F5c09uKTsKLSAgICAgICAgaWYgKHZTY3JvbGwgIT0gU2Nyb2xs YmFyQXV0bykKLSAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gKHZTY3JvbGwg PT0gU2Nyb2xsYmFyQWx3YXlzT24pOwogICAgICAgICBpZiAoaGFzSG9yaXpvbnRhbFNjcm9sbGJh ciAhPSBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyKQogICAgICAgICAgICAgc2V0SGFzSG9yaXpv bnRhbFNjcm9sbGJhcihuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyKTsKICAgICAgICAgaWYgKGhh c1ZlcnRpY2FsU2Nyb2xsYmFyICE9IG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyKQpAQCAtMzU1LDE5 ICszNTYsMTkgQEAgdm9pZCBTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKGNvbnN0IEludFNp emUmIGRlc2lyZWRPZmZzZXQpCiAgICAgICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFy ID0gZG9jU2l6ZS53aWR0aCgpID4gdmlzaWJsZVdpZHRoKCk7CiAgICAgICAgIGlmICh2U2Nyb2xs ID09IFNjcm9sbGJhckF1dG8pCiAgICAgICAgICAgICBuZXdIYXNWZXJ0aWNhbFNjcm9sbGJhciA9 IGRvY1NpemUuaGVpZ2h0KCkgPiB2aXNpYmxlSGVpZ2h0KCk7Ci0gICAgICAgIAorCiAgICAgICAg IC8vIElmIHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwgYWx3YXlzIHR1cm4gdGhlIG90 aGVyIG9uZSBvZmYgdG9vLiAgTmV2ZXIgZXZlcgogICAgICAgICAvLyB0cnkgdG8gYm90aCBnYWlu L2xvc2UgYSBzY3JvbGxiYXIgaW4gdGhlIHNhbWUgcGFzcy4KLSAgICAgICAgaWYgKCFuZXdIYXNI b3Jpem9udGFsU2Nyb2xsYmFyICYmIGhhc0hvcml6b250YWxTY3JvbGxiYXIpCisgICAgICAgIGlm ICghbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGJhciAmJiBoYXNIb3Jpem9udGFsU2Nyb2xsYmFyICYm IHZTY3JvbGwgIT0gU2Nyb2xsYmFyQWx3YXlzT24pCiAgICAgICAgICAgICBuZXdIYXNWZXJ0aWNh bFNjcm9sbGJhciA9IGZhbHNlOwotICAgICAgICBpZiAoIW5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFy ICYmIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyKQorICAgICAgICBpZiAoIW5ld0hhc1ZlcnRpY2FsU2Ny b2xsYmFyICYmIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyICYmIGhTY3JvbGwgIT0gU2Nyb2xsYmFyQWx3 YXlzT24pCiAgICAgICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyID0gZmFsc2U7CiAK ICAgICAgICAgaWYgKGhhc0hvcml6b250YWxTY3JvbGxiYXIgIT0gbmV3SGFzSG9yaXpvbnRhbFNj cm9sbGJhcikgewogICAgICAgICAgICAgc2V0SGFzSG9yaXpvbnRhbFNjcm9sbGJhcihuZXdIYXNI b3Jpem9udGFsU2Nyb2xsYmFyKTsKICAgICAgICAgICAgIHNlbmRDb250ZW50UmVzaXplZE5vdGlm aWNhdGlvbiA9IHRydWU7CiAgICAgICAgIH0KLSAKKwogICAgICAgICBpZiAoaGFzVmVydGljYWxT Y3JvbGxiYXIgIT0gbmV3SGFzVmVydGljYWxTY3JvbGxiYXIpIHsKICAgICAgICAgICAgIHNldEhh c1ZlcnRpY2FsU2Nyb2xsYmFyKG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyKTsKICAgICAgICAgICAg IHNlbmRDb250ZW50UmVzaXplZE5vdGlmaWNhdGlvbiA9IHRydWU7CmRpZmYgLS1naXQgYS9XZWJL aXQvbWFjL0NoYW5nZUxvZyBiL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4IGZmMmU5ODAuLmEx OGI3ZDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9tYWMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMjEgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjUzMTMKKyAgICAgICAgTWlzc2luZyBzY3JvbGwgYmFycyBpbiBHTWFpbC4KKworICAgICAgICAq IFdlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm06CisgICAgICAgICgtW1dlYkR5bmFt aWNTY3JvbGxCYXJzVmlldyB1cGRhdGVTY3JvbGxlcnNdKTogQWRkZWQgY2hlY2sgZm9yIHRoZSBT Y3JvbGxiYXJBbHdheXNPbgorICAgICAgICAgICAgc2Nyb2xsIG1vZGUuCisKIDIwMDktMDQtMjEg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlciBhbmQgS2V2aW4gRGVja2VyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L21h Yy9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tIGIvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tCmluZGV4IDFhYWRiMmIuLjBiZDY4NzkgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcubQorKysg Yi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm0KQEAgLTEwMiwx MyArMTAyLDE0IEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBjTWF4VXBkYXRlU2Nyb2xsYmFyc1Bh c3MgPSAyOwogICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIgPSBOTzsKICAgICAgICAg bmV3SGFzVmVydGljYWxTY3JvbGxlciA9IE5POwogICAgIH0gCisKKyAgICBpZiAoaFNjcm9sbCAh PSBTY3JvbGxiYXJBdXRvKQorICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIgPSAoaFNj cm9sbCA9PSBTY3JvbGxiYXJBbHdheXNPbik7CisgICAgaWYgKHZTY3JvbGwgIT0gU2Nyb2xsYmFy QXV0bykKKyAgICAgICAgbmV3SGFzVmVydGljYWxTY3JvbGxlciA9ICh2U2Nyb2xsID09IFNjcm9s bGJhckFsd2F5c09uKTsKICAgICAKICAgICBpZiAoIWRvY3VtZW50VmlldyB8fCBzdXBwcmVzc0xh eW91dCB8fCBzdXBwcmVzc1Njcm9sbGVycyB8fCAoaFNjcm9sbCAhPSBTY3JvbGxiYXJBdXRvICYm IHZTY3JvbGwgIT0gU2Nyb2xsYmFyQXV0bykpIHsKICAgICAgICAgaW5VcGRhdGVTY3JvbGxlcnMg PSBZRVM7Ci0gICAgICAgIGlmIChoU2Nyb2xsICE9IFNjcm9sbGJhckF1dG8pCi0gICAgICAgICAg ICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIgPSAoaFNjcm9sbCA9PSBTY3JvbGxiYXJBbHdheXNP bik7Ci0gICAgICAgIGlmICh2U2Nyb2xsICE9IFNjcm9sbGJhckF1dG8pCi0gICAgICAgICAgICBu ZXdIYXNWZXJ0aWNhbFNjcm9sbGVyID0gKHZTY3JvbGwgPT0gU2Nyb2xsYmFyQWx3YXlzT24pOwog ICAgICAgICBpZiAoaGFzSG9yaXpvbnRhbFNjcm9sbGVyICE9IG5ld0hhc0hvcml6b250YWxTY3Jv bGxlcikKICAgICAgICAgICAgIFtzZWxmIHNldEhhc0hvcml6b250YWxTY3JvbGxlcjpuZXdIYXNI b3Jpem9udGFsU2Nyb2xsZXJdOwogICAgICAgICBpZiAoaGFzVmVydGljYWxTY3JvbGxlciAhPSBu ZXdIYXNWZXJ0aWNhbFNjcm9sbGVyKQpAQCAtMTQyLDEyICsxNDMsMTIgQEAgc3RhdGljIGNvbnN0 IHVuc2lnbmVkIGNNYXhVcGRhdGVTY3JvbGxiYXJzUGFzcyA9IDI7CiAgICAgICAgIG5ld0hhc0hv cml6b250YWxTY3JvbGxlciA9IGRvY3VtZW50U2l6ZS53aWR0aCA+IHZpc2libGVTaXplLndpZHRo OwogICAgIGlmICh2U2Nyb2xsID09IFNjcm9sbGJhckF1dG8pCiAgICAgICAgIG5ld0hhc1ZlcnRp Y2FsU2Nyb2xsZXIgPSBkb2N1bWVudFNpemUuaGVpZ2h0ID4gdmlzaWJsZVNpemUuaGVpZ2h0Owot ICAgIAotICAgIC8vIElmIHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9mZiwgYWx3YXlzIHR1 cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9vLiAgTmV2ZXIgZXZlcgotICAgIC8vIHRyeSB0byBib3Ro IGdhaW4vbG9zZSBhIHNjcm9sbGJhciBpbiB0aGUgc2FtZSBwYXNzLgotICAgIGlmICghbmV3SGFz SG9yaXpvbnRhbFNjcm9sbGVyICYmIGhhc0hvcml6b250YWxTY3JvbGxlcikKKworICAgIC8vIFVu bGVzcyBpbiBTY3JvbGxiYXJzQWx3YXlzT24gbW9kZSwgaWYgd2UgZXZlciB0dXJuIG9uZSBzY3Jv bGxiYXIgb2ZmLCBhbHdheXMgdHVybiB0aGUgb3RoZXIgb25lIG9mZiB0b28uCisgICAgLy8gTmV2 ZXIgZXZlciB0cnkgdG8gYm90aCBnYWluL2xvc2UgYSBzY3JvbGxiYXIgaW4gdGhlIHNhbWUgcGFz cy4KKyAgICBpZiAoIW5ld0hhc0hvcml6b250YWxTY3JvbGxlciAmJiBoYXNIb3Jpem9udGFsU2Ny b2xsZXIgJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBbHdheXNPbikKICAgICAgICAgbmV3SGFzVmVy dGljYWxTY3JvbGxlciA9IE5POwotICAgIGlmICghbmV3SGFzVmVydGljYWxTY3JvbGxlciAmJiBo YXNWZXJ0aWNhbFNjcm9sbGVyKQorICAgIGlmICghbmV3SGFzVmVydGljYWxTY3JvbGxlciAmJiBo YXNWZXJ0aWNhbFNjcm9sbGVyICYmIGhTY3JvbGwgIT0gU2Nyb2xsYmFyQWx3YXlzT24pCiAgICAg ICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxlciA9IE5POwogCiAgICAgaWYgKGhhc0hvcml6b250 YWxTY3JvbGxlciAhPSBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIpIHsK 29669 2009-04-21 16:34:40 -0700 2009-04-22 16:10:03 -0700 Deficient layout test attempt index.html text/html 1354 dglazkov PGh0bWw+DQogICAgPGhlYWQ+DQogICAgICAgIDx0aXRsZT5CdWcgMTAwMDkgUmVkdWN0aW9uPC90 aXRsZT4NCiAgICAgICAgPHN0eWxlPg0KICAgICAgICAgICAgaWZyYW1lDQogICAgICAgICAgICB7 DQogICAgICAgICAgICAgICAgd2lkdGg6IDEwMCU7DQogICAgICAgICAgICAgICAgaGVpZ2h0OiAx MDAlOw0KICAgICAgICAgICAgfQ0KICAgICAgICANCiAgICAgICAgPC9zdHlsZT4NCiAgICAgICAg PHNjcmlwdD4NCiAgICAgICAgICAgIGZ1bmN0aW9uIGluamVjdCgpDQogICAgICAgICAgICB7DQog ICAgICAgICAgICAgICAgdmFyIGNvbnRlbnQgPSAnPGh0bWw+PGhlYWQ+PHN0eWxlPicgKyANCiAg ICAgICAgICAgICAgICAgICAgJ2h0bWwsYm9keSB7IG92ZXJmbG93OiBoaWRkZW47IGhlaWdodDog MTAwJTsgbWFyZ2luOiAwOyB3aWR0aDogMTAwJSB9ICcgKw0KICAgICAgICAgICAgICAgICAgICAn aHRtbC5zY3JvbGwgeyBvdmVyZmxvdy14OiBhdXRvOyBvdmVyZmxvdy15OiBzY3JvbGw7IH0gJyAr DQogICAgICAgICAgICAgICAgICAgICc8L3N0eWxlPjxib2R5PjxkaXYgc3R5bGU9ImhlaWdodDo5 MDBweDsgYm9yZGVyOjFweCBzb2xpZCBncmF5OyI+R3JhYiByaWdodCBib3JkZXIgb2YgdGhlIHBh Z2UgYW5kIHJlc2l6ZSBpbndhcmQuIEEgdmVydGljYWwgc2Nyb2xsYmFyIHNob3VsZCBhcHBlYXIu PC9kaXY+PC9ib2R5PjwvaHRtbD4nOw0KICAgICAgICAgICAgICAgIHZhciBkb2MgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiaW5qZWN0ZWUiKS5jb250ZW50RG9jdW1lbnQ7DQogICAgICAgICAg ICAgICAgZG9jLm9wZW4oKTsNCiAgICAgICAgICAgICAgICBkb2Mud3JpdGUoY29udGVudCk7DQog ICAgICAgICAgICAgICAgZG9jLmNsb3NlKCk7DQogICAgICAgICAgICAgICAgdmFyIGZyYW1lSHRt bCA9IGRvYy5nZXRFbGVtZW50c0J5VGFnTmFtZSgiaHRtbCIpWzBdOw0KICAgICAgICAgICAgICAg IHdpbmRvdy5vbnJlc2l6ZSA9IGZ1bmN0aW9uKCkNCiAgICAgICAgICAgICAgICB7DQogICAgICAg ICAgICAgICAgICAgIGlmIChmcmFtZUh0bWwuY2xhc3NOYW1lICE9ICJzY3JvbGwiKQ0KICAgICAg ICAgICAgICAgICAgICAgICAgZnJhbWVIdG1sLmNsYXNzTmFtZSA9ICJzY3JvbGwiOw0KICAgICAg ICAgICAgICAgIH07DQogICAgICAgICAgICB9DQogICAgICAgIDwvc2NyaXB0Pg0KICAgIDwvaGVh ZD4NCiAgICA8Ym9keSBzdHlsZT0iaGVpZ2h0OjEwMCU7IHdpZHRoOjEwMCU7IG92ZXJmbG93Omhp ZGRlbjsgcGFkZGluZzowOyBtYXJnaW46MDsiPg0KICAgICAgICA8aWZyYW1lIGlkPSJpbmplY3Rl ZSIgb25sb2FkPSJpbmplY3QoKSI+DQogICAgPC9ib2R5Pg0KPC9odG1sPg== 29694 2009-04-22 16:09:49 -0700 2009-04-22 16:57:08 -0700 GMail scroll bars missing, v3. GMail-scroll-bars-missing-v3..patch text/plain 8946 dglazkov N2FkNzZjY2NjM2VlYzQ2NDFlYjBmMWM2MzUwZmU3MjZhMWI5ZjZiMgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJhNTk3YmYu LjEwNjNkODYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wNC0yMiAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjUzMTMKKyAgICAgICAgTWlzc2luZyBzY3JvbGwgYmFycyBpbiBHTWFpbC4KKworICAgICAg ICAqIGZhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3cteS1zY3JvbGwtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L292ZXJmbG93L292ZXJmbG93LXktc2Nyb2xsLmh0bWw6IEFkZGVkLgor CiAyMDA5LTA0LTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBS dWJiZXItc3RhbXBlZCBieSBEYXZpZCBIeWF0dC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3Qvb3ZlcmZsb3cvb3ZlcmZsb3cteS1zY3JvbGwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9vdmVyZmxvdy9vdmVyZmxvdy15LXNjcm9sbC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMWJiZGYzYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3cteS1zY3JvbGwtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMyBAQAorVGVzdHMgU2Nyb2xsVmlldydzIGJlaGF2aW9yIHdoZW4gb25seSBvbmUgb2Yg dGhlIHNjcm9sbGJhcnMgaXMgbWFkZSBTY3JvbGxiYXJBbHdheXNPbiBkeW5hbWljYWxseS4gVGhl IGNvcnJlY3QgYmVoYXZpb3IgaXMgbm90IHRvIHJlbW92ZSB0aGlzIHNjcm9sbGJhciwgd2hpY2gg aXMgd2hhdCB0aGlzIHRlc3QgY2hlY2tzIGZvci4KKworVEVTVCBQQVNTRUQKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3cteS1zY3JvbGwuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3cteS1zY3JvbGwuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi42ZjQzMGEwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9vdmVyZmxvdy9vdmVyZmxvdy15LXNjcm9sbC5odG1sCkBAIC0wLDAgKzEsMzkg QEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8dGl0bGU+QnVnIDI1MzEzIDogTWlzc2lu ZyBzY3JvbGxiYXJzIGluIEdNYWlsPC90aXRsZT4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgd2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgICAgICAgICAgZnVu Y3Rpb24gaW5qZWN0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB2YXIgY29udGVu dCA9ICc8aHRtbD48aGVhZD48c3R5bGU+JyArIAorICAgICAgICAgICAgICAgICAgICAnaHRtbCxi b2R5IHsgbWFyZ2luOiAwOyBvdmVyZmxvdzogaGlkZGVuOyBoZWlnaHQ6IDEwMCU7IHdpZHRoOiAx MDAlIH0gJyArCisgICAgICAgICAgICAgICAgICAgICdodG1sLnNjcm9sbCB7IG92ZXJmbG93LXg6 IGF1dG87IG92ZXJmbG93LXk6IHNjcm9sbDsgfSAnICsKKyAgICAgICAgICAgICAgICAgICAgJzwv c3R5bGU+PGJvZHk+PGRpdiBpZD0ib2ZmZW5kZXIiIHN0eWxlPSJoZWlnaHQ6IDkwMHB4OyI+PC9k aXY+PC9ib2R5PjwvaHRtbD4nOworICAgICAgICAgICAgICAgIHZhciBpbmplY3RlZSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJpbmplY3RlZSIpOworICAgICAgICAgICAgICAgIHZhciBkb2Mg PSBpbmplY3RlZS5jb250ZW50RG9jdW1lbnQ7CisgICAgICAgICAgICAgICAgLy8gaW5qZWN0IGFu IGlmcmFtZQorICAgICAgICAgICAgICAgIGRvYy5vcGVuKCk7CisgICAgICAgICAgICAgICAgZG9j LndyaXRlKGNvbnRlbnQpOworICAgICAgICAgICAgICAgIGRvYy5jbG9zZSgpOworICAgICAgICAg ICAgICAgIGRvYy5nZXRFbGVtZW50c0J5VGFnTmFtZSgiaHRtbCIpWzBdLmNsYXNzTmFtZSA9ICJz Y3JvbGwiOworICAgICAgICAgICAgICAgIC8vIHRpY2tsZSBTY3JvbGxWaWV3Ojp1cGRhdGVTY3Jv bGxiYXJzKCkKKyAgICAgICAgICAgICAgICBkb2MuZ2V0RWxlbWVudEJ5SWQoIm9mZmVuZGVyIiku c2Nyb2xsSW50b1ZpZXcoZmFsc2UpOworICAgICAgICAgICAgICAgIC8vIHRyaWdnZXIgcmVzaXpl CisgICAgICAgICAgICAgICAgaW5qZWN0ZWUuc3R5bGUud2lkdGggPSAiNDAwcHgiOworICAgICAg ICAgICAgICAgIC8vIG1lYXN1cmUgdG8gc2VlIGlmIHRoZXJlIGlzIGEgc2Nyb2xsYmFyLiBQYXNz IGlmIHRoZXJlIGlzLgorICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0 ZXN0IikuaW5uZXJIVE1MID0gZG9jLmJvZHkub2Zmc2V0V2lkdGggPCA0MDAgPyAiVEVTVCBQQVNT RUQiIDogIlRFU1QgRkFJTEVEIjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+Cisg ICAgPC9oZWFkPgorICAgIDxib2R5PgorICAgICAgICA8cD4KKyAgICAgICAgICAgIFRlc3RzIDxr YmQ+U2Nyb2xsVmlldzwva2JkPidzIGJlaGF2aW9yIHdoZW4gb25seSBvbmUgb2YgdGhlIHNjcm9s bGJhcnMgaXMgbWFkZSA8a2JkPlNjcm9sbGJhckFsd2F5c09uPC9rYmQ+IGR5bmFtaWNhbGx5Lgor ICAgICAgICAgICAgVGhlIGNvcnJlY3QgYmVoYXZpb3IgaXMgbm90IHRvIHJlbW92ZSB0aGlzIHNj cm9sbGJhciwgd2hpY2ggaXMgd2hhdCB0aGlzIHRlc3QgY2hlY2tzIGZvci4KKyAgICAgICAgPC9w PgorICAgICAgICA8ZGl2IGlkPSJ0ZXN0Ij4KKyAgICAgICAgICAgICA8aWZyYW1lIHN0eWxlPSJo ZWlnaHQ6MTAwJSIgaWQ9ImluamVjdGVlIiBvbmxvYWQ9ImluamVjdCgpIj4KKyAgICAgICAgPC9k aXY+CisgICAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZWFkYTYzLi40ZjJiZGFhIDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDA5LTA0LTIyICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MzEzCisgICAgICAgIE1pc3Npbmcgc2Ny b2xsIGJhcnMgaW4gR01haWwuCisKKyAgICAgICAgVGVzdDogZmFzdC9vdmVyZmxvdy9vdmVyZmxv dy15LXNjcm9sbC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9sbGJhcnMpOiBBZGRlZCBjaGVj ayBmb3IgdGhlIFNjcm9sbGJhckFsd2F5c09uCisgICAgICAgIHNjcm9sbCBtb2RlLgorCiAyMDA5 LTA0LTIyICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggYSBjcmFzaCBpbiBNYWlsIHdoZW4gZm9yd2FyZGluZyBhIHNwZWNpZmljIEhUTUwgZW1haWwu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCA0OTQ4NDgyLi43NTFkMGUxIDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsVmlldy5jcHAKQEAgLTMzMCwxMSArMzMwLDEyIEBAIHZvaWQgU2Nyb2xsVmlldzo6dXBk YXRlU2Nyb2xsYmFycyhjb25zdCBJbnRTaXplJiBkZXNpcmVkT2Zmc2V0KQogICAgIFNjcm9sbGJh ck1vZGUgaFNjcm9sbCA9IG1faG9yaXpvbnRhbFNjcm9sbGJhck1vZGU7CiAgICAgU2Nyb2xsYmFy TW9kZSB2U2Nyb2xsID0gbV92ZXJ0aWNhbFNjcm9sbGJhck1vZGU7CiAKKyAgICBpZiAoaFNjcm9s bCAhPSBTY3JvbGxiYXJBdXRvKQorICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyID0g KGhTY3JvbGwgPT0gU2Nyb2xsYmFyQWx3YXlzT24pOworICAgIGlmICh2U2Nyb2xsICE9IFNjcm9s bGJhckF1dG8pCisgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gKHZTY3JvbGwgPT0g U2Nyb2xsYmFyQWx3YXlzT24pOworCiAgICAgaWYgKG1fc2Nyb2xsYmFyc1N1cHByZXNzZWQgfHwg KGhTY3JvbGwgIT0gU2Nyb2xsYmFyQXV0byAmJiB2U2Nyb2xsICE9IFNjcm9sbGJhckF1dG8pKSB7 Ci0gICAgICAgIGlmIChoU2Nyb2xsICE9IFNjcm9sbGJhckF1dG8pCi0gICAgICAgICAgICBuZXdI YXNIb3Jpem9udGFsU2Nyb2xsYmFyID0gKGhTY3JvbGwgPT0gU2Nyb2xsYmFyQWx3YXlzT24pOwot ICAgICAgICBpZiAodlNjcm9sbCAhPSBTY3JvbGxiYXJBdXRvKQotICAgICAgICAgICAgbmV3SGFz VmVydGljYWxTY3JvbGxiYXIgPSAodlNjcm9sbCA9PSBTY3JvbGxiYXJBbHdheXNPbik7CiAgICAg ICAgIGlmIChoYXNIb3Jpem9udGFsU2Nyb2xsYmFyICE9IG5ld0hhc0hvcml6b250YWxTY3JvbGxi YXIpCiAgICAgICAgICAgICBzZXRIYXNIb3Jpem9udGFsU2Nyb2xsYmFyKG5ld0hhc0hvcml6b250 YWxTY3JvbGxiYXIpOwogICAgICAgICBpZiAoaGFzVmVydGljYWxTY3JvbGxiYXIgIT0gbmV3SGFz VmVydGljYWxTY3JvbGxiYXIpCkBAIC0zNTUsMTkgKzM1NiwxOSBAQCB2b2lkIFNjcm9sbFZpZXc6 OnVwZGF0ZVNjcm9sbGJhcnMoY29uc3QgSW50U2l6ZSYgZGVzaXJlZE9mZnNldCkKICAgICAgICAg ICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgPSBkb2NTaXplLndpZHRoKCkgPiB2aXNpYmxl V2lkdGgoKTsKICAgICAgICAgaWYgKHZTY3JvbGwgPT0gU2Nyb2xsYmFyQXV0bykKICAgICAgICAg ICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZG9jU2l6ZS5oZWlnaHQoKSA+IHZpc2libGVI ZWlnaHQoKTsKLSAgICAgICAgCisKICAgICAgICAgLy8gSWYgd2UgZXZlciB0dXJuIG9uZSBzY3Jv bGxiYXIgb2ZmLCBhbHdheXMgdHVybiB0aGUgb3RoZXIgb25lIG9mZiB0b28uICBOZXZlciBldmVy CiAgICAgICAgIC8vIHRyeSB0byBib3RoIGdhaW4vbG9zZSBhIHNjcm9sbGJhciBpbiB0aGUgc2Ft ZSBwYXNzLgotICAgICAgICBpZiAoIW5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIgJiYgaGFzSG9y aXpvbnRhbFNjcm9sbGJhcikKKyAgICAgICAgaWYgKCFuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFy ICYmIGhhc0hvcml6b250YWxTY3JvbGxiYXIgJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBbHdheXNP bikKICAgICAgICAgICAgIG5ld0hhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZmFsc2U7Ci0gICAgICAg IGlmICghbmV3SGFzVmVydGljYWxTY3JvbGxiYXIgJiYgaGFzVmVydGljYWxTY3JvbGxiYXIpCisg ICAgICAgIGlmICghbmV3SGFzVmVydGljYWxTY3JvbGxiYXIgJiYgaGFzVmVydGljYWxTY3JvbGxi YXIgJiYgaFNjcm9sbCAhPSBTY3JvbGxiYXJBbHdheXNPbikKICAgICAgICAgICAgIG5ld0hhc0hv cml6b250YWxTY3JvbGxiYXIgPSBmYWxzZTsKIAogICAgICAgICBpZiAoaGFzSG9yaXpvbnRhbFNj cm9sbGJhciAhPSBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsYmFyKSB7CiAgICAgICAgICAgICBzZXRI YXNIb3Jpem9udGFsU2Nyb2xsYmFyKG5ld0hhc0hvcml6b250YWxTY3JvbGxiYXIpOwogICAgICAg ICAgICAgc2VuZENvbnRlbnRSZXNpemVkTm90aWZpY2F0aW9uID0gdHJ1ZTsKICAgICAgICAgfQot IAorCiAgICAgICAgIGlmIChoYXNWZXJ0aWNhbFNjcm9sbGJhciAhPSBuZXdIYXNWZXJ0aWNhbFNj cm9sbGJhcikgewogICAgICAgICAgICAgc2V0SGFzVmVydGljYWxTY3JvbGxiYXIobmV3SGFzVmVy dGljYWxTY3JvbGxiYXIpOwogICAgICAgICAgICAgc2VuZENvbnRlbnRSZXNpemVkTm90aWZpY2F0 aW9uID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21h Yy9DaGFuZ2VMb2cKaW5kZXggNjg0YjBjMC4uM2Y3NjZiOSAxMDA2NDQKLS0tIGEvV2ViS2l0L21h Yy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAwOS0wNC0yMiAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTMxMworICAgICAgICBNaXNzaW5nIHNjcm9s bCBiYXJzIGluIEdNYWlsLgorCisgICAgICAgICogV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFy c1ZpZXcubToKKyAgICAgICAgKC1bV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3IHVwZGF0ZVNjcm9s bGVyc10pOiBBZGRlZCBjaGVjayBmb3IgdGhlIFNjcm9sbGJhckFsd2F5c09uCisgICAgICAgICAg ICBzY3JvbGwgbW9kZS4KKwogMjAwOS0wNC0yMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tIGIvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tCmluZGV4IDFhYWRiMmIuLjBi ZDY4NzkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFy c1ZpZXcubQorKysgYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3 Lm0KQEAgLTEwMiwxMyArMTAyLDE0IEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBjTWF4VXBkYXRl U2Nyb2xsYmFyc1Bhc3MgPSAyOwogICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIgPSBO TzsKICAgICAgICAgbmV3SGFzVmVydGljYWxTY3JvbGxlciA9IE5POwogICAgIH0gCisKKyAgICBp ZiAoaFNjcm9sbCAhPSBTY3JvbGxiYXJBdXRvKQorICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Ny b2xsZXIgPSAoaFNjcm9sbCA9PSBTY3JvbGxiYXJBbHdheXNPbik7CisgICAgaWYgKHZTY3JvbGwg IT0gU2Nyb2xsYmFyQXV0bykKKyAgICAgICAgbmV3SGFzVmVydGljYWxTY3JvbGxlciA9ICh2U2Ny b2xsID09IFNjcm9sbGJhckFsd2F5c09uKTsKICAgICAKICAgICBpZiAoIWRvY3VtZW50VmlldyB8 fCBzdXBwcmVzc0xheW91dCB8fCBzdXBwcmVzc1Njcm9sbGVycyB8fCAoaFNjcm9sbCAhPSBTY3Jv bGxiYXJBdXRvICYmIHZTY3JvbGwgIT0gU2Nyb2xsYmFyQXV0bykpIHsKICAgICAgICAgaW5VcGRh dGVTY3JvbGxlcnMgPSBZRVM7Ci0gICAgICAgIGlmIChoU2Nyb2xsICE9IFNjcm9sbGJhckF1dG8p Ci0gICAgICAgICAgICBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIgPSAoaFNjcm9sbCA9PSBTY3Jv bGxiYXJBbHdheXNPbik7Ci0gICAgICAgIGlmICh2U2Nyb2xsICE9IFNjcm9sbGJhckF1dG8pCi0g ICAgICAgICAgICBuZXdIYXNWZXJ0aWNhbFNjcm9sbGVyID0gKHZTY3JvbGwgPT0gU2Nyb2xsYmFy QWx3YXlzT24pOwogICAgICAgICBpZiAoaGFzSG9yaXpvbnRhbFNjcm9sbGVyICE9IG5ld0hhc0hv cml6b250YWxTY3JvbGxlcikKICAgICAgICAgICAgIFtzZWxmIHNldEhhc0hvcml6b250YWxTY3Jv bGxlcjpuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXJdOwogICAgICAgICBpZiAoaGFzVmVydGljYWxT Y3JvbGxlciAhPSBuZXdIYXNWZXJ0aWNhbFNjcm9sbGVyKQpAQCAtMTQyLDEyICsxNDMsMTIgQEAg c3RhdGljIGNvbnN0IHVuc2lnbmVkIGNNYXhVcGRhdGVTY3JvbGxiYXJzUGFzcyA9IDI7CiAgICAg ICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxlciA9IGRvY3VtZW50U2l6ZS53aWR0aCA+IHZpc2li bGVTaXplLndpZHRoOwogICAgIGlmICh2U2Nyb2xsID09IFNjcm9sbGJhckF1dG8pCiAgICAgICAg IG5ld0hhc1ZlcnRpY2FsU2Nyb2xsZXIgPSBkb2N1bWVudFNpemUuaGVpZ2h0ID4gdmlzaWJsZVNp emUuaGVpZ2h0OwotICAgIAotICAgIC8vIElmIHdlIGV2ZXIgdHVybiBvbmUgc2Nyb2xsYmFyIG9m ZiwgYWx3YXlzIHR1cm4gdGhlIG90aGVyIG9uZSBvZmYgdG9vLiAgTmV2ZXIgZXZlcgotICAgIC8v IHRyeSB0byBib3RoIGdhaW4vbG9zZSBhIHNjcm9sbGJhciBpbiB0aGUgc2FtZSBwYXNzLgotICAg IGlmICghbmV3SGFzSG9yaXpvbnRhbFNjcm9sbGVyICYmIGhhc0hvcml6b250YWxTY3JvbGxlcikK KworICAgIC8vIFVubGVzcyBpbiBTY3JvbGxiYXJzQWx3YXlzT24gbW9kZSwgaWYgd2UgZXZlciB0 dXJuIG9uZSBzY3JvbGxiYXIgb2ZmLCBhbHdheXMgdHVybiB0aGUgb3RoZXIgb25lIG9mZiB0b28u CisgICAgLy8gTmV2ZXIgZXZlciB0cnkgdG8gYm90aCBnYWluL2xvc2UgYSBzY3JvbGxiYXIgaW4g dGhlIHNhbWUgcGFzcy4KKyAgICBpZiAoIW5ld0hhc0hvcml6b250YWxTY3JvbGxlciAmJiBoYXNI b3Jpem9udGFsU2Nyb2xsZXIgJiYgdlNjcm9sbCAhPSBTY3JvbGxiYXJBbHdheXNPbikKICAgICAg ICAgbmV3SGFzVmVydGljYWxTY3JvbGxlciA9IE5POwotICAgIGlmICghbmV3SGFzVmVydGljYWxT Y3JvbGxlciAmJiBoYXNWZXJ0aWNhbFNjcm9sbGVyKQorICAgIGlmICghbmV3SGFzVmVydGljYWxT Y3JvbGxlciAmJiBoYXNWZXJ0aWNhbFNjcm9sbGVyICYmIGhTY3JvbGwgIT0gU2Nyb2xsYmFyQWx3 YXlzT24pCiAgICAgICAgIG5ld0hhc0hvcml6b250YWxTY3JvbGxlciA9IE5POwogCiAgICAgaWYg KGhhc0hvcml6b250YWxTY3JvbGxlciAhPSBuZXdIYXNIb3Jpem9udGFsU2Nyb2xsZXIpIHsK