25308 2009-04-21 08:22:10 -0700 REGRESSION (r42182): Build fails after following build instructions on webkit.org fail when using VC++ Express 2009-05-05 08:58:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED PlatformOnly P2 Normal --- 1 aroben aroben sfalken oldest_to_newest 118262 0 aroben 2009-04-21 08:22:10 -0700 r42182 changed build-webkit to invoke pdevenv instead of invoking Visual Studio or VC++ Express directly. But this has caused the build to fail when following the build instructions on webkit.org and using VC++ Express. The build fails because windows.h cannot be found. Presumably this is because pdevenv passes the /useenv switch to VC++ Express, and this causes VC++ Express to ignore the Platform SDK paths that were added to it as part of the build instructions. 119968 1 30020 aroben 2009-05-05 08:28:09 -0700 Created attachment 30020 patch + changelog v1 119969 2 30020 eric 2009-05-05 08:29:18 -0700 Comment on attachment 30020 patch + changelog v1 I'm not really an expert here, but this looks sane enough to me. 119978 3 aroben 2009-05-05 08:58:56 -0700 Landed as r43239 30020 2009-05-05 08:28:09 -0700 2009-05-05 08:29:18 -0700 patch + changelog v1 0001--Don-t-use-pdevenv-when-building-with-VC-Ex.patch text/plain 3192 aroben RnJvbSBiZjBlMjhiMjAyMjU5MDQ2NDZkN2EwOWVlYTNlNWQ4MWI5Mjg1ZDI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBU dWUsIDUgTWF5IDIwMDkgMTE6Mjc6NDAgLTA0MDAKU3ViamVjdDogW1BBVENIXSAgICAgICAgIERv bid0IHVzZSBwZGV2ZW52IHdoZW4gYnVpbGRpbmcgd2l0aCBWQysrIEV4cHJlc3MKCiAgICAgICAg Rml4ZXMgQnVnIDI1MzA4OiBSRUdSRVNTSU9OIChyNDIxODIpOiBCdWlsZCBmYWlscyBhZnRlciBm b2xsb3dpbmcKICAgICAgICBidWlsZCBpbnN0cnVjdGlvbnMgb24gd2Via2l0Lm9yZyBmYWlsIHdo ZW4gdXNpbmcgVkMrKyBFeHByZXNzCiAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNTMwOD4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgogICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgogICAgICAgIChzZXR1cEN5Z3dpbkVu dik6IFdoZW4gVmlzdWFsIFN0dWRpbyBpcyBpbnN0YWxsZWQsIHNldCAkdmNCdWlsZFBhdGggdG8K ICAgICAgICBwb2ludCB0byBwZGV2ZW52LiBXaGVuIFZDKysgRXhwcmVzcyBpcyBpbnN0YWxsZWQs IHNldCAkdmNCdWlsZFBhdGggdG8KICAgICAgICBwb2ludCB0byBWQysrIEV4cHJlc3MsIGFzIGJl Zm9yZS4KICAgICAgICAoYnVpbGRWaXN1YWxTdHVkaW9Qcm9qZWN0KTogVXNlICR2Y0J1aWxkUGF0 aCB0byBidWlsZCBpbnN0ZWFkIG9mCiAgICAgICAgaGFyZC1jb2RpbmcgcGRldmVudi4KLS0tCiBX ZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysr CiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gfCAgIDExICsrKysrKy0tLS0tCiAy IGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDA2ODYyZDMuLjEwYWNiZTEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wNS0wNSAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgdXNlIHBkZXZlbnYg d2hlbiBidWlsZGluZyB3aXRoIFZDKysgRXhwcmVzcworCisgICAgICAgIEZpeGVzIEJ1ZyAyNTMw ODogUkVHUkVTU0lPTiAocjQyMTgyKTogQnVpbGQgZmFpbHMgYWZ0ZXIgZm9sbG93aW5nCisgICAg ICAgIGJ1aWxkIGluc3RydWN0aW9ucyBvbiB3ZWJraXQub3JnIGZhaWwgd2hlbiB1c2luZyBWQysr IEV4cHJlc3MKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNTMwOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKHNldHVwQ3lnd2luRW52KTogV2hl biBWaXN1YWwgU3R1ZGlvIGlzIGluc3RhbGxlZCwgc2V0ICR2Y0J1aWxkUGF0aCB0bworICAgICAg ICBwb2ludCB0byBwZGV2ZW52LiBXaGVuIFZDKysgRXhwcmVzcyBpcyBpbnN0YWxsZWQsIHNldCAk dmNCdWlsZFBhdGggdG8KKyAgICAgICAgcG9pbnQgdG8gVkMrKyBFeHByZXNzLCBhcyBiZWZvcmUu CisgICAgICAgIChidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QpOiBVc2UgJHZjQnVpbGRQYXRoIHRv IGJ1aWxkIGluc3RlYWQgb2YKKyAgICAgICAgaGFyZC1jb2RpbmcgcGRldmVudi4KKwogMjAwOS0w NS0wNCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5j by51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDllMTg0ZjkuLjY0M2IyNGYgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KQEAgLTkxMiw4ICs5MTIsMTEgQEAgc3ViIHNldHVwQ3lnd2luRW52KCkK ICAgICBteSAkcHJvZ3JhbUZpbGVzUGF0aCA9IGBjeWdwYXRoICIkRU5WeydQUk9HUkFNRklMRVMn fSJgOwogICAgIGNob21wICRwcm9ncmFtRmlsZXNQYXRoOwogICAgICR2Y0J1aWxkUGF0aCA9ICIk cHJvZ3JhbUZpbGVzUGF0aC9NaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyA4L0NvbW1vbjcvSURFL2Rl dmVudi5jb20iOwotICAgIGlmICghIC1lICR2Y0J1aWxkUGF0aCkgewotICAgICAgICAjIFZDKysg bm90IGZvdW5kLCB0cnkgVkMrKyBFeHByZXNzCisgICAgaWYgKC1lICR2Y0J1aWxkUGF0aCkgewor ICAgICAgICAjIFZpc3VhbCBTdHVkaW8gaXMgaW5zdGFsbGVkOyB3ZSBjYW4gdXNlIHBkZXZlbnYg dG8gYnVpbGQuCisgICAgICAgICR2Y0J1aWxkUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoc291 cmNlRGlyKCksIHF3KFdlYktpdFRvb2xzIFNjcmlwdHMgcGRldmVudikpOworICAgIH0gZWxzZSB7 CisgICAgICAgICMgVmlzdWFsIFN0dWRpbyBub3QgZm91bmQsIHRyeSBWQysrIEV4cHJlc3MKICAg ICAgICAgbXkgJHZzSW5zdGFsbERpcjsKICAgICAgICAgaWYgKCRFTlZ7J1ZTSU5TVEFMTERJUid9 KSB7CiAgICAgICAgICAgICAkdnNJbnN0YWxsRGlyID0gJEVOVnsnVlNJTlNUQUxMRElSJ307CkBA IC05ODAsOSArOTgzLDcgQEAgc3ViIGJ1aWxkVmlzdWFsU3R1ZGlvUHJvamVjdAogICAgICAgICAk YWN0aW9uID0gIi9jbGVhbiI7CiAgICAgfQogCi0gICAgbXkgJHBkZXZlbnZQYXRoID0gRmlsZTo6 U3BlYy0+Y2F0ZmlsZShzb3VyY2VEaXIoKSwgcXcoV2ViS2l0VG9vbHMgU2NyaXB0cyBwZGV2ZW52 KSk7Ci0KLSAgICBteSBAY29tbWFuZCA9ICgkcGRldmVudlBhdGgsICR3aW5Qcm9qZWN0UGF0aCwg JGFjdGlvbiwgJGNvbmZpZyk7CisgICAgbXkgQGNvbW1hbmQgPSAoJHZjQnVpbGRQYXRoLCAkd2lu UHJvamVjdFBhdGgsICRhY3Rpb24sICRjb25maWcpOwogCiAgICAgcHJpbnQgam9pbigiICIsIEBj b21tYW5kKSwgIlxuIjsKICAgICByZXR1cm4gc3lzdGVtIEBjb21tYW5kOwotLSAKMS42LjIuNAoK