253066 2023-02-28 02:54:37 -0800 [webkitcorepy] AutoInstall unable to install pytest-asyncio (or other packages without setup.py) 2023-03-05 17:41:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders jbedard cgarcia clopez dpino fujii jbedard lmoura pangle webkit-bug-importer oldest_to_newest 1937334 0 gsnedders 2023-02-28 02:54:37 -0800 258166@main (bug 249564) updated the AutoInstalled versions of pytest and its plugins, including pytest-asyncio. pytest-asyncio, as of 0.19, no longer includes a setup.py: it relies on the build frontend reading pyproject.toml, per PEP 517 (https://peps.python.org/pep-0517/). However, the AutoInstall has no knowledge of PEP 517, and instead tries to run a setup.py, and falls back to just copying the whole source packages over and hoping for the best. This (unsurprisingly) doesn't work well. 1937836 1 jbedard 2023-03-01 10:50:53 -0800 Looks like pytest-asyncio includes a setup.cfg, so it's note entirely in a world with only pyproject.toml yet. We also would need to bump our setuptools version to support pyproject.toml, which I'm not against in the long term, but I think needs a tad more validation. Fixing pytest-asyncio, however, doesn't require bumping setuptools. It just requires laying down a dummy setup.py file which picks up setup.cfg through setuptools. We don't even have to touch our invocation of setup.py, which is actually somewhat surprising. 1937837 2 webkit-bug-importer 2023-03-01 10:53:00 -0800 <rdar://problem/106095209> 1937840 3 jbedard 2023-03-01 10:56:09 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10880 1938275 4 ews-feeder 2023-03-02 13:51:20 -0800 Committed 261097@main (752a2873e756): <https://commits.webkit.org/261097@main> Reviewed commits have been landed. Closing PR #10880 and removing active labels. 1938347 5 ews-feeder 2023-03-02 16:46:15 -0800 Committed 259548.354@safari-7615-branch (c2279007a3a5): <https://commits.webkit.org/259548.354@safari-7615-branch> Reviewed commits have been landed. Closing PR #431 and removing active labels. 1939004 6 fujii 2023-03-05 17:41:33 -0800 Regressed: Bug 253421 – REGRESSION(261097@main) [Win] test-webkitpy: Failed to install pytest-asyncio-0.20.3!