253048 2023-02-27 19:26:19 -0800 REGRESSION(257654@main): [ews-build.webkit.org][GTK][WPE] RunWebKitTestsRedTree sub-classes are overwriting the 'first_run' properties on the retry steps. 2023-03-03 13:46:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=249026 https://bugs.webkit.org/show_bug.cgi?id=231999 InRadar P2 Normal --- 1 clopez clopez jbedard webkit-bug-importer oldest_to_newest 1937262 0 clopez 2023-02-27 19:26:19 -0800 257654@main changed the way the class RunWebKitTests() works: instead of specializing the function buildstep.BuildStep.commandComplete() the function buildstep.BuildStep.runCommand() is specialized. Buildbot first calls runCommand() and then calls commandComplete() The problem is with the subclasses of RunWebKitTests() which were specializing a commandComplete() function: now instead of executing the generic buildstep.BuildStep.runCommand() they execute the specialized RunWebKitTests.runCommand() which was the previous RunWebKitTests.commandComplete() so this has the undesired effect that the properties defined at RunWebKitTests().runCommand() ('first_run_flakies', 'first_run_failures' and 'first_results_exceed_failure_limit') get redefined (overwritten) multiple times with the values generated when running the command of each one of the sub-classes. This is wrong and can causes unexpected issues later when analyzing the results in AnalyzeLayoutTestsResultsRedTree() because the values of the properties 'first_run_flakies' and 'first_run_failures' are not the ones from the first run but the ones from the last retry step executed. 1937265 1 clopez 2023-02-27 19:45:49 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10776 1938627 2 ews-feeder 2023-03-03 13:45:07 -0800 Committed 261167@main (440943ba5b7e): <https://commits.webkit.org/261167@main> Reviewed commits have been landed. Closing PR #10776 and removing active labels. 1938628 3 webkit-bug-importer 2023-03-03 13:46:16 -0800 <rdar://problem/106210291>