252975 2023-02-26 21:13:08 -0800 [margin-trim] shouldChildInlineMarginContributeToContainerIntrinsicSize should take into consideration text 2023-03-06 09:45:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 253165 InRadar P2 Normal --- 1 sgill26 webkit-unassigned bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1936928 0 465194 sgill26 2023-02-26 21:13:08 -0800 Created attachment 465194 Testcase The attached test case shows how text can end up in a RenderBlockFlow. Currently shouldChildInlineMarginContributeToContainerIntrinsicSize is unable to handle such a case since it takes a RenderElement 1939026 1 webkit-bug-importer 2023-03-05 21:14:15 -0800 <rdar://problem/106271482> 1939153 2 sgill26 2023-03-06 09:45:46 -0800 There better option here was to maintain the function signature as is since it makes more sense and then check the value we are trying to pass in at the call site. *** This bug has been marked as a duplicate of bug 253165 *** 465194 2023-02-26 21:13:08 -0800 2023-02-26 21:13:08 -0800 Testcase testcase.html text/html 470 sgill26 PHN0eWxlPgoqIHsgCiAgICAtd2Via2l0LXVzZXItbW9kaWZ5OiByZWFkLXdyaXRlOwp9Cjwvc3R5 bGU+CjxzY3JpcHQ+CiAgICBmdW5jdGlvbiBtYWluKCkgewogICAgICAgIHRyeSB7IGRvY3VtZW50 LmRlc2lnbk1vZGUgPSAib24iOyB9IGNhdGNoIHsgfQogICAgICAgIHRyeSB7IGRvY3VtZW50LmV4 ZWNDb21tYW5kKCJzZWxlY3RBbGwiLCBmYWxzZSwgbnVsbCk7IH0gY2F0Y2ggeyB9CiAgICAgICAg dHJ5IHsgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIml0YWxpYyIsIGZhbHNlLCBudWxsKTsgfSBjYXRj aCB7IH0KICAgICAgICB0cnkgeyBkb2N1bWVudC5leGVjQ29tbWFuZCgiaXRhbGljIiwgZmFsc2Us IG51bGwpOyB9IGNhdGNoIHsgfQogICAgfQo8L3NjcmlwdD4KCjxib2R5IG9ubG9hZD0ibWFpbigp Ij4KPHJ1Ynk+CjxoMT48L2gxPgo8cnQ+CjxwPjwvcD4KPGlucHV0Pgo8L3J0PgpjcmFzaAo8cnA+ PC9ycD4KPC9ydWJ5Pgo=