<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>252944</bug_id>
          
          <creation_ts>2023-02-25 05:20:49 -0800</creation_ts>
          <short_desc>Remove a bogus assert in restoreScrollPositionAndViewState</short_desc>
          <delta_ts>2023-10-03 14:49:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>History</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=16952</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=50331</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=36464</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>cdumez</cc>
    
    <cc>fishd</cc>
    
    <cc>mario</cc>
    
    <cc>mitz</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1936745</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-02-25 05:20:49 -0800</bug_when>
    <thetext>Hi Team,

While going through Blink&apos;s commit, I came across following commit, which can be merged with WebKit:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/dea55cb041d519f2f42a85449e3071b3c9813f30

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/loader/HistoryController.cpp#123

It will get rid of FIXME as well.

I have looked in bugzilla and came across two bugs similar bug 50331 and bug 36464 touching same assertion.

Appreciate if someone can share their input so we can also get rid of this FIXME.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1937063</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2023-02-27 10:13:32 -0800</bug_when>
    <thetext>I think that bug 16952 is the oldest. Simon, Chris, is the analysis still applicable, should the assertion be removed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1938821</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-03-04 05:21:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/106232374&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1982145</commentid>
    <comment_count>3</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-10-03 10:50:20 -0700</bug_when>
    <thetext>*** Bug 16952 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1982147</commentid>
    <comment_count>4</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-10-03 10:50:37 -0700</bug_when>
    <thetext>*** Bug 50331 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1982149</commentid>
    <comment_count>5</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-10-03 10:50:49 -0700</bug_when>
    <thetext>*** Bug 36464 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1982150</commentid>
    <comment_count>6</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-10-03 10:51:23 -0700</bug_when>
    <thetext>PR - https://github.com/WebKit/WebKit/pull/18559</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1982233</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-03 14:49:32 -0700</bug_when>
    <thetext>Committed 268803@main (8a2524e6b2d8): &lt;https://commits.webkit.org/268803@main&gt;

Reviewed commits have been landed. Closing PR #18559 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>