25285 2009-04-18 17:51:12 -0700 REGRESSION (r42569): Profiles cannot be selected in inspector profiler 2009-04-18 18:01:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction, InRadar, Regression P2 Normal --- 1 ggaren ggaren zwarich oldest_to_newest 118032 0 ggaren 2009-04-18 17:51:12 -0700 4/16/09 2:23 AM Oliver Hunt: * SUMMARY Revision r42569 added code that clears the event listener function and globalObject references, which breaks (at the very least) the profiler. * STEPS TO REPRODUCE 1. Go to https://bugs.webkit.org/attachment.cgi?id=29532 2. Open the inspector 3. Go to the profiles pane 4. enable profiling 5. return to the safari window 6. reload 7. return to the inspector window 8. attempt to focus/select the create profile * RESULTS The profile cannot be selected, but we should be able to. I would guess that this has potential to effect many sites. * REGRESSION Introduced by r42569 Commenting out 155 m_jsFunction = 0; 156 m_globalObject = 0; in JSEventListener::clearJSFunctionInline() Restores "Correct" behaviour -- don't know able actual correctness however 4/17/09 2:36 PM David Kilzer: http://trac.webkit.org/changeset/42569 118033 1 29601 ggaren 2009-04-18 17:51:41 -0700 Created attachment 29601 patch 118034 2 29601 zwarich 2009-04-18 17:53:51 -0700 Comment on attachment 29601 patch r=me, but you should either add a test or mention why you can't in the ChangeLog. 118035 3 29602 ggaren 2009-04-18 17:59:49 -0700 Created attachment 29602 patch w/test Oops! Forgot to attach the test. Here it is. I'll invalidate the last patch, and mark this one r+. 118036 4 ddkilzer 2009-04-18 18:01:22 -0700 <rdar://problem/6797442> 118037 5 ggaren 2009-04-18 18:01:43 -0700 http://trac.webkit.org/changeset/42645 29601 2009-04-18 17:51:41 -0700 2009-04-18 17:59:49 -0700 patch patch.txt text/plain 1620 ggaren SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQyNjQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDQt MTggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCA8cmRhcjovL3Byb2JsZW0vNjc5 NzQ0Mj4gUkVHUkVTU0lPTiAocjQyNTY5KTogUHJvZmlsZXMgY2Fubm90IGJlCisgICAgICAgIHNl bGVjdGVkIGluIGluc3BlY3RvciBwcm9maWxlcgorICAgICAgICAKKyAgICAgICAgRXZlbnRMaXN0 ZW5lcnMgYXJlIHNoYXJlZDsgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXJzIGFyZSBub3QuIFRoZXJl Zm9yZSwKKyAgICAgICAgd2hlbiBhIG5vZGUgd3JhcHBlciBuZWVkcyB0byBpbnZhbGlkYXRlIHRo ZSBub2RlJ3MgSlMgZXZlbnQgbGlzdGVuZXJzLAorICAgICAgICBpdCBzaG91bGQgaW52YWxpZGF0 ZSBpdHMgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXJzLCBub3QgaXRzIEV2ZW50TGlzdGVuZXJzLgor ICAgICAgICBPdGhlcndpc2UsIGl0IG1pZ2h0IGludmFsaWRhdGUgYW4gRXZlbnRMaXN0ZW5lciBz aGFyZWQgYnkgYW5vdGhlciBub2RlLgorCisgICAgICAgICogZG9tL1JlZ2lzdGVyZWRFdmVudExp c3RlbmVyLmg6CisgICAgICAgIChXZWJDb3JlOjppbnZhbGlkYXRlRXZlbnRMaXN0ZW5lcnMpOiBk aXR0bworCiAyMDA5LTA0LTE4ICBQaWVycmUgZCdIZXJiZW1vbnQgIDxwZGhlcmJlbW9udEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpJbmRleDogZG9tL1JlZ2lz dGVyZWRFdmVudExpc3RlbmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZG9tL1JlZ2lzdGVyZWRFdmVudExp c3RlbmVyLmgJKHJldmlzaW9uIDQyNjQ0KQorKysgZG9tL1JlZ2lzdGVyZWRFdmVudExpc3RlbmVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDggKzYzLDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogICAgIGlubGluZSB2b2lkIGludmFsaWRhdGVFdmVudExpc3RlbmVycyhjb25zdCBSZWdpc3Rl cmVkRXZlbnRMaXN0ZW5lclZlY3RvciYgbGlzdGVuZXJzKQogICAgIHsKKyAgICAgICAgLy8gRm9y IGVmZmljaWVuY3kncyBzYWtlLCB3ZSBqdXN0IHNldCB0aGUgInJlbW92ZWQiIGJpdCwgaW5zdGVh ZCBvZgorICAgICAgICAvLyBhY3R1YWxseSByZW1vdmluZyB0aGUgZXZlbnQgbGlzdGVuZXIuIFRo ZSBub2RlIHRoYXQgb3ducyB0aGVzZQorICAgICAgICAvLyBsaXN0ZW5lcnMgaXMgYWJvdXQgdG8g YmUgZGVsZXRlZCwgYW55d2F5LgogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxpc3Rl bmVycy5zaXplKCk7ICsraSkKLSAgICAgICAgICAgIGxpc3RlbmVyc1tpXS0+bGlzdGVuZXIoKS0+ Y2xlYXJKU0Z1bmN0aW9uKCk7CisgICAgICAgICAgICBsaXN0ZW5lcnNbaV0tPnNldFJlbW92ZWQo dHJ1ZSk7CiAgICAgfQogI2VuZGlmCiAK 29602 2009-04-18 17:59:49 -0700 2009-04-18 17:59:49 -0700 patch w/test patch.txt text/plain 5372 ggaren SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjY0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDQtMTggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBDYW1lcm9uIFp3YXJpY2guCisKKyAgICAgICAg Rml4ZWQgPHJkYXI6Ly9wcm9ibGVtLzY3OTc0NDI+IHwgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI1Mjg1CisgICAgICAgIFJFR1JFU1NJT04gKHI0MjU2OSk6IFByb2Zp bGVzIGNhbm5vdCBiZSBzZWxlY3RlZCBpbiBpbnNwZWN0b3IgcHJvZmlsZXIKKyAgICAgICAgCisg ICAgICAgIEV2ZW50TGlzdGVuZXJzIGFyZSBzaGFyZWQ7IFJlZ2lzdGVyZWRFdmVudExpc3RlbmVy cyBhcmUgbm90LiBUaGVyZWZvcmUsCisgICAgICAgIHdoZW4gYSBub2RlIHdyYXBwZXIgbmVlZHMg dG8gaW52YWxpZGF0ZSB0aGUgbm9kZSdzIEpTIGV2ZW50IGxpc3RlbmVycywKKyAgICAgICAgaXQg c2hvdWxkIGludmFsaWRhdGUgaXRzIFJlZ2lzdGVyZWRFdmVudExpc3RlbmVycywgbm90IGl0cyBF dmVudExpc3RlbmVycy4KKyAgICAgICAgT3RoZXJ3aXNlLCBpdCBtaWdodCBpbnZhbGlkYXRlIGFu IEV2ZW50TGlzdGVuZXIgc2hhcmVkIGJ5IGFub3RoZXIgbm9kZS4KKworICAgICAgICAqIGRvbS9S ZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5oOgorICAgICAgICAoV2ViQ29yZTo6aW52YWxpZGF0ZUV2 ZW50TGlzdGVuZXJzKTogZGl0dG8KKwogMjAwOS0wNC0xOCAgUGllcnJlIGQnSGVyYmVtb250ICA8 cGRoZXJiZW1vbnRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4K SW5kZXg6IFdlYkNvcmUvZG9tL1JlZ2lzdGVyZWRFdmVudExpc3RlbmVyLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9kb20vUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXIuaAkocmV2aXNpb24gNDI2NDQp CisrKyBXZWJDb3JlL2RvbS9SZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5oCSh3b3JraW5nIGNvcHkp CkBAIC02Myw4ICs2MywxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBpbmxpbmUgdm9p ZCBpbnZhbGlkYXRlRXZlbnRMaXN0ZW5lcnMoY29uc3QgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXJW ZWN0b3ImIGxpc3RlbmVycykKICAgICB7CisgICAgICAgIC8vIEZvciBlZmZpY2llbmN5J3Mgc2Fr ZSwgd2UganVzdCBzZXQgdGhlICJyZW1vdmVkIiBiaXQsIGluc3RlYWQgb2YKKyAgICAgICAgLy8g YWN0dWFsbHkgcmVtb3ZpbmcgdGhlIGV2ZW50IGxpc3RlbmVyLiBUaGUgbm9kZSB0aGF0IG93bnMg dGhlc2UKKyAgICAgICAgLy8gbGlzdGVuZXJzIGlzIGFib3V0IHRvIGJlIGRlbGV0ZWQsIGFueXdh eS4KICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBsaXN0ZW5lcnMuc2l6ZSgpOyArK2kp Ci0gICAgICAgICAgICBsaXN0ZW5lcnNbaV0tPmxpc3RlbmVyKCktPmNsZWFySlNGdW5jdGlvbigp OworICAgICAgICAgICAgbGlzdGVuZXJzW2ldLT5zZXRSZW1vdmVkKHRydWUpOwogICAgIH0KICNl bmRpZgogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA0MjY0NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA0LTE4ICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FtZXJvbiBa d2FyaWNoLgorICAgICAgICAKKyAgICAgICAgVGVzdCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzY3OTc0 NDI+IHwgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1Mjg1CisgICAg ICAgIFJFR1JFU1NJT04gKHI0MjU2OSk6IFByb2ZpbGVzIGNhbm5vdCBiZSBzZWxlY3RlZCBpbiBp bnNwZWN0b3IgcHJvZmlsZXIKKworICAgICAgICAqIGZhc3QvZXZlbnRzL2V2ZW50LWxpc3RlbmVy LXNoYXJpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9ldmVu dC1saXN0ZW5lci1zaGFyaW5nLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL3Jl c291cmNlcy9ldmVudC1saXN0ZW5lci1zaGFyaW5nLmpzOiBBZGRlZC4KKyAgICAgICAgKGdjKToK KyAgICAgICAgKGNsaWNrSGFuZGxlcik6CisKIDIwMDktMDQtMTggIEp1c3RpbiBHYXJjaWEgIDxq dXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGVkIHRlc3QgcmVzdWx0cyBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1Mjc3CkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9ldmVudC1saXN0ZW5lci1zaGFyaW5nLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9ldmVudC1saXN0ZW5lci1z aGFyaW5nLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZl bnRzL2V2ZW50LWxpc3RlbmVyLXNoYXJpbmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDEwIEBACitUZXN0cyB0aGF0IGFuIGV2ZW50IGhhbmRsZXIgcmVnaXN0ZXJlZCBvbiB0 d28gbm9kZXMgc3RpbGwgZmlyZXMgYWZ0ZXIgb25lIG9mIHRoZSBub2RlcyBoYXMgYmVlbiBHQydk LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBjbGlja0NvdW50IGlzIDEw MAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2V2ZW50LWxpc3RlbmVyLXNoYXJpbmcuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9ldmVudC1saXN0ZW5lci1zaGFy aW5nLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9ldmVudC1s aXN0ZW5lci1zaGFyaW5nLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0 eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2 IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvZXZlbnQtbGlzdGVu ZXItc2hhcmluZy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9yZXNvdXJjZXMvZXZlbnQtbGlzdGVuZXItc2hhcmluZy5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZXNvdXJjZXMvZXZlbnQtbGlzdGVu ZXItc2hhcmluZy5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Jl c291cmNlcy9ldmVudC1saXN0ZW5lci1zaGFyaW5nLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDQ2IEBACitkZXNjcmlwdGlvbigKKyJUZXN0cyB0aGF0IGFuIGV2ZW50IGhhbmRsZXIgcmVnaXN0 ZXJlZCBvbiB0d28gbm9kZXMgc3RpbGwgZmlyZXMgYWZ0ZXIgb25lIG9mIHRoZSBub2RlcyBoYXMg YmVlbiBHQydkLiIKKyk7CisKK2Z1bmN0aW9uIGdjKCkgeworICAgIGlmICh3aW5kb3cuR0NDb250 cm9sbGVyKQorICAgICAgICBHQ0NvbnRyb2xsZXIuY29sbGVjdCgpOworICAgIGVsc2UgeworICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDAwOyArK2kpCisgICAgICAgICAgICBuZXcgT2Jq ZWN0OworICAgIH0KK30KKwordmFyIGNsaWNrQ291bnQgPSAwOworZnVuY3Rpb24gY2xpY2tIYW5k bGVyKCkgeworICAgICsrY2xpY2tDb3VudDsKK307CisKKyhmdW5jdGlvbiAoKSB7CisgICAgLy8g UmVnaXN0ZXIgJ2NsaWNrSGFuZGxlcicgb24gc29tZSByZWZlcmVuY2VkIGRpdnMuCisgICAgdmFy IGRpdnMgPSBbXTsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDsgKytpKSB7CisgICAgICAg IHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAgICAgICAgZGl2LmFk ZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgY2xpY2tIYW5kbGVyLCBmYWxzZSk7CisgICAgICAgIGRp dnMucHVzaChkaXYpOworICAgIH0KKyAgICAKKyAgICAvLyBSZWdpc3RlciAnY2xpY2tIYW5kbGVy JyBvbiBzb21lIGdhcmJhZ2UgZGl2cy4KKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDsgKytp KSB7CisgICAgICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAg ICAgICAgZGl2LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgY2xpY2tIYW5kbGVyLCBmYWxzZSk7 CisgICAgfQorICAgIAorICAgIC8vIEdDIHRoZSBnYXJiYWdlIGRpdnMuCisgICAgZ2MoKTsKKyAg ICAKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDsgKytpKSB7CisgICAgICAgIHZhciBjbGlj a0V2ZW50ID0gZG9jdW1lbnQuY3JlYXRlRXZlbnQoIk1vdXNlRXZlbnRzIik7CisgICAgICAgIGNs aWNrRXZlbnQuaW5pdE1vdXNlRXZlbnQoImNsaWNrIiwgdHJ1ZSwgdHJ1ZSwgbnVsbCwgMSwgMSwg MSwgMSwgMSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIDAsIGRvY3VtZW50KTsKKyAgICAg ICAgZGl2c1tpXS5kaXNwYXRjaEV2ZW50KGNsaWNrRXZlbnQpOworICAgIH0KKyAgICAKKyAgICBz aG91bGRCZSgiY2xpY2tDb3VudCIsICIxMDAiKTsKK30pKCk7CisKK3ZhciBzdWNjZXNzZnVsbHlQ YXJzZWQgPSB0cnVlOwo=