252827 2023-02-23 07:33:29 -0800 [GLib] Ensure no final classes have public class structs 2023-03-01 08:29:47 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 210100 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro oldest_to_newest 1936181 0 mcatanzaro 2023-02-23 07:33:29 -0800 In bug #243663 Adrian hid the class structs of most final classes. However, a few classes still do have public class structs because they have vtables. The vtables are now useless because the classes are not derivable, so they need to be hidden. This was not done in bug #243663 because it requires a little additional work to avoid breaking the original API version. 1936187 1 mcatanzaro 2023-02-23 07:53:07 -0800 Affected classes are WebKitDownload, WebKitWebContext, and WebKitWebHitTestResult 1937142 2 mcatanzaro 2023-02-27 12:25:33 -0800 Emmanuele says we should use g_signal_override_class_handler() rather than the g_signal_connect_after() that I had been planning to use. I'm planning to handle WebKitDownload in bug #238748 and the other two classes here. 1937747 3 mcatanzaro 2023-03-01 06:52:28 -0800 (In reply to Michael Catanzaro from comment #1) > Affected classes are WebKitDownload, WebKitWebContext, and > WebKitWebHitTestResult Actually, Adrian already handled WebKitWebHitTestResult. And we decided not to handle WebKitDownload in bug #238748 after all. So here I'll handle WebKitDownload and WebKitWebContext. 1937751 4 mcatanzaro 2023-03-01 07:18:14 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10865 1937787 5 ews-feeder 2023-03-01 08:29:41 -0800 Committed 261011@main (5e3c2e27ef61): <https://commits.webkit.org/261011@main> Reviewed commits have been landed. Closing PR #10865 and removing active labels.