25275 2009-04-17 16:02:47 -0700 use AtomicString to speed up window and document interceptors 2009-04-30 10:28:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 asargent asargent dglazkov oldest_to_newest 117981 0 asargent 2009-04-17 16:02:47 -0700 Patch forthcoming. 117984 1 29590 asargent 2009-04-17 16:06:43 -0700 Created attachment 29590 patch v1 117989 2 29590 dglazkov 2009-04-17 16:19:35 -0700 Comment on attachment 29590 patch v1 Looks good. > + http://codereview.chromium.org/67141 Don't need Chromium review in ChangeLog, probably. Just mention it on bug. 119353 3 29590 eric 2009-04-29 14:48:45 -0700 Comment on attachment 29590 patch v1 WebKit uses DEFINE_STATIC_LOCAL for local statics. The Mac build will have trouble if we don't here too. // Use these to declare and define a static local variable (static T;) so that // it is leaked so that its destructors are not called at exit. Using this // macro also allows workarounds a compiler bug present in Apple's version of GCC 4.0.1. #if COMPILER(GCC) && defined(__APPLE_CC__) && __GNUC__ == 4 && __GNUC_MINOR__ == 0 && __GNUC_PATCHLEVEL__ == 1 #define DEFINE_STATIC_LOCAL(type, name, arguments) \ static type* name##Ptr = new type arguments; \ type& name = *name##Ptr #else #define DEFINE_STATIC_LOCAL(type, name, arguments) \ static type& name = *new type arguments #endif 119354 4 eric 2009-04-29 14:49:09 -0700 cc-ing Dimitri so he can see my comments. 119378 5 29896 asargent 2009-04-29 15:43:47 -0700 Created attachment 29896 patch v2 Switched to using DEFINE_STATIC_LOCAL. Thanks for catching this Eric! 119379 6 29896 eric 2009-04-29 15:44:54 -0700 Comment on attachment 29896 patch v2 Looks fine. Will land. 119382 7 eric 2009-04-29 15:48:36 -0700 Do we have any performance tests which show that this is actually faster? I'm going to land it as-is... but it seems this sort of change should have some perf-data associated with it. 119383 8 eric 2009-04-29 15:49:00 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp M WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp Committed r43022 119479 9 dglazkov 2009-04-30 09:48:59 -0700 Whoops. Last patch actually introduced variable redefinition. Fixing... 119485 10 dglazkov 2009-04-30 10:28:01 -0700 Fix landed in http://trac.webkit.org/changeset/43066. 29590 2009-04-17 16:06:43 -0700 2009-04-29 15:43:47 -0700 patch v1 patch.txt text/plain 3086 asargent SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQyNjI5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMDQt MTcgIEFudG9ueSBTYXJnZW50ICA8YXNhcmdlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBBdG9taWNTdHJpbmcgdG8g c3BlZWQgdXAgd2luZG93IGFuZCBkb2N1bWVudCBpbnRlcmNlcHRvcnMuIAorCisgICAgICAgIGh0 dHA6Ly9jb2RlcmV2aWV3LmNocm9taXVtLm9yZy82NzE0MQorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTI3NQorCisgICAgICAgICogYmluZGluZ3Mv djgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5BTUVE X1BST1BFUlRZX0dFVFRFUik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERv Y3VtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5BTUVEX1BST1BFUlRZX0RFTEVU RVIpOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVSKToKKwogMjAwOS0w NC0xNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTWFyayBSb3dlCkluZGV4OiBiaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0 b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3Rv bS5jcHAJKHJldmlzaW9uIDQyNjI5KQorKysgYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93 Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTM2LDEzICs1MzYsMTMgQEAgTkFNRURfUFJP UEVSVFlfR0VUVEVSKERPTVdpbmRvdykKICAgICBpZiAoIXdpbmRvdykKICAgICAgICAgcmV0dXJu IG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAKLSAgICBTdHJpbmcgcHJvcE5hbWUgPSB0b1dl YkNvcmVTdHJpbmcobmFtZSk7Ci0KICAgICBGcmFtZSogZnJhbWUgPSB3aW5kb3ctPmZyYW1lKCk7 CiAgICAgLy8gd2luZG93IGlzIGRldGFjaGVkIGZyb20gYSBmcmFtZS4KICAgICBpZiAoIWZyYW1l KQogICAgICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAorICAgIEF0b21p Y1N0cmluZyBwcm9wTmFtZSA9IHY4U3RyaW5nVG9BdG9taWNXZWJDb3JlU3RyaW5nKG5hbWUpOwor CiAgICAgLy8gU2VhcmNoIHN1Yi1mcmFtZXMuCiAgICAgRnJhbWUqIGNoaWxkID0gZnJhbWUtPnRy ZWUoKS0+Y2hpbGQocHJvcE5hbWUpOwogICAgIGlmIChjaGlsZCkKSW5kZXg6IGJpbmRpbmdzL3Y4 L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYmluZGluZ3Mv djgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcAkocmV2aXNpb24gNDI2MjkpCisrKyBi aW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00OCw4ICs0OCw5IEBAIE5BTUVEX1BST1BFUlRZX0RFTEVURVIoSFRNTERvY3VtZW50KQog ICAgIC8vIE9ubHkgaGFuZGxlIGRvY3VtZW50LmFsbC4gIEluc2VydCB0aGUgbWFya2VyIG9iamVj dCBpbnRvIHRoZQogICAgIC8vIHNoYWRvdyBpbnRlcm5hbCBmaWVsZCB0byBzaWduYWwgdGhhdCBk b2N1bWVudC5hbGwgaXMgbm8gbG9uZ2VyCiAgICAgLy8gc2hhZG93ZWQuCi0gICAgU3RyaW5nIGtl eSA9IHRvV2ViQ29yZVN0cmluZyhuYW1lKTsKLSAgICBpZiAoa2V5ICE9ICJhbGwiKQorICAgIEF0 b21pY1N0cmluZyBrZXkgPSB2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0cmluZyhuYW1lKTsKKyAg ICBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nIGFsbCgiYWxsIik7CisgICAgaWYgKGtleSAhPSBh bGwpCiAgICAgICAgIHJldHVybiBkZWxldGlvbk5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAK ICAgICBBU1NFUlQoaW5mby5Ib2xkZXIoKS0+SW50ZXJuYWxGaWVsZENvdW50KCkgPT0ga0hUTUxE b2N1bWVudEludGVybmFsRmllbGRDb3VudCk7CkBAIC02MSwxMiArNjIsMTMgQEAgTkFNRURfUFJP UEVSVFlfREVMRVRFUihIVE1MRG9jdW1lbnQpCiBOQU1FRF9QUk9QRVJUWV9HRVRURVIoSFRNTERv Y3VtZW50KQogewogICAgIElOQ19TVEFUUygiRE9NLkhUTUxEb2N1bWVudC5OYW1lZFByb3BlcnR5 R2V0dGVyIik7Ci0gICAgQXRvbWljU3RyaW5nIGtleSA9IHRvV2ViQ29yZVN0cmluZyhuYW1lKTsK KyAgICBBdG9taWNTdHJpbmcga2V5ID0gdjhTdHJpbmdUb0F0b21pY1dlYkNvcmVTdHJpbmcobmFt ZSk7CiAKICAgICAvLyBTcGVjaWFsIGNhc2UgZm9yIGRvY3VtZW50LmFsbC4gIElmIHRoZSB2YWx1 ZSBpbiB0aGUgc2hhZG93CiAgICAgLy8gaW50ZXJuYWwgZmllbGQgaXMgbm90IHRoZSBtYXJrZXIg b2JqZWN0LCB0aGVuIGRvY3VtZW50LmFsbCBoYXMKICAgICAvLyBiZWVuIHRlbXBvcmFyaWx5IHNo YWRvd2VkIGFuZCB3ZSByZXR1cm4gdGhlIHZhbHVlLgotICAgIGlmIChrZXkgPT0gImFsbCIpIHsK KyAgICBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nIGFsbCgiYWxsIik7CisgICAgaWYgKGtleSA9 PSBhbGwpIHsKICAgICAgICAgQVNTRVJUKGluZm8uSG9sZGVyKCktPkludGVybmFsRmllbGRDb3Vu dCgpID09IGtIVE1MRG9jdW1lbnRJbnRlcm5hbEZpZWxkQ291bnQpOwogICAgICAgICB2ODo6TG9j YWw8djg6OlZhbHVlPiBtYXJrZXIgPSBpbmZvLkhvbGRlcigpLT5HZXRJbnRlcm5hbEZpZWxkKGtI VE1MRG9jdW1lbnRNYXJrZXJJbmRleCk7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZh bHVlID0gaW5mby5Ib2xkZXIoKS0+R2V0SW50ZXJuYWxGaWVsZChrSFRNTERvY3VtZW50U2hhZG93 SW5kZXgpOwo= 29896 2009-04-29 15:43:47 -0700 2009-04-29 15:44:54 -0700 patch v2 patch_v2.txt text/plain 3054 asargent SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQzMDE2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDQt MjkgIEFudG9ueSBTYXJnZW50ICA8YXNhcmdlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBBdG9taWNTdHJpbmcgdG8g c3BlZWQgdXAgd2luZG93IGFuZCBkb2N1bWVudCBpbnRlcmNlcHRvcnMuIAorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTI3NQorCisgICAgICAgICog YmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok5BTUVEX1BST1BFUlRZX0dFVFRFUik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9t L1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5BTUVEX1BST1BF UlRZX0RFTEVURVIpOgorICAgICAgICAoV2ViQ29yZTo6TkFNRURfUFJPUEVSVFlfR0VUVEVSKToK KwogMjAwOS0wNC0yOSAgTWlrZSBCZWxzaGUgIDxtaWtlQGJlbHNoZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBiaW5kaW5ncy92OC9jdXN0b20vVjhET01X aW5kb3dDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdp bmRvd0N1c3RvbS5jcHAJKHJldmlzaW9uIDQzMDE2KQorKysgYmluZGluZ3MvdjgvY3VzdG9tL1Y4 RE9NV2luZG93Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTU0LDYgKzU1NCw4IEBAIE5B TUVEX1BST1BFUlRZX0dFVFRFUihET01XaW5kb3cpCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg cmV0dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAKKyAgICBBdG9taWNTdHJpbmcgcHJv cE5hbWUgPSB2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0cmluZyhuYW1lKTsKKwogICAgIC8vIFNl YXJjaCBzdWItZnJhbWVzLgogICAgIEF0b21pY1N0cmluZyBwcm9wTmFtZSA9IHY4U3RyaW5nVG9B dG9taWNXZWJDb3JlU3RyaW5nKG5hbWUpOwogICAgIEZyYW1lKiBjaGlsZCA9IGZyYW1lLT50cmVl KCktPmNoaWxkKHByb3BOYW1lKTsKSW5kZXg6IGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1 bWVudEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERv Y3VtZW50Q3VzdG9tLmNwcAkocmV2aXNpb24gNDMwMTYpCisrKyBiaW5kaW5ncy92OC9jdXN0b20v VjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBA CiAjaW5jbHVkZSAiVjhQcm94eS5oIgogCiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgorI2luY2x1 ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC00OCw4 ICs0OSw5IEBAIE5BTUVEX1BST1BFUlRZX0RFTEVURVIoSFRNTERvY3VtZW50KQogICAgIC8vIE9u bHkgaGFuZGxlIGRvY3VtZW50LmFsbC4gIEluc2VydCB0aGUgbWFya2VyIG9iamVjdCBpbnRvIHRo ZQogICAgIC8vIHNoYWRvdyBpbnRlcm5hbCBmaWVsZCB0byBzaWduYWwgdGhhdCBkb2N1bWVudC5h bGwgaXMgbm8gbG9uZ2VyCiAgICAgLy8gc2hhZG93ZWQuCi0gICAgU3RyaW5nIGtleSA9IHRvV2Vi Q29yZVN0cmluZyhuYW1lKTsKLSAgICBpZiAoa2V5ICE9ICJhbGwiKQorICAgIEF0b21pY1N0cmlu ZyBrZXkgPSB2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0cmluZyhuYW1lKTsKKyAgICBERUZJTkVf U1RBVElDX0xPQ0FMKGNvbnN0IEF0b21pY1N0cmluZywgYWxsLCAoImFsbCIpKTsKKyAgICBpZiAo a2V5ICE9IGFsbCkKICAgICAgICAgcmV0dXJuIGRlbGV0aW9uTm90SGFuZGxlZEJ5SW50ZXJjZXB0 b3IoKTsKIAogICAgIEFTU0VSVChpbmZvLkhvbGRlcigpLT5JbnRlcm5hbEZpZWxkQ291bnQoKSA9 PSBrSFRNTERvY3VtZW50SW50ZXJuYWxGaWVsZENvdW50KTsKQEAgLTYxLDEyICs2MywxMyBAQCBO QU1FRF9QUk9QRVJUWV9ERUxFVEVSKEhUTUxEb2N1bWVudCkKIE5BTUVEX1BST1BFUlRZX0dFVFRF UihIVE1MRG9jdW1lbnQpCiB7CiAgICAgSU5DX1NUQVRTKCJET00uSFRNTERvY3VtZW50Lk5hbWVk UHJvcGVydHlHZXR0ZXIiKTsKLSAgICBBdG9taWNTdHJpbmcga2V5ID0gdG9XZWJDb3JlU3RyaW5n KG5hbWUpOworICAgIEF0b21pY1N0cmluZyBrZXkgPSB2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0 cmluZyhuYW1lKTsKIAogICAgIC8vIFNwZWNpYWwgY2FzZSBmb3IgZG9jdW1lbnQuYWxsLiAgSWYg dGhlIHZhbHVlIGluIHRoZSBzaGFkb3cKICAgICAvLyBpbnRlcm5hbCBmaWVsZCBpcyBub3QgdGhl IG1hcmtlciBvYmplY3QsIHRoZW4gZG9jdW1lbnQuYWxsIGhhcwogICAgIC8vIGJlZW4gdGVtcG9y YXJpbHkgc2hhZG93ZWQgYW5kIHdlIHJldHVybiB0aGUgdmFsdWUuCi0gICAgaWYgKGtleSA9PSAi YWxsIikgeworICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgQXRvbWljU3RyaW5nLCBhbGws ICgiYWxsIikpOworICAgIGlmIChrZXkgPT0gYWxsKSB7CiAgICAgICAgIEFTU0VSVChpbmZvLkhv bGRlcigpLT5JbnRlcm5hbEZpZWxkQ291bnQoKSA9PSBrSFRNTERvY3VtZW50SW50ZXJuYWxGaWVs ZENvdW50KTsKICAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gbWFya2VyID0gaW5mby5Ib2xk ZXIoKS0+R2V0SW50ZXJuYWxGaWVsZChrSFRNTERvY3VtZW50TWFya2VySW5kZXgpOwogICAgICAg ICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSA9IGluZm8uSG9sZGVyKCktPkdldEludGVybmFs RmllbGQoa0hUTUxEb2N1bWVudFNoYWRvd0luZGV4KTsK