252719 2023-02-21 19:27:04 -0800 [Wasm-GC] Air and B3 generate struct.get/set code with wrong offsets 2023-03-20 17:34:01 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247394 1 tjc webkit-unassigned webkit-bug-importer oldest_to_newest 1935710 0 tjc 2023-02-21 19:27:04 -0800 The following test: ``` //@ runWebAssemblySuite("--useWebAssemblyTypedFunctionReferences=true", "--useWebAssemblyGC=true") import * as assert from "../assert.js"; import { compile, instantiate } from "./wast-wrapper.js"; function module(bytes, valid = true) { let buffer = new ArrayBuffer(bytes.length); let view = new Uint8Array(buffer); for (let i = 0; i < bytes.length; ++i) { view[i] = bytes.charCodeAt(i); } return new WebAssembly.Module(buffer); } let iterations = 10; function testIntFields() { let m = instantiate(` (module (type $s (struct (field i32) (field i32))) (func $new (export "new") (result (ref $s)) (struct.new_canon $s (i32.const 1) (i32.const 5))) (func (export "len0") (result i32) (struct.get $s 0 (call $new))) (func (export "len1") (result i32) (struct.get $s 1 (call $new))))`); for (var i = 0; i < 10; i++) { assert.eq(m.exports.len0(), 1); assert.eq(m.exports.len1(), 5); } } testIntFields(); ``` fails, because the `addStructGet` and `addStructSet` methods in `WasmAirIRGeneratorBase.h` emit a load of `s.m_payload.m_storage` (if `s` is the struct object being operated on) followed by a load or store with the offset for the field being read from/written to. This is incorrect because the field offset is relative to `s.m_payload.m_storage.data()`, not `s.m_payload.m_storage`. I'll be submitting a PR. 1935716 1 tjc 2023-02-21 20:02:52 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10490 1937635 2 webkit-bug-importer 2023-02-28 19:28:14 -0800 <rdar://problem/106065099> 1942737 3 ews-feeder 2023-03-20 17:33:45 -0700 Committed 261899@main (2e2ee48591cd): <https://commits.webkit.org/261899@main> Reviewed commits have been landed. Closing PR #10490 and removing active labels.