<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>252683</bug_id>
          
          <creation_ts>2023-02-21 12:51:40 -0800</creation_ts>
          <short_desc>[WPE] Turn off ENABLE_OPENTYPE_MATH</short_desc>
          <delta_ts>2023-02-21 17:10:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=252682</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>fred.wang</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1935586</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-02-21 12:51:40 -0800</bug_when>
    <thetext>ENABLE_OPENTYPE_MATH is confusing. There are two implementations for parsing the OpenType MATH table:

 * WebKit internal implementation, used by WPE, Apple, Windows ports
 * harfbuzz implementation, added in 181910@main, used by GTK

I doubt there&apos;s any good reason for WPE and GTK ports to be different, so WPE should probably use harfbuzz?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1935587</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-02-21 12:54:40 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/10461</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1935589</commentid>
    <comment_count>2</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2023-02-21 12:56:26 -0800</bug_when>
    <thetext>Yes, on ports where HarfBuzz is available we should use HarfBuzz&apos;s implementation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1935667</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-02-21 17:10:29 -0800</bug_when>
    <thetext>Committed 260641@main (0880ca8024e1): &lt;https://commits.webkit.org/260641@main&gt;

Reviewed commits have been landed. Closing PR #10461 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>