<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>252670</bug_id>
          
          <creation_ts>2023-02-21 09:20:08 -0800</creation_ts>
          <short_desc>[GTK] [2.39.90] Fails to build in armel: is_always_lock_free assertion failed</short_desc>
          <delta_ts>2024-04-02 12:03:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alberto Garcia">berto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>thomas.devoogdt</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1935526</commentid>
    <comment_count>0</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2023-02-21 09:20:08 -0800</bug_when>
    <thetext>What the description says:

            ----------------------------------------
In file included from Source/ThirdParty/ANGLE/src/libANGLE/RefCountObject.h:20,
                 from Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:19,
                 from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/BlitGL.h:15,
                 from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/BlitGL.cpp:9:
Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h:132:37: error: static assertion failed: Must always be lock free
  132 |     static_assert(decltype(mValue)::is_always_lock_free, &quot;Must always be lock free&quot;);
      |                   ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
            ----------------------------------------

The upstream change in ANGLE is this one:

https://github.com/google/angle/commit/ce8ce6f81eff8a84e2ea59930cb995b1107181e2

From what I understand this was already broken, it&apos;s just that now it fails at build time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2024719</commentid>
    <comment_count>1</comment_count>
    <who name="Thomas Devoogdt">thomas.devoogdt</who>
    <bug_when>2024-03-29 05:50:57 -0700</bug_when>
    <thetext>Hi, 


I saw the same, and filled an upstream bug report:

https://bugs.chromium.org/p/angleproject/issues/detail?id=8635


Kr,

Thomas Devoogdt</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025353</commentid>
    <comment_count>2</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2024-04-02 05:09:18 -0700</bug_when>
    <thetext>Thanks, it seems to have been fixed there:

https://chromium.googlesource.com/angle/angle/+/321c6b63bebce3f31414d8a53fb2f94b5561b818%5E!/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025378</commentid>
    <comment_count>3</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2024-04-02 07:16:29 -0700</bug_when>
    <thetext>I confirm that WebKitGTK 2.44.0 builds with that patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025453</commentid>
    <comment_count>4</comment_count>
    <who name="Thomas Devoogdt">thomas.devoogdt</who>
    <bug_when>2024-04-02 11:27:51 -0700</bug_when>
    <thetext>Hi,

I opened a PR to main https://github.com/WebKit/WebKit/pull/26645.

Kr,

Thomas</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025467</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2024-04-02 12:03:26 -0700</bug_when>
    <thetext>Fixed in 2.44.

I see it&apos;s also fixed upstream and we should have many ANGLE updates prior to 2.46, so closing.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>