252651 2023-02-20 22:40:19 -0800 Don't initialize signal handing machinery if we're not going to use it. 2023-02-21 14:03:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=252688 InRadar P2 Normal --- 1 mark.lam mark.lam fujii webkit-bug-importer oldest_to_newest 1935418 0 mark.lam 2023-02-20 22:40:19 -0800 This saves some memory when the signal handling machinery is not needed. 1935419 1 webkit-bug-importer 2023-02-20 22:40:51 -0800 <rdar://problem/105712893> 1935420 2 mark.lam 2023-02-20 23:02:41 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10431 1935576 3 ews-feeder 2023-02-21 12:16:40 -0800 Committed 260623@main (0051847d2a39): <https://commits.webkit.org/260623@main> Reviewed commits have been landed. Closing PR #10431 and removing active labels. 1935605 4 fujii 2023-02-21 13:43:43 -0800 WinCairo gets broken. https://ews-build.webkit.org/#/builders/12/builds/118124 > C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(124): error C3861: 'initializeSignalHandling': identifier not found > C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(131): error C3861: 'disableSignalHandling': identifier not found 1935616 5 mark.lam 2023-02-21 14:03:43 -0800 (In reply to Fujii Hironori from comment #4) > WinCairo gets broken. > https://ews-build.webkit.org/#/builders/12/builds/118124 > > C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(124): error C3861: 'initializeSignalHandling': identifier not found > > C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(131): error C3861: 'disableSignalHandling': identifier not found WinCairo build fix in https://bugs.webkit.org/show_bug.cgi?id=252688.