25261 2009-04-16 21:37:24 -0700 Implement DOMWindow.event as a custom binding in V8 2009-04-20 08:27:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eroman eroman ager dglazkov mbelshe oldest_to_newest 117877 0 eroman 2009-04-16 21:37:24 -0700 With change <http://trac.webkit.org/changeset/42430>, the "event" attribute got moved into DOMWindow.idl. Before it was coded in JSDOMWindowBase (and in the case of v8 bindings, V8AbstractEventListener). This bug is about updating the V8 bindings to work with the new idl. This change should also fix two flaws in the current V8 bindings on "event": - The "event" attribute should not be exposed to workers (just DOMWindow) - It should be possible to shadow "window.event" Patch coming soon. 117962 1 29587 eroman 2009-04-17 13:08:22 -0700 Created attachment 29587 Move handling of DOMWindow.event to custom getter 118116 2 29587 dglazkov 2009-04-20 08:20:15 -0700 Comment on attachment 29587 Move handling of DOMWindow.event to custom getter Thanks for doing this! 118120 3 dglazkov 2009-04-20 08:27:51 -0700 Landed as http://trac.webkit.org/changeset/42671. 29587 2009-04-17 13:08:22 -0700 2009-04-20 08:20:15 -0700 Move handling of DOMWindow.event to custom getter v8-binding-event-v1.patch text/plain 4491 eroman SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjYwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMTYgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBmb3IgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTI2MT4uIElt cGxlbWVudCB0aGUgVjggYmluZGluZyBmb3IgRE9NV2luZG93LmV2ZW50IHNpbWlsYXJseSB0byBK U0MsIGJ5IHVzaW5nIHRoZSBjdXN0b20gZ2V0dGVyIGJvaWxlcnBsYXRlIGZyb20gdGhlIElETCBm aWxlLiBBbHNvIHN0dWIgb3V0IERPTVdpbmRvdy5jcnlwdG8gd2hpY2ggaXMgZGVmaW5lZCBieSB0 aGUgaWRsLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6Omludm9rZUV2 ZW50SGFuZGxlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFDQ0VTU09SX0dFVFRFUik6CisKIDIwMDktMDQt MTYgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFj dEV2ZW50TGlzdGVuZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhB YnN0cmFjdEV2ZW50TGlzdGVuZXIuY3BwCShyZXZpc2lvbiA0MjYwMikKKysrIFdlYkNvcmUvYmlu ZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01 NywyNyArNTcsMjEgQEAgVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OlY4QWJzdHJhY3RFdmVudAog CiB2b2lkIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjppbnZva2VFdmVudEhhbmRsZXIodjg6Okhh bmRsZTx2ODo6Q29udGV4dD4gY29udGV4dCwgRXZlbnQqIGV2ZW50LCB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4ganNFdmVudCwgYm9vbCBpc1dpbmRvd0V2ZW50KQogewotICAgIC8vIEZvciBjb21wYXRp YmlsaXR5LCB3ZSBzdG9yZSB0aGUgZXZlbnQgb2JqZWN0IGFzIGEgcHJvcGVydHkgb24gdGhlIHdp bmRvdyBjYWxsZWQgImV2ZW50Ii4gIEJlY2F1c2UgdGhpcyBpcyB0aGUgZ2xvYmFsIG5hbWVzcGFj ZSwgd2Ugc2F2ZSBhd2F5IGFueQotICAgIC8vIGV4aXN0aW5nICJldmVudCIgcHJvcGVydHksIGFu ZCB0aGVuIHJlc3RvcmUgaXQgYWZ0ZXIgZXhlY3V0aW5nIHRoZSBqYXZhc2NyaXB0IGhhbmRsZXIu CisgICAgLy8gV2UgcHVzaCB0aGUgZXZlbnQgYmVpbmcgcHJvY2Vzc2VkIGludG8gdGhlIGdsb2Jh bCBvYmplY3QsIHNvIHRoYXQgaXQgY2FuIGJlIGV4cG9zZWQgYnkgRE9NV2luZG93J3MgYmluZGlu Z3MuCiAgICAgdjg6OkxvY2FsPHY4OjpTdHJpbmc+IGV2ZW50U3ltYm9sID0gdjg6OlN0cmluZzo6 TmV3U3ltYm9sKCJldmVudCIpOwogICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHJldHVyblZhbHVl OwogCiAgICAgewogICAgICAgICAvLyBDYXRjaCBleGNlcHRpb25zIHRocm93biBpbiB0aGUgZXZl bnQgaGFuZGxlciBzbyB0aGV5IGRvIG5vdCBwcm9wYWdhdGUgdG8gamF2YXNjcmlwdCBjb2RlIHRo YXQgY2F1c2VkIHRoZSBldmVudCB0byBmaXJlLgotICAgICAgICAvLyBTZXR0aW5nIGFuZCBnZXR0 aW5nIHRoZSAnZXZlbnQnIHByb3BlcnR5IG9uIHRoZSBnbG9iYWwgb2JqZWN0IGNhbiB0aHJvdyBl eGNlcHRpb25zIGFzIHdlbGwgKGZvciBpbnN0YW5jZSBpZiBhY2Nlc3NvcnMgdGhhdAotICAgICAg ICAvLyB0aHJvdyBleGNlcHRpb25zIGFyZSBkZWZpbmVkIGZvciAnZXZlbnQnIHVzaW5nIF9fZGVm aW5lR2V0dGVyX18gYW5kIF9fZGVmaW5lU2V0dGVyX18gb24gdGhlIGdsb2JhbCBvYmplY3QpLgog ICAgICAgICB2ODo6VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CiAgICAgICAgIHRyeUNhdGNoLlNldFZlcmJv c2UodHJ1ZSk7CiAKICAgICAgICAgLy8gU2F2ZSB0aGUgb2xkICdldmVudCcgcHJvcGVydHkgc28g d2UgY2FuIHJlc3RvcmUgaXQgbGF0ZXIuCi0gICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHNh dmVkRXZlbnQgPSBjb250ZXh0LT5HbG9iYWwoKS0+R2V0KGV2ZW50U3ltYm9sKTsKKyAgICAgICAg djg6OkxvY2FsPHY4OjpWYWx1ZT4gc2F2ZWRFdmVudCA9IGNvbnRleHQtPkdsb2JhbCgpLT5HZXRI aWRkZW5WYWx1ZShldmVudFN5bWJvbCk7CiAgICAgICAgIHRyeUNhdGNoLlJlc2V0KCk7CiAKLSAg ICAgICAgLy8gTWFrZSB0aGUgZXZlbnQgYXZhaWxhYmxlIGluIHRoZSB3aW5kb3cgb2JqZWN0Lgot ICAgICAgICAvLwotICAgICAgICAvLyBGSVhNRTogVGhpcyBkb2VzIG5vdCB3b3JrIGFzIGl0IGRv ZXMgd2l0aCBqc2MgYmluZGluZ3MgaWYgdGhlIHdpbmRvdy5ldmVudCBwcm9wZXJ0eSBpcyBhbHJl YWR5IHNldC4gV2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBwcm9wZXJ0eQotICAgICAgICAvLyBh Y2Nlc3MgaXMgaW50ZXJjZXB0ZWQgY29ycmVjdGx5LgotICAgICAgICBjb250ZXh0LT5HbG9iYWwo KS0+U2V0KGV2ZW50U3ltYm9sLCBqc0V2ZW50KTsKKyAgICAgICAgLy8gTWFrZSB0aGUgZXZlbnQg YXZhaWxhYmxlIGluIHRoZSBnbG9iYWwgb2JqZWN0LCBzbyBET01XaW5kb3cgY2FuIGV4cG9zZSBp dC4KKyAgICAgICAgY29udGV4dC0+R2xvYmFsKCktPlNldEhpZGRlblZhbHVlKGV2ZW50U3ltYm9s LCBqc0V2ZW50KTsKICAgICAgICAgdHJ5Q2F0Y2guUmVzZXQoKTsKIAogICAgICAgICAvLyBDYWxs IHRoZSBldmVudCBoYW5kbGVyLgpAQCAtODYsOSArODAsOSBAQCB2b2lkIFY4QWJzdHJhY3RFdmVu dExpc3RlbmVyOjppbnZva2VFdmVuCiAKICAgICAgICAgLy8gUmVzdG9yZSB0aGUgb2xkIGV2ZW50 LiBUaGlzIG11c3QgYmUgZG9uZSBmb3IgYWxsIGV4aXQgcGF0aHMgdGhyb3VnaCB0aGlzIG1ldGhv ZC4KICAgICAgICAgaWYgKHNhdmVkRXZlbnQuSXNFbXB0eSgpKQotICAgICAgICAgICAgY29udGV4 dC0+R2xvYmFsKCktPlNldChldmVudFN5bWJvbCwgdjg6OlVuZGVmaW5lZCgpKTsKKyAgICAgICAg ICAgIGNvbnRleHQtPkdsb2JhbCgpLT5TZXRIaWRkZW5WYWx1ZShldmVudFN5bWJvbCwgdjg6OlVu ZGVmaW5lZCgpKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgY29udGV4dC0+R2xvYmFsKCkt PlNldChldmVudFN5bWJvbCwgc2F2ZWRFdmVudCk7CisgICAgICAgICAgICBjb250ZXh0LT5HbG9i YWwoKS0+U2V0SGlkZGVuVmFsdWUoZXZlbnRTeW1ib2wsIHNhdmVkRXZlbnQpOwogICAgICAgICB0 cnlDYXRjaC5SZXNldCgpOwogICAgIH0KIApJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhET01XaW5kb3dDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAkocmV2aXNpb24gNDI2MDIpCisrKyBXZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTUzLDYgKzUzLDIyIEBAIHN0YXRpYyBjb25zdCBpbnQgcG9wdXBUaWxlUGl4ZWxzID0g MTA7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorQUNDRVNTT1JfR0VUVEVSKERPTVdpbmRvd0V2 ZW50KQoreworICAgIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBldmVudFN5bWJvbCA9IHY4OjpTdHJp bmc6Ok5ld1N5bWJvbCgiZXZlbnQiKTsKKyAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRl eHQgPSB2ODo6Q29udGV4dDo6R2V0Q3VycmVudCgpOworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBqc0V2ZW50ID0gY29udGV4dC0+R2xvYmFsKCktPkdldEhpZGRlblZhbHVlKGV2ZW50U3ltYm9s KTsKKyAgICBpZiAoanNFdmVudC5Jc0VtcHR5KCkpCisgICAgICAgIHJldHVybiB2ODo6VW5kZWZp bmVkKCk7CisgICAgcmV0dXJuIGpzRXZlbnQ7Cit9CisKK0FDQ0VTU09SX0dFVFRFUihET01XaW5k b3dDcnlwdG8pCit7CisgICAgLy8gVE9ETzogSW1wbGVtZW50IG1lLgorICAgIHJldHVybiB2ODo6 VW5kZWZpbmVkKCk7Cit9CisKIEFDQ0VTU09SX1NFVFRFUihET01XaW5kb3dMb2NhdGlvbikKIHsK ICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGhvbGRlciA9IFY4UHJveHk6Okxvb2t1cERPTVdy YXBwZXIoVjhDbGFzc0luZGV4OjpET01XSU5ET1csIGluZm8uVGhpcygpKTsK