25259 2009-04-16 18:30:33 -0700 AX: VoiceOver cmd-cntl-space does not follow the google.com->more link 2009-04-17 09:00:36 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach webkit-unassigned oldest_to_newest 117861 0 cfleizach 2009-04-16 18:30:33 -0700 The more link in google.com does not change the AXChildren and show the now visible links 117865 1 29569 cfleizach 2009-04-16 19:31:45 -0700 Created attachment 29569 patch to fix accessibility problem with invisible elements 117895 2 29569 darin 2009-04-17 05:17:12 -0700 Comment on attachment 29569 patch to fix accessibility problem with invisible elements > + bool visibilityChanged = (m_style->visibility() != newStyle->visibility() || > + m_style->zIndex() != newStyle->zIndex() || > + m_style->hasAutoZIndex() != newStyle->hasAutoZIndex()); The formatting here retains strange indenting and parentheses from the if statement. I would use this format: bool visibilityChanged = m_style->visibility() != newStyle->visibility() || m_style->zIndex() != newStyle->zIndex() || m_style->hasAutoZIndex() != newStyle->hasAutoZIndex(); Partly this is because I prefer the "operators at beginning of line" style because I think it makes it clearer that subsequent lines are continuations of the expression. And partly because I think the entire expression is easier to read if we don't do excessive indentation. r=me 117915 3 cfleizach 2009-04-17 09:00:36 -0700 http://trac.webkit.org/changeset/42611 29569 2009-04-16 19:31:45 -0700 2009-04-17 05:17:12 -0700 patch to fix accessibility problem with invisible elements patch.txt text/plain 4800 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjYwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDQtMTYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjUyNTk6IEFYOiBWb2ljZU92ZXIgY21kLWNudGwtc3BhY2UgZG9lcyBub3QgZm9sbG93 IHRoZSBnb29nbGUuY29tLT5tb3JlIGxpbmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI1MjU5CisgIAorICAgICAgICBXaGVuIGEgbm9kZSBiZWNvbWVz IHZpc2libGUgb3IgaGlkZGVuLCBhY2Nlc3NpYmlsaXR5IG5lZWRzIHRvIGJlIHRvbGQgdG8gdXBk YXRlLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvdmlzaWJsZS1lbGVtZW50cy5odG1s CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck9iamVjdDo6c3R5bGVXaWxsQ2hhbmdlKToKKwogMjAwOS0wNC0xNiAgS2V2aW4g V2F0dGVycyAgPGtldmlud2F0dGVyc0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2V2aW4gT2xsaXZpZXIuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlz aW9uIDQyNTk5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTU0NiwxMiArMTU0NiwxNSBAQCB2b2lkIFJlbmRlck9iamVjdDo6c3R5bGVX aWxsQ2hhbmdlKFN0eWxlCiAgICAgICAgIC8vIElmIG91ciB6LWluZGV4IGNoYW5nZXMgdmFsdWUg b3Igb3VyIHZpc2liaWxpdHkgY2hhbmdlcywKICAgICAgICAgLy8gd2UgbmVlZCB0byBkaXJ0eSBv dXIgc3RhY2tpbmcgY29udGV4dCdzIHotb3JkZXIgbGlzdC4KICAgICAgICAgaWYgKG5ld1N0eWxl KSB7CisgICAgICAgICAgICBib29sIHZpc2liaWxpdHlDaGFuZ2VkID0gKG1fc3R5bGUtPnZpc2li aWxpdHkoKSAhPSBuZXdTdHlsZS0+dmlzaWJpbGl0eSgpIHx8CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG1fc3R5bGUtPnpJbmRleCgpICE9IG5ld1N0eWxlLT56 SW5kZXgoKSB8fAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBt X3N0eWxlLT5oYXNBdXRvWkluZGV4KCkgIT0gbmV3U3R5bGUtPmhhc0F1dG9aSW5kZXgoKSk7CiAj aWYgRU5BQkxFKERBU0hCT0FSRF9TVVBQT1JUKQotICAgICAgICAgICAgaWYgKG1fc3R5bGUtPnZp c2liaWxpdHkoKSAhPSBuZXdTdHlsZS0+dmlzaWJpbGl0eSgpIHx8Ci0gICAgICAgICAgICAgICAg ICAgIG1fc3R5bGUtPnpJbmRleCgpICE9IG5ld1N0eWxlLT56SW5kZXgoKSB8fAotICAgICAgICAg ICAgICAgICAgICBtX3N0eWxlLT5oYXNBdXRvWkluZGV4KCkgIT0gbmV3U3R5bGUtPmhhc0F1dG9a SW5kZXgoKSkKKyAgICAgICAgICAgIGlmICh2aXNpYmlsaXR5Q2hhbmdlZCkKICAgICAgICAgICAg ICAgICBkb2N1bWVudCgpLT5zZXREYXNoYm9hcmRSZWdpb25zRGlydHkodHJ1ZSk7CiAjZW5kaWYK KyAgICAgICAgICAgIGlmICh2aXNpYmlsaXR5Q2hhbmdlZCAmJiBBWE9iamVjdENhY2hlOjphY2Nl c3NpYmlsaXR5RW5hYmxlZCgpKQorICAgICAgICAgICAgICAgIGRvY3VtZW50KCktPmF4T2JqZWN0 Q2FjaGUoKS0+Y2hpbGRyZW5DaGFuZ2VkKHRoaXMpOwogCiAgICAgICAgICAgICAvLyBLZWVwIGxh eWVyIGhpZXJhcmNoeSB2aXNpYmlsaXR5IGJpdHMgdXAgdG8gZGF0ZSBpZiB2aXNpYmlsaXR5IGNo YW5nZXMuCiAgICAgICAgICAgICBpZiAobV9zdHlsZS0+dmlzaWJpbGl0eSgpICE9IG5ld1N0eWxl LT52aXNpYmlsaXR5KCkpIHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQyNjAxKQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDQtMTYg IENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IGZvcgorICAgICAgICBCdWcgMjUy NTk6IEFYOiBWb2ljZU92ZXIgY21kLWNudGwtc3BhY2UgZG9lcyBub3QgZm9sbG93IHRoZSBnb29n bGUuY29tLT5tb3JlIGxpbmsgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNTI1OQorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS92aXNpYmxlLWVsZW1l bnRzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS92aXNpYmxl LWVsZW1lbnRzLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA0LTE2ICBKdXN0aW4gR2FyY2lhICA8anVz dGluLmdhcmNpYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVp bi4KSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdmlzaWJsZS1lbGVtZW50cy1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS92aXNpYmxl LWVsZW1lbnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvdmlzaWJsZS1lbGVtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMyBAQAorbW9yZQoraGVsbG8KK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvdmlzaWJsZS1lbGVtZW50cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Fj Y2Vzc2liaWxpdHkvdmlzaWJsZS1lbGVtZW50cy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS92aXNpYmxlLWVsZW1lbnRzLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsNDAgQEAKKzxodG1sPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CisKKzwvc2NyaXB0PgorPGJvZHkgaWQ9ImJvZHkiPgorICAgIDwhLS0gVGhpcyB0ZXN0IGVuc3Vy ZXMgdGhhdCBhIHBsdWdpbiB0aGF0IGlzIG5vdCBhY2Nlc3NpYmxlLCB3aWxsIG5vdCBhcHBlYXIg aW4gdGhlIEFYIGhpZXJhY2h5LS0+CisKKyAgICA8YSBocmVmPSIjYSI+bW9yZTwvYT48QlI+Cisg ICAgPGRpdiBpZD0iaGlkZGVuRGl2IiBzdHlsZT0idmlzaWJpbGl0eTogaGlkZGVuOyBsZWZ0OiAw cHg7ICI+PGEgaHJlZj0iI2IiPmhlbGxvPC9hPjwvZGl2PgorICAgIAorICAgIDxkaXYgaWQ9InJl c3VsdCI+PC9kaXY+CisKKyAgICAgCisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy5h Y2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworICAgICAgICAgICAgdmFyIHJlc3VsdCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKKworICAgICAgICAgICAgdmFyIGJvZHkgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYm9keSIpOworICAgICAgICAgICAgYm9keS5mb2N1cygp OworICAgICAgICAgICAgdmFyIGxpbmtzMSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3Vz ZWRFbGVtZW50LmF0dHJpYnV0ZXNPZkRvY3VtZW50TGlua3MoKTsKKyAKKyAgICAgICAgICAgIC8v IHRvZ2dsZSB0aGUgZGl2CisgICAgICAgICAgICB2YXIgZGl2RWxlbWVudCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJoaWRkZW5EaXYiKTsKKyAgICAgICAgICAgIGRpdkVsZW1lbnQuc3R5bGUu dmlzaWJpbGl0eSA9ICJ2aXNpYmxlIjsKKworICAgICAgICAgICAgYWNjZXNzaWJpbGl0eUNvbnRy b2xsZXIuZm9jdXNlZEVsZW1lbnQuYXR0cmlidXRlc09mQ2hpbGRyZW4oKTsKKyAgICAgICAgICAg IHZhciBsaW5rczIgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5hdHRy aWJ1dGVzT2ZEb2N1bWVudExpbmtzKCk7CisgICAgICAgICAgICBpZiAobGlua3MxICE9IGxpbmtz MikgeworICAgICAgICAgICAgICAgIHJlc3VsdC5pbm5lckhUTUwgKz0gIlBBU1MiOworICAgICAg ICAgICAgfQorICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgcmVzdWx0LmlubmVy SFRNTCArPSAiRkFJTCAtIFRoZSBkaXYncyB2aXNpYmlsaXR5IHdhcyB0b2dnbGVkLCBidXQgdGhl IG5ldyBsaW5rIGRpZCBub3QgYXBwZWFyXG5cbiI7CisgICAgICAgICAgICAgICAgcmVzdWx0Lmlu bmVySFRNTCArPSAiTGlua3MxOiAiICsgbGlua3MxICsgIlxuXG5MaW5rczI6ICIgKyBsaW5rczIg KyAiXG5cbiI7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K