<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>252562</bug_id>
          
          <creation_ts>2023-02-20 06:22:21 -0800</creation_ts>
          <short_desc>[GLib] Installed API headers are unusable with the new 2022 API</short_desc>
          <delta_ts>2023-02-20 08:19:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>210100</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1935063</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-02-20 06:22:21 -0800</bug_when>
    <thetext>Trying to build a recent Epiphany from Git in a clean chroot, after
bulding WebKitGTK with:

  cmake -DPORT=GTK -DUSE_GTK4=ON ...

The when building Epiphany, we get the following error:

[13/277] Compiling C object embed/libephyembed.a.p/ephy-web-view.c.o
FAILED: embed/libephyembed.a.p/ephy-web-view.c.o
ccache cc -Iembed/libephyembed.a.p -Iembed -I../embed -I. -I.. -Ilib -I../lib -I../lib/contrib -I../lib/history -Ilib/sync -I../lib/sync -I../lib/safe-browsing -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gsettings-desktop-schemas -I/usr/include/gtk-4.0 -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/graphene-1.0 -I/usr/lib/graphene-1.0/include -I/usr/include/json-glib-1.0 -I/usr/include/libadwaita-1 -I/usr/include/libsecret-1 -I/usr/include/tss2 -I/usr/include/libsoup-3.0 -I/usr/include/libxml2 -I/home/aperez/.prefix/wkgtk-trunk/include/webkitgtk-6.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -Werror=declaration -after-statement -Werror=implicit-function-declaration -Wno-cast-function-type -Wno-missing-field-initializers -Wno-unused-parameter -fPIC -mfpmath=sse -msse -msse2 -pthread -mfpmath=sse -msse -msse2 -mfpmath=sse -msse -msse2 -mfpmath=sse -msse -msse2 -MD -MQ embed/libephyembed.a.p/ephy-web-view.c.o -MF embed/libephyembed.a.p/ephy-web-view.c.o.d -o embed/libephyembed.a.p/ephy-web-view.c.o -c ../embed/ephy-web-view.c
In file included from /home/aperez/.prefix/wkgtk-trunk/include/webkitgtk-6.0/webkit/webkit.h:56,
                 from ../embed/ephy-web-view.h:24,
                 from ../embed/ephy-web-view.c:23:
/home/aperez/.prefix/wkgtk-trunk/include/webkitgtk-6.0/webkit/WebKitJavascriptResult.h:31:10: fatal error: JavaScriptCore/JSBase.h: No such file or directory
   31 | #include &lt;JavaScriptCore/JSBase.h&gt;
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~

Indeed, there are headers from the “classic” (non-GLib) API being included:

  % rg -F JavaScriptCore/ ~/.prefix/wkgtk-trunk/include/
  /home/aperez/.prefix/wkgtk-trunk/include/webkitgtk-6.0/webkit/WebKitJavascriptResult.h
  31:// #include &lt;JavaScriptCore/JSBase.h&gt;

  /home/aperez/.prefix/wkgtk-trunk/include/webkitgtk-6.0/webkit/WebKitWebView.h
  61:// #include &lt;JavaScriptCore/JSBase.h&gt;
  %

These includes should not be there with the 2022 API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1935066</commentid>
    <comment_count>1</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-02-20 06:28:28 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/10362</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1935091</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-02-20 08:18:12 -0800</bug_when>
    <thetext>Committed 260537@main (5f8dc9d4cc01): &lt;https://commits.webkit.org/260537@main&gt;

Reviewed commits have been landed. Closing PR #10362 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1935092</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-02-20 08:19:18 -0800</bug_when>
    <thetext>&lt;rdar://problem/105680125&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>