<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>252516</bug_id>
          
          <creation_ts>2023-02-17 18:06:46 -0800</creation_ts>
          <short_desc>Import wpt /css/css-tables WPT Tests from upstream</short_desc>
          <delta_ts>2023-05-25 14:32:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=256040</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=257336</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Karl Dubost">karlcow</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>jenner</cc>
    
    <cc>ntim</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1934795</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-02-17 18:06:46 -0800</bug_when>
    <thetext>Hi Team,

I think it would be good idea to bring these tests so we can track any progression and regression in these tests.

I am not sure on how to do it but if someone can point to any guidance, I am happy to do it but meanwhile I would need someone else help.

Just raising this bug for tracking purposes.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1934851</commentid>
    <comment_count>1</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-02-18 00:03:48 -0800</bug_when>
    <thetext>Here are the steps to do a WPT import:

1. Run `import-w3c-tests -t web-platform-tests/css/css-tables`
2. `run-webkit-tests imported/w3c/web-platform-tests/css/css-tables` to generate test expectations as needed.
3. Mark expectations as needed in `LayoutTests/TestExpectations`</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1936707</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-02-24 18:07:18 -0800</bug_when>
    <thetext>&lt;rdar://problem/105909906&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1955663</commentid>
    <comment_count>3</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-05-16 07:37:21 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/13920</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1955669</commentid>
    <comment_count>4</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-05-16 08:00:50 -0700</bug_when>
    <thetext>This should help with Bug 256040</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1956376</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-18 20:35:20 -0700</bug_when>
    <thetext>Committed 264228@main (746ac181da01): &lt;https://commits.webkit.org/264228@main&gt;

Reviewed commits have been landed. Closing PR #13920 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958016</commentid>
    <comment_count>6</comment_count>
    <who name="Robert Jenner">jenner</who>
    <bug_when>2023-05-25 14:18:18 -0700</bug_when>
    <thetext>I am reopening to make an adjustment to the expectations that have been set for the following four tests introduced in this bug:

imported/w3c/web-platform-tests/css/css-tables/calc-percent-plus-0px-auto.html
imported/w3c/web-platform-tests/css/css-tables/calc-percent-plus-0px-fixed.html
imported/w3c/web-platform-tests/css/css-tables/col-definite-max-size-001.html
imported/w3c/web-platform-tests/css/css-tables/col-definite-size-001.html


Current expectation is [ Crash ] but it looks like it should be [ Crash ImageOnlyFailure ]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958021</commentid>
    <comment_count>7</comment_count>
    <who name="Robert Jenner">jenner</who>
    <bug_when>2023-05-25 14:21:21 -0700</bug_when>
    <thetext>https://results.webkit.org/?suite=layout-tests&amp;suite=layout-tests&amp;suite=layout-tests&amp;suite=layout-tests&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-tables%2Fcalc-percent-plus-0px-auto.html&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-tables%2Fcalc-percent-plus-0px-fixed.html&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-tables%2Fcol-definite-max-size-001.html&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-tables%2Fcol-definite-size-001.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1958028</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-25 14:27:19 -0700</bug_when>
    <thetext>Test gardening commit 264540@main (ff075b09d12b): &lt;https://commits.webkit.org/264540@main&gt;

Reviewed commits have been landed. Closing PR #14367 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>