25251 2009-04-16 16:03:18 -0700 Crash when frame creation removes it from the parent 2009-04-17 11:47:48 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 117830 0 gustavo 2009-04-16 16:03:18 -0700 This is tested by the fast/loader/frame-creation-removal.html layout test. After 35088 our port has mostly adapted to the new requirements, but not all. We were still not checking for the frame being removed from the parent after init, and before loadURLIntoChildFrame. 117835 1 29561 gustavo 2009-04-16 16:20:43 -0700 Created attachment 29561 fix crash in fast/loader/frame-creation-removal.html WebKit/gtk/ChangeLog | 16 ++++++++++++++++ WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp | 6 ++++++ 2 files changed, 22 insertions(+), 0 deletions(-) 117920 2 29561 ap 2009-04-17 09:55:25 -0700 Comment on attachment 29561 fix crash in fast/loader/frame-creation-removal.html r=me > + // Copied from Mac's FrameLoaderClient I'd suggest omitting this line - this kind of info is best discovered via svn blame and reading ChangeLogs. 117949 3 gustavo 2009-04-17 11:47:48 -0700 Landed as r42617, accepting ap's suggestion, thanks! 29561 2009-04-16 16:20:43 -0700 2009-04-17 09:55:25 -0700 fix crash in fast/loader/frame-creation-removal.html fix-crash-in-fast-loader-frame-creation-removal.html.patch text/plain 1760 gustavo YTQ1ZDkxNjFlYmI4MDk4ZDZmMmNlNjYxZWFhNjBhMjFkMzY2NmZjMgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA4NGQyOTQ1Li4w MTc0NzJhIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTA0LTE2ICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTI1MQorICAgICAgICBDcmFzaCB3 aGVuIGZyYW1lIGNyZWF0aW9uIHJlbW92ZXMgaXQgZnJvbSB0aGUgcGFyZW50CisKKyAgICAgICAg VGhpcyBicmluZ3MgdXMgdXAtdG8tZGF0ZSB3aXRoIHRoZSBleHBlY3RhdGlvbnMgb2Ygc3ViLWZy YW1lCisgICAgICAgIGNyZWF0aW9uLCBmb2xsb3dpbmcgd2hhdCBNYWMgaGFzIGRvbmUuIEl0IGZp eGVzIGNyYXNoZXMgd2hlbgorICAgICAgICBjYWxsaW5nIGluaXQgb24gdGhlIGNoaWxkIGZyYW1l IHJlbW92ZXMgaXQgZnJvbSB0aGUgcGFnZS4KKworICAgICAgICBUaGlzIG1ha2VzIHRoZSBmb2xs b3dpbmcgdGVzdCBwYXNzIGluc3RlYWQgb2YgY3Jhc2g6CisKKyAgICAgICAgICBmYXN0L2xvYWRl ci9mcmFtZS1jcmVhdGlvbi1yZW1vdmFsLmh0bWwKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJD bGllbnQ6OmNyZWF0ZUZyYW1lKToKKwogMjAwOS0wNC0xNCAgR3VzdGF2byBOb3JvbmhhIFNpbHZh ICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBVbnJldmlld2Vk LiBVcGRhdGUgZ3RrLWRvYyBjb250cm9sIGFuZCBiYXNlIHNnbWwgZmlsZXMgZm9yIDEuMS41Lgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0 ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNw cAppbmRleCA5N2MzZWIyLi5hNTI3M2I2IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcApAQCAtNDM4LDYgKzQzOCwxMiBAQCBQYXNz UmVmUHRyPEZyYW1lPiBGcmFtZUxvYWRlckNsaWVudDo6Y3JlYXRlRnJhbWUoY29uc3QgS1VSTCYg dXJsLCBjb25zdCBTdHJpbmcmCiAKICAgICBjaGlsZEZyYW1lLT50cmVlKCktPnNldE5hbWUobmFt ZSk7CiAgICAgY2hpbGRGcmFtZS0+aW5pdCgpOworCisgICAgLy8gVGhlIGNyZWF0aW9uIG9mIHRo ZSBmcmFtZSBtYXkgaGF2ZSBydW4gYXJiaXRyYXJ5IEphdmFTY3JpcHQgdGhhdCByZW1vdmVkIGl0 IGZyb20gdGhlIHBhZ2UgYWxyZWFkeS4KKyAgICAvLyBDb3BpZWQgZnJvbSBNYWMncyBGcmFtZUxv YWRlckNsaWVudAorICAgIGlmICghY2hpbGRGcmFtZS0+cGFnZSgpKQorICAgICAgICByZXR1cm4g MDsKKwogICAgIGNoaWxkRnJhbWUtPmxvYWRlcigpLT5sb2FkVVJMSW50b0NoaWxkRnJhbWUodXJs LCByZWZlcnJlciwgY2hpbGRGcmFtZS5nZXQoKSk7CiAKICAgICAvLyBUaGUgZnJhbWUncyBvbmxv YWQgaGFuZGxlciBtYXkgaGF2ZSByZW1vdmVkIGl0IGZyb20gdGhlIGRvY3VtZW50Lgo=