252368 2023-02-15 18:09:58 -0800 [IFC][Partial layout] LineLayout::layout should not destroy inline display content on partial layout 2023-02-17 09:05:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1934039 0 zalan 2023-02-15 18:09:58 -0800 ssia 1934040 1 465015 zalan 2023-02-15 18:12:36 -0800 Created attachment 465015 Patch 1934162 2 465015 koivisto 2023-02-16 07:16:40 -0800 Comment on attachment 465015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465015&action=review > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:533 > + // FIXME: Partial layout should not rely on inline display content, but instead InlineFormattingState > + // should retain all the pieces of data required -and then we can destroy damaged content here instead of after > + // layout in constructContent. good plan 1934367 3 465039 zalan 2023-02-16 16:39:53 -0800 Created attachment 465039 Patch 1934637 4 ews-feeder 2023-02-17 09:04:40 -0800 Committed 260448@main (7949435ac60b): <https://commits.webkit.org/260448@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465039. 1934638 5 webkit-bug-importer 2023-02-17 09:05:20 -0800 <rdar://problem/105599284> 465015 2023-02-15 18:12:36 -0800 2023-02-16 16:39:51 -0800 Patch bug-252368-20230215181235.patch text/plain 3687 zalan RnJvbSAzNTdiNzA5MWUwYTQ5ZjU4NjAxZjNmMjUzMmU3MTIxY2M1YjZiNmI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMTUgRmViIDIwMjMgMTg6MTA6MDggLTA4MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVtQ YXJ0aWFsIGxheW91dF0gTGluZUxheW91dDo6bGF5b3V0IHNob3VsZCBub3QgZGVzdHJveQogaW5s aW5lIGRpc3BsYXkgY29udGVudCBvbiBwYXJ0aWFsIGxheW91dAogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MjM2OAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgpUaGlzIGlzIGluIHByZXBhcmF0aW9uIGZvciBzdXBwb3J0aW5nIHBhcnRpYWwgaW5saW5lIGxh eW91dC4KV2hlbiBydW5uaW5nIHBhcnRpYWwgbGF5b3V0LCB0aGUgZGFtYWdlZCBjb250ZW50IGlz IGRlc3Ryb3llZCByaWdodCBiZWZvcmUgd2UgY29uc3RydWN0CnRoZSBuZXcgc2V0IG9mIGlubGlu ZSBkaXNwbGF5IGNvbnRlbnQgKHNlZSBGSVhNRSkuCgoqIFNvdXJjZS9XZWJDb3JlL2xheW91dC9p bnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50QnVpbGRlci5j cHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6SW5saW5lQ29udGVudEJ1aWxkZXI6OmJ1 aWxkIGNvbnN0KToKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xh eW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlv bjo6TGluZUxheW91dDo6bGF5b3V0KToKLS0tCiAuLi4vaW5saW5lL0xheW91dEludGVncmF0aW9u SW5saW5lQ29udGVudEJ1aWxkZXIuY3BwICAgfCAxMCArKysrKysrLS0tCiAuLi4vaW50ZWdyYXRp b24vaW5saW5lL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAgfCAgOCArKysrKystLQog MiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50 ZWdyYXRpb25JbmxpbmVDb250ZW50QnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW50ZWdyYXRpb24vaW5saW5lL0xheW91dEludGVncmF0aW9uSW5saW5lQ29udGVudEJ1aWxkZXIu Y3BwCmluZGV4IDc2MzYyNGYyNDU2My4uMTQwODkwZTY5NGRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xheW91dEludGVncmF0aW9uSW5saW5l Q29udGVudEJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlv bi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50QnVpbGRlci5jcHAKQEAgLTU3 LDkgKzU3LDEzIEBAIElubGluZUNvbnRlbnRCdWlsZGVyOjpJbmxpbmVDb250ZW50QnVpbGRlcihj b25zdCBSZW5kZXJCbG9ja0Zsb3cmIGJsb2NrRmxvdywgQm94CiAKIHZvaWQgSW5saW5lQ29udGVu dEJ1aWxkZXI6OmJ1aWxkKExheW91dDo6SW5saW5lRm9ybWF0dGluZ1N0YXRlJiBpbmxpbmVGb3Jt YXR0aW5nU3RhdGUsIElubGluZUNvbnRlbnQmIGlubGluZUNvbnRlbnQpIGNvbnN0CiB7Ci0gICAg Ly8gRklYTUU6IFRoaXMgbWlnaHQgbmVlZCBhIGRpZmZlcmVudCBhcHByb2FjaCB3aXRoIHBhcnRp YWwgbGF5b3V0IHdoZXJlIHRoZSBsYXlvdXQgY29kZSBuZWVkcyB0byBrbm93IGFib3V0IHRoZSBi b3hlcy4KLSAgICBpbmxpbmVDb250ZW50LmJveGVzID0gV1RGTW92ZShpbmxpbmVGb3JtYXR0aW5n U3RhdGUuYm94ZXMoKSk7Ci0gICAgaW5saW5lQ29udGVudC5saW5lcyA9IFdURk1vdmUoaW5saW5l Rm9ybWF0dGluZ1N0YXRlLmxpbmVzKCkpOworICAgIGlmIChpbmxpbmVDb250ZW50LmJveGVzLmlz RW1wdHkoKSkgeworICAgICAgICBpbmxpbmVDb250ZW50LmJveGVzID0gV1RGTW92ZShpbmxpbmVG b3JtYXR0aW5nU3RhdGUuYm94ZXMoKSk7CisgICAgICAgIGlubGluZUNvbnRlbnQubGluZXMgPSBX VEZNb3ZlKGlubGluZUZvcm1hdHRpbmdTdGF0ZS5saW5lcygpKTsKKyAgICB9IGVsc2UgeworICAg ICAgICBpbmxpbmVDb250ZW50LmJveGVzLmFwcGVuZFZlY3RvcihXVEZNb3ZlKGlubGluZUZvcm1h dHRpbmdTdGF0ZS5ib3hlcygpKSk7CisgICAgICAgIGlubGluZUNvbnRlbnQubGluZXMuYXBwZW5k VmVjdG9yKFdURk1vdmUoaW5saW5lRm9ybWF0dGluZ1N0YXRlLmxpbmVzKCkpKTsKKyAgICB9CiAK ICAgICBhdXRvIHVwZGF0ZUlmVGV4dFJlbmRlcmVyc05lZWRWaXN1YWxSZW9yZGVyaW5nID0gWyZd IHsKICAgICAgICAgLy8gRklYTUU6IFdlIG1heSB3YW50IHRvIGhhdmUgYSBnbG9iYWwsICJpcyB0 aGlzIGEgYmlkaSBwYXJhZ3JhcGgiIGZsYWcgdG8gYXZvaWQgdGhpcyBsb29wIGZvciBub24tcnRs LCBub24tYmlkaSBjb250ZW50LiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5l TGF5b3V0LmNwcAppbmRleCBhMzBkNTAzZDZiYWIuLmY3NTY3ZDYxNzcyNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlv bkxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9p bmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcApAQCAtNTI4LDggKzUyOCwxMiBA QCB2b2lkIExpbmVMYXlvdXQ6OmxheW91dCgpCiAgICAgcHJlcGFyZUxheW91dFN0YXRlKCk7CiAg ICAgcHJlcGFyZUZsb2F0aW5nU3RhdGUoKTsKIAotICAgIC8vIEZJWE1FOiBEbyBub3QgY2xlYXIg dGhlIGxpbmVzIGFuZCBib3hlcyBoZXJlIHVuY29uZGl0aW9uYWxseSwgYnV0IGNvbnN1bHQgd2l0 aCB0aGUgZGFtYWdlIG9iamVjdCBpbnN0ZWFkLgotICAgIGNsZWFySW5saW5lQ29udGVudCgpOwor ICAgIC8vIEZJWE1FOiBQYXJ0aWFsIGxheW91dCBzaG91bGQgbm90IHJlbHkgb24gaW5saW5lIGRp c3BsYXkgY29udGVudCwgYnV0IGluc3RlYWQgSW5saW5lRm9ybWF0dGluZ1N0YXRlCisgICAgLy8g c2hvdWxkIHJldGFpbiBhbGwgdGhlIHBpZWNlcyBvZiBkYXRhIHJlcXVpcmVkIC1hbmQgdGhlbiB3 ZSBjYW4gZGVzdHJveSBkYW1hZ2VkIGNvbnRlbnQgaGVyZSBpbnN0ZWFkIG9mIGFmdGVyCisgICAg Ly8gbGF5b3V0IGluIGNvbnN0cnVjdENvbnRlbnQuCisgICAgYXV0byBpc1BhcnRpYWxMYXlvdXQg PSBtX2xpbmVEYW1hZ2UgJiYgbV9saW5lRGFtYWdlLT5jb250ZW50UG9zaXRpb24oKTsKKyAgICBp ZiAoIWlzUGFydGlhbExheW91dCkKKyAgICAgICAgY2xlYXJJbmxpbmVDb250ZW50KCk7CiAgICAg QVNTRVJUKG1faW5saW5lQ29udGVudENvbnN0cmFpbnRzKTsKICAgICBhdXRvIGludHJ1c2l2ZUlu aXRpYWxMZXR0ZXJCb3R0b20gPSBbJl0oKSAtPiBzdGQ6Om9wdGlvbmFsPExheW91dFVuaXQ+IHsK ICAgICAgICAgaWYgKGF1dG8gbG93ZXN0SW5pdGlhbExldHRlckxvZ2ljYWxCb3R0b20gPSBmbG93 KCkubG93ZXN0SW5pdGlhbExldHRlckxvZ2ljYWxCb3R0b20oKSkK 465039 2023-02-16 16:39:53 -0800 2023-02-17 09:04:41 -0800 Patch bug-252368-20230216163953.patch text/plain 3781 zalan RnJvbSA2OWQyMjM3NTA0YWM1NzBlZmRmZDVhMmQyZjhlYWRmZjJjNDJhYTUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMTUgRmViIDIwMjMgMTg6MTA6MDggLTA4MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVtQ YXJ0aWFsIGxheW91dF0gTGluZUxheW91dDo6bGF5b3V0IHNob3VsZCBub3QgZGVzdHJveQogaW5s aW5lIGRpc3BsYXkgY29udGVudCBvbiBwYXJ0aWFsIGxheW91dAogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MjM2OAoKUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8u CgpUaGlzIGlzIGluIHByZXBhcmF0aW9uIGZvciBzdXBwb3J0aW5nIHBhcnRpYWwgaW5saW5lIGxh eW91dC4KV2hlbiBydW5uaW5nIHBhcnRpYWwgbGF5b3V0LCB0aGUgZGFtYWdlZCBjb250ZW50IGlz IGRlc3Ryb3llZCByaWdodCBiZWZvcmUgd2UgY29uc3RydWN0CnRoZSBuZXcgc2V0IG9mIGlubGlu ZSBkaXNwbGF5IGNvbnRlbnQgKHNlZSBGSVhNRSkuCgoqIFNvdXJjZS9XZWJDb3JlL2xheW91dC9p bnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50QnVpbGRlci5j cHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6SW5saW5lQ29udGVudEJ1aWxkZXI6OmJ1 aWxkIGNvbnN0KToKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xh eW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlv bjo6TGluZUxheW91dDo6bGF5b3V0KToKLS0tCiAuLi4vaW5saW5lL0xheW91dEludGVncmF0aW9u SW5saW5lQ29udGVudEJ1aWxkZXIuY3BwIHwgMTIgKysrKysrKysrLS0tCiAuLi4vaW5saW5lL0xh eW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAgICAgICAgICAgIHwgIDggKysrKysrLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xheW91dEludGVn cmF0aW9uSW5saW5lQ29udGVudEJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu dGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbklubGluZUNvbnRlbnRCdWlsZGVyLmNw cAppbmRleCA3NjM2MjRmMjQ1NjMuLjllMDlhYjAxZTEzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlvbklubGluZUNv bnRlbnRCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24v aW5saW5lL0xheW91dEludGVncmF0aW9uSW5saW5lQ29udGVudEJ1aWxkZXIuY3BwCkBAIC01Nyw5 ICs1NywxNSBAQCBJbmxpbmVDb250ZW50QnVpbGRlcjo6SW5saW5lQ29udGVudEJ1aWxkZXIoY29u c3QgUmVuZGVyQmxvY2tGbG93JiBibG9ja0Zsb3csIEJveAogCiB2b2lkIElubGluZUNvbnRlbnRC dWlsZGVyOjpidWlsZChMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdTdGF0ZSYgaW5saW5lRm9ybWF0 dGluZ1N0YXRlLCBJbmxpbmVDb250ZW50JiBpbmxpbmVDb250ZW50KSBjb25zdAogewotICAgIC8v IEZJWE1FOiBUaGlzIG1pZ2h0IG5lZWQgYSBkaWZmZXJlbnQgYXBwcm9hY2ggd2l0aCBwYXJ0aWFs IGxheW91dCB3aGVyZSB0aGUgbGF5b3V0IGNvZGUgbmVlZHMgdG8ga25vdyBhYm91dCB0aGUgYm94 ZXMuCi0gICAgaW5saW5lQ29udGVudC5ib3hlcyA9IFdURk1vdmUoaW5saW5lRm9ybWF0dGluZ1N0 YXRlLmJveGVzKCkpOwotICAgIGlubGluZUNvbnRlbnQubGluZXMgPSBXVEZNb3ZlKGlubGluZUZv cm1hdHRpbmdTdGF0ZS5saW5lcygpKTsKKyAgICBpZiAoaW5saW5lQ29udGVudC5ib3hlcy5pc0Vt cHR5KCkpIHsKKyAgICAgICAgaW5saW5lQ29udGVudC5ib3hlcyA9IFdURk1vdmUoaW5saW5lRm9y bWF0dGluZ1N0YXRlLmJveGVzKCkpOworICAgICAgICBpbmxpbmVDb250ZW50LmxpbmVzID0gV1RG TW92ZShpbmxpbmVGb3JtYXR0aW5nU3RhdGUubGluZXMoKSk7CisgICAgfSBlbHNlIHsKKyAgICAg ICAgaW5saW5lQ29udGVudC5ib3hlcy5hcHBlbmRWZWN0b3IoV1RGTW92ZShpbmxpbmVGb3JtYXR0 aW5nU3RhdGUuYm94ZXMoKSkpOworICAgICAgICBpbmxpbmVDb250ZW50LmxpbmVzLmFwcGVuZFZl Y3RvcihXVEZNb3ZlKGlubGluZUZvcm1hdHRpbmdTdGF0ZS5saW5lcygpKSk7CisgICAgICAgIGlu bGluZUZvcm1hdHRpbmdTdGF0ZS5ib3hlcygpLmNsZWFyKCk7CisgICAgICAgIGlubGluZUZvcm1h dHRpbmdTdGF0ZS5saW5lcygpLmNsZWFyKCk7CisgICAgfQogCiAgICAgYXV0byB1cGRhdGVJZlRl eHRSZW5kZXJlcnNOZWVkVmlzdWFsUmVvcmRlcmluZyA9IFsmXSB7CiAgICAgICAgIC8vIEZJWE1F OiBXZSBtYXkgd2FudCB0byBoYXZlIGEgZ2xvYmFsLCAiaXMgdGhpcyBhIGJpZGkgcGFyYWdyYXBo IiBmbGFnIHRvIGF2b2lkIHRoaXMgbG9vcCBmb3Igbm9uLXJ0bCwgbm9uLWJpZGkgY29udGVudC4g CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xh eW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50 ZWdyYXRpb24vaW5saW5lL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXggYTMw ZDUwM2Q2YmFiLi5mNzU2N2Q2MTc3MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vaW5saW5lL0xheW91dEludGVncmF0 aW9uTGluZUxheW91dC5jcHAKQEAgLTUyOCw4ICs1MjgsMTIgQEAgdm9pZCBMaW5lTGF5b3V0Ojps YXlvdXQoKQogICAgIHByZXBhcmVMYXlvdXRTdGF0ZSgpOwogICAgIHByZXBhcmVGbG9hdGluZ1N0 YXRlKCk7CiAKLSAgICAvLyBGSVhNRTogRG8gbm90IGNsZWFyIHRoZSBsaW5lcyBhbmQgYm94ZXMg aGVyZSB1bmNvbmRpdGlvbmFsbHksIGJ1dCBjb25zdWx0IHdpdGggdGhlIGRhbWFnZSBvYmplY3Qg aW5zdGVhZC4KLSAgICBjbGVhcklubGluZUNvbnRlbnQoKTsKKyAgICAvLyBGSVhNRTogUGFydGlh bCBsYXlvdXQgc2hvdWxkIG5vdCByZWx5IG9uIGlubGluZSBkaXNwbGF5IGNvbnRlbnQsIGJ1dCBp bnN0ZWFkIElubGluZUZvcm1hdHRpbmdTdGF0ZQorICAgIC8vIHNob3VsZCByZXRhaW4gYWxsIHRo ZSBwaWVjZXMgb2YgZGF0YSByZXF1aXJlZCAtYW5kIHRoZW4gd2UgY2FuIGRlc3Ryb3kgZGFtYWdl ZCBjb250ZW50IGhlcmUgaW5zdGVhZCBvZiBhZnRlcgorICAgIC8vIGxheW91dCBpbiBjb25zdHJ1 Y3RDb250ZW50LgorICAgIGF1dG8gaXNQYXJ0aWFsTGF5b3V0ID0gbV9saW5lRGFtYWdlICYmIG1f bGluZURhbWFnZS0+Y29udGVudFBvc2l0aW9uKCk7CisgICAgaWYgKCFpc1BhcnRpYWxMYXlvdXQp CisgICAgICAgIGNsZWFySW5saW5lQ29udGVudCgpOwogICAgIEFTU0VSVChtX2lubGluZUNvbnRl bnRDb25zdHJhaW50cyk7CiAgICAgYXV0byBpbnRydXNpdmVJbml0aWFsTGV0dGVyQm90dG9tID0g WyZdKCkgLT4gc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiB7CiAgICAgICAgIGlmIChhdXRvIGxv d2VzdEluaXRpYWxMZXR0ZXJMb2dpY2FsQm90dG9tID0gZmxvdygpLmxvd2VzdEluaXRpYWxMZXR0 ZXJMb2dpY2FsQm90dG9tKCkpCg==