252244 2023-02-14 08:40:35 -0800 EWS is not adding merging-blocked label on PRs 2023-03-09 11:16:34 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=253451 InRadar P2 Normal --- 1 rreno jbedard aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1933491 0 rreno 2023-02-14 08:40:35 -0800 My PR https://github.com/WebKit/WebKit/pull/10069 had build failures on Linux and Windows and test failures on all flavors of macOS. I would have expected EWS to put the merging-blocked label on this PR from past experience. This didn't happen. It's somewhat benign - I wouldn't merge this in this state anyway. I wonder if this is a symptom of another underlying problem in EWS though. 1933492 1 webkit-bug-importer 2023-02-14 08:40:49 -0800 <rdar://problem/105452651> 1933864 2 ap 2023-02-15 10:15:34 -0800 Aakash can comment more authoritatively, but I've come to expect issues like this to be caused by web hooks not getting served for whatever reason (networking failures, EWS getting overloaded or being restarted). I wonder if we can make web hook handling more robust in general. 1933875 3 aakash_jain 2023-02-15 10:53:33 -0800 Just for reference here are few builds which failed (and should have added the merging-blocked label): https://ews-build.webkit.org/#/builders/73/builds/28498 https://ews-build.webkit.org/#/builders/70/builds/29847 https://ews-build.webkit.org/#/builders/84/builds/6742 https://ews-build.webkit.org/#/builders/8/builds/116784 https://ews-build.webkit.org/#/builders/36/builds/99807 In all of those, the last step "block-pull-request" was skipped, which means that EWS did not attempted to put the label on PR. It was skipped because EWS thought that the commit was obsolete at that time (because of new push on the PR). Need to check further if that was indeed the case. 1939803 4 aakash_jain 2023-03-08 11:40:34 -0800 We added some more logging in the UI in https://bugs.webkit.org/show_bug.cgi?id=253451 In https://ews-build.webkit.org/#/builders/12/builds/120226 the logging says: "Skipping this step as hash 16e666579113e2e006564ecd5965fd6a9903b06d is outdated." However, that's incorrect, the hash is NOT outdated. Even as of right now, that is the latest hash on that PR (https://github.com/WebKit/WebKit/pull/11089). 1939809 5 aakash_jain 2023-03-08 11:52:06 -0800 The last successful instance of adding merging-blocked label seems to be on Feb 8, 2023 in https://ews-build.webkit.org/#/builders/73/builds/27686 (till feb 8 block-pull-request step was adding adding merging-blocked label on lot of PRs (~100/day), but after that it abruptly stopped. So seems like something regressed around that time. There were few changes landed around that time as well. e.g.: this PR modified _is_hash_outdated method which is being used by block-pull-request: https://github.com/WebKit/WebKit/pull/9554/files 1939837 6 jbedard 2023-03-08 13:39:57 -0800 Pull request: https://github.com/WebKit/WebKit/pull/11253 1940013 7 ews-feeder 2023-03-09 03:59:16 -0800 Committed 261420@main (a2ee6d8fbe53): <https://commits.webkit.org/261420@main> Reviewed commits have been landed. Closing PR #11253 and removing active labels. 1940141 8 aakash_jain 2023-03-09 11:16:15 -0800 buildbot was restarted this morning to pick up this change. 1940142 9 aakash_jain 2023-03-09 11:16:34 -0800 Seems to be working fine. e.g.: merging-blocked label was added in https://ews-build.webkit.org/#/builders/82/builds/13840