25223 2009-04-15 16:29:28 -0700 REGRESSION: Back button after form submission to the same URL fails to navigate 2009-04-24 14:47:55 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED http://www.uni-nets.com/chrometests/brokenforms.php P2 Normal --- 1 fishd fishd oldest_to_newest 117694 0 fishd 2009-04-15 16:29:28 -0700 Back button after form submission to the same URL fails to navigate This has been broken for a while. I can confirm it in Safari 4 beta as well as WebKit nightly r42377. The bug occurs when a form posts to the same URL as the page that contains the form. Upon going back, FrameLoader thinks that it should scroll the page since the URLs match and the page we are going to does not have any FormData. The problem is that it fails to check if the page we are leaving has FormData, which it does in the case I've described. 117695 1 fishd 2009-04-15 16:29:57 -0700 Here's the corresponding Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=8976 117698 2 fishd 2009-04-15 16:51:35 -0700 Chrome 1.0 and Safari 3.2 do not have this bug. 117752 3 29537 fishd 2009-04-16 10:53:45 -0700 Created attachment 29537 v1 patch The fix is a very simple change to FrameLoader. I verified that this does not regress any existing layout tests. However, in order to write a test for this, I discovered a bug in the WorkQueue implementation. This issue is detailed in the WebKitTools/ChangeLog portion of my patch. 117753 4 29538 fishd 2009-04-16 10:58:04 -0700 Created attachment 29538 v2 patch: same as before, but with equivalent changes to win/FrameLoadDelegate.cpp 117903 5 29538 darin 2009-04-17 06:30:50 -0700 Comment on attachment 29538 v2 patch: same as before, but with equivalent changes to win/FrameLoadDelegate.cpp > // We also do not do anchor-style navigation if we're posting a form. > > #if ENABLE(WML) > - if (!formData && urlsMatchItem(item) && !m_frame->document()->isWMLDocument()) { > + if (!formData && !m_currentHistoryItem->formData() && urlsMatchItem(item) && !m_frame->document()->isWMLDocument()) { > #else > - if (!formData && urlsMatchItem(item)) { > + if (!formData && !m_currentHistoryItem->formData() && urlsMatchItem(item)) { > #endif > // Must do this maintenance here, since we don't go through a real page reload > saveScrollPositionAndViewStateToItem(m_currentHistoryItem.get()); It seems that if you're changing the code you also should change the comment before it, which describes the condition in a high-level way. Not your fault, and maybe best to not do this in this patch, but that WMLDocument check is done in a particuarly ugly way. Maybe we could just set up a boolean before the if statement instead of repeating the whole if statement twice. The extra open brace inside an #if also tends to confuse syntax highlighters. > + // if another load started, then wait for it to complete. > + if (topLoadingFrame != nil) > + return; Normally we wouldn't say != nil here. r=me 117964 6 fishd 2009-04-17 13:16:11 -0700 > It seems that if you're changing the code you also should change the comment > before it, which describes the condition in a high-level way. Yes, will do. > Not your fault, and maybe best to not do this in this patch, but that > WMLDocument check is done in a particuarly ugly way. Maybe we could just set up > a boolean before the if statement instead of repeating the whole if statement > twice. The extra open brace inside an #if also tends to confuse syntax > highlighters. I agree. I spent a little time twiddling with this before uploading the patch, but I wasn't happy with the results. This current form is surprisingly readable since the variant is last. That said, duplicating code sucks. I'll change it. > > + // if another load started, then wait for it to complete. > > + if (topLoadingFrame != nil) > > + return; > > Normally we wouldn't say != nil here. Good to know. I'm not very familiar with ObjC coding conventions. 117967 7 fishd 2009-04-17 13:31:52 -0700 Landed as: http://trac.webkit.org/changeset/42623 118740 8 darin 2009-04-24 14:47:55 -0700 Lack of a null check in this patch caused bug 25355. 29537 2009-04-16 10:53:45 -0700 2009-04-16 10:58:04 -0700 v1 patch fix_1.txt text/plain 6235 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjU4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDQtMTYgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUyMjMKKyAgICAgICAgUkVH UkVTU0lPTjogQmFjayBidXR0b24gYWZ0ZXIgZm9ybSBzdWJtaXNzaW9uIHRvIHRoZSBzYW1lIFVS TCBmYWlscyB0byBuYXZpZ2F0ZS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL25hdmlnYXRp b24vcG9zdC1nb2JhY2stc2FtZS11cmwuaHRtbAorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpsb2FkSXRlbSk6IENoZWNr IGlmIHRoZSBwYWdlIHdlIGFyZSBsZWF2aW5nIGhhcworICAgICAgICBGb3JtRGF0YS4KKwogMjAw OS0wNC0xNiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lv biA0MjU2MikKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDQ0Niw5ICs0NDQ2LDkgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZEl0ZW0oSGlzdG9y eUl0ZW0qIAogICAgIC8vIFdlIGFsc28gZG8gbm90IGRvIGFuY2hvci1zdHlsZSBuYXZpZ2F0aW9u IGlmIHdlJ3JlIHBvc3RpbmcgYSBmb3JtLgogICAgIAogI2lmIEVOQUJMRShXTUwpCi0gICAgaWYg KCFmb3JtRGF0YSAmJiB1cmxzTWF0Y2hJdGVtKGl0ZW0pICYmICFtX2ZyYW1lLT5kb2N1bWVudCgp LT5pc1dNTERvY3VtZW50KCkpIHsKKyAgICBpZiAoIWZvcm1EYXRhICYmICFtX2N1cnJlbnRIaXN0 b3J5SXRlbS0+Zm9ybURhdGEoKSAmJiB1cmxzTWF0Y2hJdGVtKGl0ZW0pICYmICFtX2ZyYW1lLT5k b2N1bWVudCgpLT5pc1dNTERvY3VtZW50KCkpIHsKICNlbHNlCi0gICAgaWYgKCFmb3JtRGF0YSAm JiB1cmxzTWF0Y2hJdGVtKGl0ZW0pKSB7CisgICAgaWYgKCFmb3JtRGF0YSAmJiAhbV9jdXJyZW50 SGlzdG9yeUl0ZW0tPmZvcm1EYXRhKCkgJiYgdXJsc01hdGNoSXRlbShpdGVtKSkgewogI2VuZGlm CiAgICAgICAgIC8vIE11c3QgZG8gdGhpcyBtYWludGVuYW5jZSBoZXJlLCBzaW5jZSB3ZSBkb24n dCBnbyB0aHJvdWdoIGEgcmVhbCBwYWdlIHJlbG9hZAogICAgICAgICBzYXZlU2Nyb2xsUG9zaXRp b25BbmRWaWV3U3RhdGVUb0l0ZW0obV9jdXJyZW50SGlzdG9yeUl0ZW0uZ2V0KCkpOwpJbmRleDog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxv ZwkocmV2aXNpb24gNDI1ODApCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNC0xNiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTIyMworICAgICAg ICBSRUdSRVNTSU9OOiBCYWNrIGJ1dHRvbiBhZnRlciBmb3JtIHN1Ym1pc3Npb24gdG8gdGhlIHNh bWUgVVJMIGZhaWxzIHRvIG5hdmlnYXRlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFj L0ZyYW1lTG9hZERlbGVnYXRlLm1tOgorICAgICAgICAoLVtGcmFtZUxvYWREZWxlZ2F0ZSBwcm9j ZXNzV29yazpdKTogTmVlZCB0byBkZWZlciBwcm9jZXNzaW5nIHRoZSB3b3JrCisgICAgICAgIHF1 ZXVlIGlmIGEgbmF2aWdhdGlvbiBzdGFydGVkIGJldHdlZW4gbG9jYXRpb25DaGFuZ2VEb25lIGFu ZCBvdXIKKyAgICAgICAgZGVsYXllZCBwcm9jZXNzV29yayBjYWxsLiAgVGhpcyBjYW4gaGFwcGVu IHdoZW4gdXNpbmcgcXVldWVMb2FkaW5nU2NyaXB0CisgICAgICAgIHRvIGxvYWQgc2NyaXB0IHRo YXQgc2ltdWxhdGVzIGEgY2xpY2sgb24gYSBsaW5rIG9yIHN1Ym1pdCBidXR0b24gc2luY2UKKyAg ICAgICAgdGhvc2UgY2xpY2tzIGhhcHBlbiBhc3luY2hyb25vdXNseS4KKwogMjAwOS0wNC0xNiAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2tpcCB5ZXQgYW5vdGhl ciBKYXZhU2NyaXB0Q29yZSB0ZXN0IHRoYXQgc29tZXRpbWVzIGZhaWxzIG9uIFdpbmRvd3MKSW5k ZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9GcmFtZUxvYWREZWxlZ2F0ZS5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRnJhbWVMb2FkRGVs ZWdhdGUubW0JKHJldmlzaW9uIDQyNTYyKQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv bWFjL0ZyYW1lTG9hZERlbGVnYXRlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEsNiArMTExLDEw IEBACiAvLyBFeGVjIG1lc3NhZ2VzIGluIHRoZSB3b3JrIHF1ZXVlIHVudGlsIHRoZXkncmUgYWxs IGRvbmUsIG9yIG9uZSBvZiB0aGVtIHN0YXJ0cyBhIG5ldyBsb2FkCiAtICh2b2lkKXByb2Nlc3NX b3JrOihpZClkdW1teQogeworICAgIC8vIGlmIGFub3RoZXIgbG9hZCBzdGFydGVkLCB0aGVuIHdh aXQgZm9yIGl0IHRvIGNvbXBsZXRlLgorICAgIGlmICh0b3BMb2FkaW5nRnJhbWUgIT0gbmlsKQor ICAgICAgICByZXR1cm47CisKICAgICAvLyBpZiB3ZSBmaW5pc2ggYWxsIHRoZSBjb21tYW5kcywg d2UncmUgcmVhZHkgdG8gZHVtcCBzdGF0ZQogICAgIGlmIChXb3JrUXVldWU6OnNoYXJlZCgpLT5w cm9jZXNzV29yaygpICYmICFnTGF5b3V0VGVzdENvbnRyb2xsZXItPndhaXRUb0R1bXAoKSkKICAg ICAgICAgZHVtcCgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDI1ODApCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNC0xNiAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNTIyMworICAgICAgICBSRUdSRVNTSU9OOiBCYWNrIGJ1dHRvbiBhZnRlciBmb3Jt IHN1Ym1pc3Npb24gdG8gdGhlIHNhbWUgVVJMIGZhaWxzIHRvIG5hdmlnYXRlLgorCisgICAgICAg ICogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29iYWNrLXNhbWUtdXJsLmh0bWw6IEFkZGVk LgorICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9wb3N0LWdvYmFjay1zYW1lLXVybC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNv dXJjZXMvcG9zdC1nb2JhY2stc2FtZS11cmwucGhwOiBBZGRlZC4KKwogMjAwOS0wNC0xNiAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29i YWNrLXNhbWUtdXJsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL25hdmlnYXRpb24vcG9zdC1nb2JhY2stc2FtZS11cmwtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29iYWNr LXNhbWUtdXJsLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACisgIAor Cis9PT09PT09PT09PT09PSBCYWNrIEZvcndhcmQgTGlzdCA9PT09PT09PT09PT09PQorICAgICAg ICBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9wb3N0LWdvYmFjay1zYW1lLXVybC5o dG1sICAqKm5hdiB0YXJnZXQqKgorY3Vyci0+ICBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdh dGlvbi9yZXNvdXJjZXMvcG9zdC1nb2JhY2stc2FtZS11cmwucGhwICAqKm5hdiB0YXJnZXQqKgor ICAgICAgICBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9yZXNvdXJjZXMvcG9zdC1n b2JhY2stc2FtZS11cmwucGhwICAqKm5hdiB0YXJnZXQqKgorPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMv bmF2aWdhdGlvbi9wb3N0LWdvYmFjay1zYW1lLXVybC5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9wb3N0LWdvYmFjay1zYW1lLXVybC5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29i YWNrLXNhbWUtdXJsLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTkgQEAKKzxodG1sPgor PGhlYWQ+Cis8c2NyaXB0PgorICAgIAoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBCYWNrRm9yd2FyZExpc3QoKTsKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIucXVldWVMb2FkKCJyZXNvdXJjZXMvcG9zdC1nb2JhY2stc2FtZS11cmwucGhwIik7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIucXVldWVMb2FkaW5nU2NyaXB0KCJzdWJtaXRGb3JtKCkiKTsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5xdWV1ZUJhY2tOYXZpZ2F0aW9uKDEpOworfQorICAg IAorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KK2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNTIyMyAtIEJhY2sgYnV0dG9uIGFmdGVyIGZvcm0KK3N1Ym1pc3Npb24g dG8gdGhlIHNhbWUgVVJMIGZhaWxzIHRvIG5hdmlnYXRlCis8L2JvZHk+Cis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL3Bvc3QtZ29iYWNr LXNhbWUtdXJsLnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmln YXRpb24vcmVzb3VyY2VzL3Bvc3QtZ29iYWNrLXNhbWUtdXJsLnBocAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvcG9zdC1nb2JhY2st c2FtZS11cmwucGhwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI2IEBACis8aHRtbD4KKzxoZWFk PgorPHNjcmlwdD4KKworZnVuY3Rpb24gc3VibWl0Rm9ybSgpCit7CisgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3N1Ym1pdCcpLmNsaWNrKCk7Cit9CisKKzwvc2NyaXB0PgorPC9oZWFkPgor PGJvZHk+CisKKzw/CitJRiAoJF9QT1NUWyd0ZXh0ZGF0YSddID09ICJmb28iKSB7CisgICAgRUNI TyAiWW91IHNob3VsZCBub3QgYmUgc2VlaW5nIHRoaXMgdGV4dCEiOworfQorPz4KKworPGZvcm0g bWV0aG9kPSJQT1NUIj4KKyAgICA8aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0idGV4dGRhdGEiIHZh bHVlPSJmb28iPgorICAgIDxpbnB1dCB0eXBlPSJzdWJtaXQiIGlkPSJzdWJtaXQiPgorPC9mb3Jt PgorCis8L2JvZHk+Cis8L2h0bWw+Cg== 29538 2009-04-16 10:58:04 -0700 2009-04-17 06:30:50 -0700 v2 patch: same as before, but with equivalent changes to win/FrameLoadDelegate.cpp fix_2.txt text/plain 7003 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjU4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDQtMTYgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjUyMjMKKyAgICAgICAgUkVH UkVTU0lPTjogQmFjayBidXR0b24gYWZ0ZXIgZm9ybSBzdWJtaXNzaW9uIHRvIHRoZSBzYW1lIFVS TCBmYWlscyB0byBuYXZpZ2F0ZS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL25hdmlnYXRp b24vcG9zdC1nb2JhY2stc2FtZS11cmwuaHRtbAorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpsb2FkSXRlbSk6IENoZWNr IGlmIHRoZSBwYWdlIHdlIGFyZSBsZWF2aW5nIGhhcworICAgICAgICBGb3JtRGF0YS4KKwogMjAw OS0wNC0xNiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lv biA0MjU2MikKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDQ0Niw5ICs0NDQ2LDkgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZEl0ZW0oSGlzdG9y eUl0ZW0qIAogICAgIC8vIFdlIGFsc28gZG8gbm90IGRvIGFuY2hvci1zdHlsZSBuYXZpZ2F0aW9u IGlmIHdlJ3JlIHBvc3RpbmcgYSBmb3JtLgogICAgIAogI2lmIEVOQUJMRShXTUwpCi0gICAgaWYg KCFmb3JtRGF0YSAmJiB1cmxzTWF0Y2hJdGVtKGl0ZW0pICYmICFtX2ZyYW1lLT5kb2N1bWVudCgp LT5pc1dNTERvY3VtZW50KCkpIHsKKyAgICBpZiAoIWZvcm1EYXRhICYmICFtX2N1cnJlbnRIaXN0 b3J5SXRlbS0+Zm9ybURhdGEoKSAmJiB1cmxzTWF0Y2hJdGVtKGl0ZW0pICYmICFtX2ZyYW1lLT5k b2N1bWVudCgpLT5pc1dNTERvY3VtZW50KCkpIHsKICNlbHNlCi0gICAgaWYgKCFmb3JtRGF0YSAm JiB1cmxzTWF0Y2hJdGVtKGl0ZW0pKSB7CisgICAgaWYgKCFmb3JtRGF0YSAmJiAhbV9jdXJyZW50 SGlzdG9yeUl0ZW0tPmZvcm1EYXRhKCkgJiYgdXJsc01hdGNoSXRlbShpdGVtKSkgewogI2VuZGlm CiAgICAgICAgIC8vIE11c3QgZG8gdGhpcyBtYWludGVuYW5jZSBoZXJlLCBzaW5jZSB3ZSBkb24n dCBnbyB0aHJvdWdoIGEgcmVhbCBwYWdlIHJlbG9hZAogICAgICAgICBzYXZlU2Nyb2xsUG9zaXRp b25BbmRWaWV3U3RhdGVUb0l0ZW0obV9jdXJyZW50SGlzdG9yeUl0ZW0uZ2V0KCkpOwpJbmRleDog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxv ZwkocmV2aXNpb24gNDI1ODApCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wNC0xNiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTIyMworICAgICAg ICBSRUdSRVNTSU9OOiBCYWNrIGJ1dHRvbiBhZnRlciBmb3JtIHN1Ym1pc3Npb24gdG8gdGhlIHNh bWUgVVJMIGZhaWxzIHRvIG5hdmlnYXRlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFj L0ZyYW1lTG9hZERlbGVnYXRlLm1tOgorICAgICAgICAoLVtGcmFtZUxvYWREZWxlZ2F0ZSBwcm9j ZXNzV29yazpdKTogTmVlZCB0byBkZWZlciBwcm9jZXNzaW5nIHRoZSB3b3JrCisgICAgICAgIHF1 ZXVlIGlmIGEgbmF2aWdhdGlvbiBzdGFydGVkIGJldHdlZW4gbG9jYXRpb25DaGFuZ2VEb25lIGFu ZCBvdXIKKyAgICAgICAgZGVsYXllZCBwcm9jZXNzV29yayBjYWxsLiAgVGhpcyBjYW4gaGFwcGVu IHdoZW4gdXNpbmcgcXVldWVMb2FkaW5nU2NyaXB0CisgICAgICAgIHRvIGxvYWQgc2NyaXB0IHRo YXQgc2ltdWxhdGVzIGEgY2xpY2sgb24gYSBsaW5rIG9yIHN1Ym1pdCBidXR0b24gc2luY2UKKyAg ICAgICAgdGhvc2UgY2xpY2tzIGhhcHBlbiBhc3luY2hyb25vdXNseS4KKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS93aW4vRnJhbWVMb2FkRGVsZWdhdGUuY3BwOgorICAgICAgICAoRnJhbWVMb2Fk RGVsZWdhdGU6OnByb2Nlc3NXb3JrKTogU2FtZSBhcyBhYm92ZS4KKwogMjAwOS0wNC0xNiAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2tpcCB5ZXQgYW5vdGhlciBK YXZhU2NyaXB0Q29yZSB0ZXN0IHRoYXQgc29tZXRpbWVzIGZhaWxzIG9uIFdpbmRvd3MKSW5kZXg6 IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9GcmFtZUxvYWREZWxlZ2F0ZS5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRnJhbWVMb2FkRGVsZWdh dGUubW0JKHJldmlzaW9uIDQyNTYyKQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L0ZyYW1lTG9hZERlbGVnYXRlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEsNiArMTExLDEwIEBA CiAvLyBFeGVjIG1lc3NhZ2VzIGluIHRoZSB3b3JrIHF1ZXVlIHVudGlsIHRoZXkncmUgYWxsIGRv bmUsIG9yIG9uZSBvZiB0aGVtIHN0YXJ0cyBhIG5ldyBsb2FkCiAtICh2b2lkKXByb2Nlc3NXb3Jr OihpZClkdW1teQogeworICAgIC8vIGlmIGFub3RoZXIgbG9hZCBzdGFydGVkLCB0aGVuIHdhaXQg Zm9yIGl0IHRvIGNvbXBsZXRlLgorICAgIGlmICh0b3BMb2FkaW5nRnJhbWUgIT0gbmlsKQorICAg ICAgICByZXR1cm47CisKICAgICAvLyBpZiB3ZSBmaW5pc2ggYWxsIHRoZSBjb21tYW5kcywgd2Un cmUgcmVhZHkgdG8gZHVtcCBzdGF0ZQogICAgIGlmIChXb3JrUXVldWU6OnNoYXJlZCgpLT5wcm9j ZXNzV29yaygpICYmICFnTGF5b3V0VGVzdENvbnRyb2xsZXItPndhaXRUb0R1bXAoKSkKICAgICAg ICAgZHVtcCgpOwpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0ZyYW1lTG9h ZERlbGVnYXRlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93 aW4vRnJhbWVMb2FkRGVsZWdhdGUuY3BwCShyZXZpc2lvbiA0MjU2MikKKysrIFdlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3dpbi9GcmFtZUxvYWREZWxlZ2F0ZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE4Myw2ICsxODMsMTAgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBGcmFtZUxvYWRE ZWxlZwogCiB2b2lkIEZyYW1lTG9hZERlbGVnYXRlOjpwcm9jZXNzV29yaygpCiB7CisgICAgLy8g aWYgYW5vdGhlciBsb2FkIHN0YXJ0ZWQsIHRoZW4gd2FpdCBmb3IgaXQgdG8gY29tcGxldGUuCisg ICAgaWYgKHRvcExvYWRpbmdGcmFtZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gaWYgd2Ug ZmluaXNoIGFsbCB0aGUgY29tbWFuZHMsIHdlJ3JlIHJlYWR5IHRvIGR1bXAgc3RhdGUKICAgICBp ZiAoV29ya1F1ZXVlOjpzaGFyZWQoKS0+cHJvY2Vzc1dvcmsoKSAmJiAhOjpnTGF5b3V0VGVzdENv bnRyb2xsZXItPndhaXRUb0R1bXAoKSkKICAgICAgICAgZHVtcCgpOwpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gNDI1ODApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNCBAQAorMjAwOS0wNC0xNiAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTIyMworICAgICAgICBSRUdSRVNT SU9OOiBCYWNrIGJ1dHRvbiBhZnRlciBmb3JtIHN1Ym1pc3Npb24gdG8gdGhlIHNhbWUgVVJMIGZh aWxzIHRvIG5hdmlnYXRlLgorCisgICAgICAgICogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3Qt Z29iYWNrLXNhbWUtdXJsLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdh dGlvbi9wb3N0LWdvYmFjay1zYW1lLXVybC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvcG9zdC1nb2JhY2stc2FtZS11cmwucGhw OiBBZGRlZC4KKwogMjAwOS0wNC0xNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29iYWNrLXNhbWUtdXJsLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcG9zdC1nb2JhY2st c2FtZS11cmwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29iYWNrLXNhbWUtdXJsLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw3IEBACisgIAorCis9PT09PT09PT09PT09PSBCYWNrIEZvcndhcmQg TGlzdCA9PT09PT09PT09PT09PQorICAgICAgICBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdh dGlvbi9wb3N0LWdvYmFjay1zYW1lLXVybC5odG1sICAqKm5hdiB0YXJnZXQqKgorY3Vyci0+ICBo dHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9yZXNvdXJjZXMvcG9zdC1nb2JhY2stc2Ft ZS11cmwucGhwICAqKm5hdiB0YXJnZXQqKgorICAgICAgICBodHRwOi8vMTI3LjAuMC4xOjgwMDAv bmF2aWdhdGlvbi9yZXNvdXJjZXMvcG9zdC1nb2JhY2stc2FtZS11cmwucGhwICAqKm5hdiB0YXJn ZXQqKgorPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KSW5k ZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9wb3N0LWdvYmFjay1zYW1lLXVy bC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9w b3N0LWdvYmFjay1zYW1lLXVybC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3QtZ29iYWNrLXNhbWUtdXJsLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTkgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorICAgIAoraWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1 bXBCYWNrRm9yd2FyZExpc3QoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIucXVldWVMb2FkKCJyZXNvdXJjZXMvcG9zdC1n b2JhY2stc2FtZS11cmwucGhwIik7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIucXVldWVMb2Fk aW5nU2NyaXB0KCJzdWJtaXRGb3JtKCkiKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5xdWV1 ZUJhY2tOYXZpZ2F0aW9uKDEpOworfQorICAgIAorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K K2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTIyMyAtIEJhY2sgYnV0 dG9uIGFmdGVyIGZvcm0KK3N1Ym1pc3Npb24gdG8gdGhlIHNhbWUgVVJMIGZhaWxzIHRvIG5hdmln YXRlCis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmln YXRpb24vcmVzb3VyY2VzL3Bvc3QtZ29iYWNrLXNhbWUtdXJsLnBocAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL3Bvc3QtZ29iYWNrLXNh bWUtdXJsLnBocAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdh dGlvbi9yZXNvdXJjZXMvcG9zdC1nb2JhY2stc2FtZS11cmwucGhwCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDI2IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKworZnVuY3Rpb24gc3VibWl0 Rm9ybSgpCit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3N1Ym1pdCcpLmNsaWNrKCk7 Cit9CisKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisKKzw/CitJRiAoJF9QT1NUWyd0ZXh0 ZGF0YSddID09ICJmb28iKSB7CisgICAgRUNITyAiWW91IHNob3VsZCBub3QgYmUgc2VlaW5nIHRo aXMgdGV4dCEiOworfQorPz4KKworPGZvcm0gbWV0aG9kPSJQT1NUIj4KKyAgICA8aW5wdXQgdHlw ZT0idGV4dCIgbmFtZT0idGV4dGRhdGEiIHZhbHVlPSJmb28iPgorICAgIDxpbnB1dCB0eXBlPSJz dWJtaXQiIGlkPSJzdWJtaXQiPgorPC9mb3JtPgorCis8L2JvZHk+Cis8L2h0bWw+Cg==