25198 2009-04-14 19:00:46 -0700 Wrap some JSC specific code in a #if USE(JSC) 2009-04-15 11:07:02 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eroman eroman dglazkov ggaren oldest_to_newest 117555 0 eroman 2009-04-14 19:00:46 -0700 The change <http://trac.webkit.org/changeset/42476> exposes some code in RegisteredEventListener.h which does not compile with V8 bindings. EventListener::clearJSFunction and EventListener::markJSFunction are only defined if #USE(JSC), so any callers of it should probably also be wrapped in a #if USE(JSC) block. Patch coming. 117556 1 29487 eroman 2009-04-14 19:01:55 -0700 Created attachment 29487 hide some code when building V8 bindings 117618 2 fishd 2009-04-15 11:07:02 -0700 Landed as: http://trac.webkit.org/changeset/42544 29487 2009-04-14 19:01:55 -0700 2009-04-15 07:39:56 -0700 hide some code when building V8 bindings wrap-in-jsc-block-v1.patch text/plain 1297 eroman SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjUzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDktMDQtMTQgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdy YXAgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXI6Om1hcmtFdmVudExpc3RlbmVycyBhbmQgUmVnaXN0 ZXJlZEV2ZW50TGlzdGVuZXJzOjppbnZhbGlkYXRlRXZlbnRMaXN0ZW5lcnMgaW4gYSBVU0UoSlND KSwgc2luY2UgaXQgZG9lc24ndCBjb21waWxlIHdpdGggVjggYmluZGluZ3MuCisKKyAgICAgICAg KiBkb20vUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXIuaDoKKwogMjAwOS0wNC0xNCAgRXJpYyBDYXJs c29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4 ZXkgUHJvc2t1cnlha292LgpJbmRleDogV2ViQ29yZS9kb20vUmVnaXN0ZXJlZEV2ZW50TGlzdGVu ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9SZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5o CShyZXZpc2lvbiA0MjUzMSkKKysrIFdlYkNvcmUvZG9tL1JlZ2lzdGVyZWRFdmVudExpc3RlbmVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTU0LDYgKzU0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgdHlwZWRlZiBWZWN0b3I8UmVmUHRyPFJlZ2lzdGVyZWRFdmVudExpc3RlbmVyPiA+IFJl Z2lzdGVyZWRFdmVudExpc3RlbmVyVmVjdG9yOwogCisjaWYgVVNFKEpTQykKICAgICBpbmxpbmUg dm9pZCBtYXJrRXZlbnRMaXN0ZW5lcnMoY29uc3QgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXJWZWN0 b3ImIGxpc3RlbmVycykKICAgICB7CiAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGlz dGVuZXJzLnNpemUoKTsgKytpKQpAQCAtNjUsNiArNjYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGlzdGVuZXJzLnNpemUoKTsgKytpKQog ICAgICAgICAgICAgbGlzdGVuZXJzW2ldLT5saXN0ZW5lcigpLT5jbGVhckpTRnVuY3Rpb24oKTsK ICAgICB9CisjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCg==