25192 2009-04-14 17:08:17 -0700 Make DOMWindow:: inlineEventListenerForType public 2009-04-15 11:13:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eroman eroman dglazkov ggaren oldest_to_newest 117535 0 eroman 2009-04-14 17:08:17 -0700 I would like to make these methods of DOMWindow public (currently private): void removeInlineEventListenerForType(const AtomicString& eventType); EventListener* inlineEventListenerForType(const AtomicString& eventType) These used to be public, and live in Document. They were moved in <http://trac.webkit.org/changeset/42446>. This change broke chromium which uses the methods in <http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/v8_custom.cpp>. By making the renamed methods public again, I can easily update v8_custom.cpp to build again. Will attach a patch. 117537 1 29481 eroman 2009-04-14 17:23:11 -0700 Created attachment 29481 Make 2 methods on DOMWindow public 117550 2 29481 ggaren 2009-04-14 18:04:15 -0700 Comment on attachment 29481 Make 2 methods on DOMWindow public r=me 117621 3 fishd 2009-04-15 11:13:18 -0700 Landed as: http://trac.webkit.org/changeset/42545 29481 2009-04-14 17:23:11 -0700 2009-04-14 18:04:15 -0700 Make 2 methods on DOMWindow public domwindow-expose-public-v1.patch text/plain 1364 eroman SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjUzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDQtMTQgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4 cG9zZSBET01XaW5kb3c6OnJlbW92ZUlubGluZUV2ZW50TGlzdGVuZXJGb3JUeXBlIGFuZCBET01X aW5kb3c6OmlubGluZUV2ZW50TGlzdGVuZXJGb3JUeXBlIGFzIHB1YmxpYy4KKyAgICAgICAgPGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTE5Mj4KKworICAgICAgICAq IHBhZ2UvRE9NV2luZG93Lmg6CisKIDIwMDktMDQtMTQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVu QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2VkIHN2biBtZXJnZSAtcjQyNTI5OjQyNTI4IHRvIHJv bGwgb3V0IG15IGxhc3QgcGF0Y2ggYmVjYXVzZSBpdCBicm9rZQpJbmRleDogV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAkocmV2 aXNpb24gNDI1MzEpCisrKyBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgJKHdvcmtpbmcgY29weSkK QEAgLTI5MywxMiArMjkzLDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgRE9NQXBw bGljYXRpb25DYWNoZSogb3B0aW9uYWxBcHBsaWNhdGlvbkNhY2hlKCkgY29uc3QgeyByZXR1cm4g bV9hcHBsaWNhdGlvbkNhY2hlLmdldCgpOyB9CiAjZW5kaWYKIAotICAgIHByaXZhdGU6Ci0gICAg ICAgIERPTVdpbmRvdyhGcmFtZSopOwotCiAgICAgICAgIHZvaWQgcmVtb3ZlSW5saW5lRXZlbnRM aXN0ZW5lckZvclR5cGUoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUpOwogICAgICAgICBF dmVudExpc3RlbmVyKiBpbmxpbmVFdmVudExpc3RlbmVyRm9yVHlwZShjb25zdCBBdG9taWNTdHJp bmcmIGV2ZW50VHlwZSkgY29uc3Q7CiAKKyAgICBwcml2YXRlOgorICAgICAgICBET01XaW5kb3co RnJhbWUqKTsKKwogICAgICAgICB2b2lkIGFkZFBlbmRpbmdGcmFtZVVubG9hZEV2ZW50Q291bnQo KTsKICAgICAgICAgdm9pZCByZW1vdmVQZW5kaW5nRnJhbWVVbmxvYWRFdmVudENvdW50KCk7CiAg ICAgICAgIHZvaWQgYWRkUGVuZGluZ0ZyYW1lQmVmb3JlVW5sb2FkRXZlbnRDb3VudCgpOwo=