<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>251912</bug_id>
          
          <creation_ts>2023-02-08 02:29:13 -0800</creation_ts>
          <short_desc>[GLIB] Disable hinting for testing</short_desc>
          <delta_ts>2023-02-17 06:17:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Vitaly Dyackhov">vitaly</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1931971</commentid>
    <comment_count>0</comment_count>
    <who name="Vitaly Dyackhov">vitaly</who>
    <bug_when>2023-02-08 02:29:13 -0800</bug_when>
    <thetext>Currently, when rendering text on the GTK platform, font system options such as antialiasing and hinting are taken into account. While this is generally good, it would be great to have a deterministic testing environment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1931975</commentid>
    <comment_count>1</comment_count>
    <who name="Vitaly Dyackhov">vitaly</who>
    <bug_when>2023-02-08 02:45:48 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/9805</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1933779</commentid>
    <comment_count>2</comment_count>
    <who name="Vitaly Dyackhov">vitaly</who>
    <bug_when>2023-02-15 04:25:01 -0800</bug_when>
    <thetext>There are some tests that differ between GTK and WPE because GTK WebKitTestRunner disables font hinting. It does it by using `GtkSettingsManager` mechanism which doesn&apos;t exist on WPE. It would be great to have a way to disable hinting that works on both platforms. It will let us then use the same baselines for such tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1933783</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-02-15 04:36:21 -0800</bug_when>
    <thetext>Or enable hinting for WPE for testing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1933784</commentid>
    <comment_count>4</comment_count>
    <who name="Vitaly Dyackhov">vitaly</who>
    <bug_when>2023-02-15 04:41:46 -0800</bug_when>
    <thetext>Hinting is enabled on WPE by default. And currently, there is no API to change it. If understand it correctly, enabling hinting can lead to flaky or even failing tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1933787</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-02-15 05:47:41 -0800</bug_when>
    <thetext>Ok, that makes sense, then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1934605</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-02-17 06:17:03 -0800</bug_when>
    <thetext>Committed 260443@main (34e13090c605): &lt;https://commits.webkit.org/260443@main&gt;

Reviewed commits have been landed. Closing PR #9805 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>