251874 2023-02-07 12:00:53 -0800 [Wasm-GC] Update element segments to account for typed funcrefs and GC types 2023-12-12 14:16:37 -0800 1 1 1 Unclassified WebKit WebAssembly WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=251041 https://bugs.webkit.org/show_bug.cgi?id=252349 InRadar P2 Normal --- 247394 253029 1 tjc webkit-unassigned webkit-bug-importer oldest_to_newest 1931798 0 tjc 2023-02-07 12:00:53 -0800 The following test: ``` function testElem() { let m = instantiate(` (module (type $bvec (array i8)) (elem $e (ref $bvec) (array.new_canon $bvec (i32.const 7) (i32.const 3))))`); } ``` fails with: ``` Exception: CompileError: WebAssembly.Module doesn't parse at byte 30: opcode for exp in element section's should be either ref.func or ref.null 0th element's 0th index (evaluating 'new WebAssembly.Module(binary)') ``` This is because `SectionParser::parseElementSegmentVectorOfExpressions()` requires the members of the elements vector to be either a `RefFunc` or `RefNull`. The test should compile (this is taken from https://github.com/WebAssembly/gc/blob/main/test/core/gc/array.wast#L203 ) A related bug is https://bugs.webkit.org/show_bug.cgi?id=251041 , but that one covers tables rather than element segments. 1932476 1 tjc 2023-02-09 15:13:09 -0800 externrefs also aren't allowed in element segments, and should be: ``` (module (elem $elem0 externref (ref.null extern))) ``` fails with: ``` Exception: CompileError: WebAssembly.Module doesn't parse at byte 17: reftype in element section should be funcref (evaluating 'new WebAssembly.Module(binary)') ``` but is accepted by the reference interpreter. 1933554 2 webkit-bug-importer 2023-02-14 12:01:32 -0800 <rdar://problem/105461451> 1934019 3 tjc 2023-02-15 17:25:51 -0800 This should also work: ``` (module (type $fty (func (result i32))) (func $f (result i32) (i32.const 2)) (elem $e (ref $fty) (ref.func $f))) ``` As it is, the element segment type is restricted to either `funcref` or `externref`. 1998758 4 asumu 2023-12-11 12:49:03 -0800 Pull request: https://github.com/WebKit/WebKit/pull/21647 1999088 5 ews-feeder 2023-12-12 14:16:35 -0800 Committed 271952@main (7e71e7282468): <https://commits.webkit.org/271952@main> Reviewed commits have been landed. Closing PR #21647 and removing active labels.