25180 2009-04-14 07:16:28 -0700 drawRect() outlines are missing in Chromium 2009-04-15 11:15:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco oldest_to_newest 117458 0 senorblanco 2009-04-14 07:16:28 -0700 The stroked outlines for rectangles drawn via PlatformContext::drawRect() in Chromium are missing. This was introduced in https://bugs.webkit.org/show_bug.cgi?id=24662 (r41805), and the affected tests were rebaselined with the outlines missing in http://codereview.chromium.org/46097. 117459 1 29466 senorblanco 2009-04-14 07:28:41 -0700 Created attachment 29466 Fix for Chromium drawRect() issue. 117466 2 29468 senorblanco 2009-04-14 08:21:31 -0700 Created attachment 29468 Slight fix to avoid overdraw. Slight fix to previous: don't draw corners twice (might cause a problem with alpha on). 117517 3 29468 dglazkov 2009-04-14 13:47:10 -0700 Comment on attachment 29468 Slight fix to avoid overdraw. Missing bug URL in ChangeLog. 117523 4 29479 senorblanco 2009-04-14 14:13:41 -0700 Created attachment 29479 Fixed changelog. 117622 5 fishd 2009-04-15 11:15:39 -0700 Landed as: http://trac.webkit.org/changeset/42547 29466 2009-04-14 07:28:41 -0700 2009-04-14 13:46:05 -0700 Fix for Chromium drawRect() issue. webkit-rect-fix.patch text/plain 2198 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjQ5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDQtMTQgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVzdG9yZSBzdHJva2VkIG91dGxpbmVzIHRvIFBsYXRmb3JtQ29udGV4dFNraWE6OmRy YXdSZWN0KCkuCisgICAgICAgIFRoZXNlIHdlcmUgcmVtb3ZlZCBpbmFkdmVydGVudGx5IGluIHI0 MTgwNSwgYWthCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDY2Mi4KKyAgICAgICAgU2tSZWN0IGlzIHsgbGVmdCwgdG9wLCByaWdodCwgYm90dG9tIH0s IG5vdAorICAgICAgICB7IGxlZnQsIHRvcCwgd2lkdGgsIGhlaWdodCB9LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAg KFBsYXRmb3JtQ29udGV4dFNraWE6OmRyYXdSZWN0KToKKwogMjAwOS0wNC0xNCAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQW5vdGhlciBXaW5kb3dzIGJ1 aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNv bnRleHRTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDQyNDg5KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNzcsMTMgKzI3NywxMyBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmRyYXdS ZWN0KFNrUmVjCiAgICAgICAgIGlmIChvbGRGaWxsQ29sb3IgIT0gbV9zdGF0ZS0+bV9zdHJva2VD b2xvcikKICAgICAgICAgICAgIHNldEZpbGxDb2xvcihtX3N0YXRlLT5tX3N0cm9rZUNvbG9yKTsK ICAgICAgICAgc2V0dXBQYWludEZvckZpbGxpbmcoJnBhaW50KTsKLSAgICAgICAgU2tSZWN0IHRv cEJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5mVG9wLCByZWN0LndpZHRoKCksIDEgfTsKKyAg ICAgICAgU2tSZWN0IHRvcEJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5mVG9wLCByZWN0LmZS aWdodCwgcmVjdC5mVG9wICsgMSB9OwogICAgICAgICBjYW52YXMoKS0+ZHJhd1JlY3QodG9wQm9y ZGVyLCBwYWludCk7Ci0gICAgICAgIFNrUmVjdCBib3R0b21Cb3JkZXIgPSB7IHJlY3QuZkxlZnQs IHJlY3QuZkJvdHRvbSAtIDEsIHJlY3Qud2lkdGgoKSwgMSB9OworICAgICAgICBTa1JlY3QgYm90 dG9tQm9yZGVyID0geyByZWN0LmZMZWZ0LCByZWN0LmZCb3R0b20gLSAxLCByZWN0LmZSaWdodCwg cmVjdC5mQm90dG9tIH07CiAgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdChib3R0b21Cb3JkZXIs IHBhaW50KTsKLSAgICAgICAgU2tSZWN0IGxlZnRCb3JkZXIgPSB7IHJlY3QuZkxlZnQsIHJlY3Qu ZlRvcCArIDEsIDEsIHJlY3QuaGVpZ2h0KCkgLSAyIH07CisgICAgICAgIFNrUmVjdCBsZWZ0Qm9y ZGVyID0geyByZWN0LmZMZWZ0LCByZWN0LmZUb3AsIHJlY3QuZkxlZnQgKyAxLCByZWN0LmZCb3R0 b20gfTsKICAgICAgICAgY2FudmFzKCktPmRyYXdSZWN0KGxlZnRCb3JkZXIsIHBhaW50KTsKLSAg ICAgICAgU2tSZWN0IHJpZ2h0Qm9yZGVyID0geyByZWN0LmZSaWdodCAtIDEsIHJlY3QuZlRvcCAr IDEsIDEsIHJlY3QuaGVpZ2h0KCkgLSAyIH07CisgICAgICAgIFNrUmVjdCByaWdodEJvcmRlciA9 IHsgcmVjdC5mUmlnaHQgLSAxLCByZWN0LmZUb3AsIHJlY3QuZlJpZ2h0LCByZWN0LmZCb3R0b20g fTsKICAgICAgICAgY2FudmFzKCktPmRyYXdSZWN0KHJpZ2h0Qm9yZGVyLCBwYWludCk7CiAgICAg ICAgIGlmIChvbGRGaWxsQ29sb3IgIT0gbV9zdGF0ZS0+bV9zdHJva2VDb2xvcikKICAgICAgICAg ICAgIHNldEZpbGxDb2xvcihvbGRGaWxsQ29sb3IpOwo= 29468 2009-04-14 08:21:31 -0700 2009-04-14 14:13:41 -0700 Slight fix to avoid overdraw. webkit-rect-fix-2.patch text/plain 2214 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjQ5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDQtMTQgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVzdG9yZSBzdHJva2VkIG91dGxpbmVzIHRvIFBsYXRmb3JtQ29udGV4dFNraWE6OmRy YXdSZWN0KCkuCisgICAgICAgIFRoZXNlIHdlcmUgcmVtb3ZlZCBpbmFkdmVydGVudGx5IGluIHI0 MTgwNSwgYWthCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDY2Mi4KKyAgICAgICAgU2tSZWN0IGlzIHsgbGVmdCwgdG9wLCByaWdodCwgYm90dG9tIH0s IG5vdAorICAgICAgICB7IGxlZnQsIHRvcCwgd2lkdGgsIGhlaWdodCB9LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAg KFBsYXRmb3JtQ29udGV4dFNraWE6OmRyYXdSZWN0KToKKwogMjAwOS0wNC0xNCAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQW5vdGhlciBXaW5kb3dzIGJ1 aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNv bnRleHRTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDQyNDg5KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNzcsMTMgKzI3NywxMyBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmRyYXdS ZWN0KFNrUmVjCiAgICAgICAgIGlmIChvbGRGaWxsQ29sb3IgIT0gbV9zdGF0ZS0+bV9zdHJva2VD b2xvcikKICAgICAgICAgICAgIHNldEZpbGxDb2xvcihtX3N0YXRlLT5tX3N0cm9rZUNvbG9yKTsK ICAgICAgICAgc2V0dXBQYWludEZvckZpbGxpbmcoJnBhaW50KTsKLSAgICAgICAgU2tSZWN0IHRv cEJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5mVG9wLCByZWN0LndpZHRoKCksIDEgfTsKKyAg ICAgICAgU2tSZWN0IHRvcEJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5mVG9wLCByZWN0LmZS aWdodCwgcmVjdC5mVG9wICsgMSB9OwogICAgICAgICBjYW52YXMoKS0+ZHJhd1JlY3QodG9wQm9y ZGVyLCBwYWludCk7Ci0gICAgICAgIFNrUmVjdCBib3R0b21Cb3JkZXIgPSB7IHJlY3QuZkxlZnQs IHJlY3QuZkJvdHRvbSAtIDEsIHJlY3Qud2lkdGgoKSwgMSB9OworICAgICAgICBTa1JlY3QgYm90 dG9tQm9yZGVyID0geyByZWN0LmZMZWZ0LCByZWN0LmZCb3R0b20gLSAxLCByZWN0LmZSaWdodCwg cmVjdC5mQm90dG9tIH07CiAgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdChib3R0b21Cb3JkZXIs IHBhaW50KTsKLSAgICAgICAgU2tSZWN0IGxlZnRCb3JkZXIgPSB7IHJlY3QuZkxlZnQsIHJlY3Qu ZlRvcCArIDEsIDEsIHJlY3QuaGVpZ2h0KCkgLSAyIH07CisgICAgICAgIFNrUmVjdCBsZWZ0Qm9y ZGVyID0geyByZWN0LmZMZWZ0LCByZWN0LmZUb3AgKyAxLCByZWN0LmZMZWZ0ICsgMSwgcmVjdC5m Qm90dG9tIC0gMSB9OwogICAgICAgICBjYW52YXMoKS0+ZHJhd1JlY3QobGVmdEJvcmRlciwgcGFp bnQpOwotICAgICAgICBTa1JlY3QgcmlnaHRCb3JkZXIgPSB7IHJlY3QuZlJpZ2h0IC0gMSwgcmVj dC5mVG9wICsgMSwgMSwgcmVjdC5oZWlnaHQoKSAtIDIgfTsKKyAgICAgICAgU2tSZWN0IHJpZ2h0 Qm9yZGVyID0geyByZWN0LmZSaWdodCAtIDEsIHJlY3QuZlRvcCArIDEsIHJlY3QuZlJpZ2h0LCBy ZWN0LmZCb3R0b20gLSAxIH07CiAgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdChyaWdodEJvcmRl ciwgcGFpbnQpOwogICAgICAgICBpZiAob2xkRmlsbENvbG9yICE9IG1fc3RhdGUtPm1fc3Ryb2tl Q29sb3IpCiAgICAgICAgICAgICBzZXRGaWxsQ29sb3Iob2xkRmlsbENvbG9yKTsK 29479 2009-04-14 14:13:41 -0700 2009-04-14 15:14:51 -0700 Fixed changelog. webkit-rect-fix-3.patch text/plain 2264 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjUyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzQwMDktMDQtMTQgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MTgwCisKKyAg ICAgICAgUmVzdG9yZSBzdHJva2VkIG91dGxpbmVzIHRvIFBsYXRmb3JtQ29udGV4dFNraWE6OmRy YXdSZWN0KCkuCisgICAgICAgIFRoZXNlIHdlcmUgcmVtb3ZlZCBpbmFkdmVydGVudGx5IGluIHI0 MTgwNSwgYWthCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDY2Mi4KKyAgICAgICAgU2tSZWN0IGlzIHsgbGVmdCwgdG9wLCByaWdodCwgYm90dG9tIH0s IG5vdAorICAgICAgICB7IGxlZnQsIHRvcCwgd2lkdGgsIGhlaWdodCB9LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAg KFBsYXRmb3JtQ29udGV4dFNraWE6OmRyYXdSZWN0KToKKwogMjAwOS0wNC0xNCAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlIFBldGVyc29u LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNr aWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0 Zm9ybUNvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gNDI1MjApCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI3NywxMyArMjc3LDEzIEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6ZHJhd1JlY3QoU2tS ZWMKICAgICAgICAgaWYgKG9sZEZpbGxDb2xvciAhPSBtX3N0YXRlLT5tX3N0cm9rZUNvbG9yKQog ICAgICAgICAgICAgc2V0RmlsbENvbG9yKG1fc3RhdGUtPm1fc3Ryb2tlQ29sb3IpOwogICAgICAg ICBzZXR1cFBhaW50Rm9yRmlsbGluZygmcGFpbnQpOwotICAgICAgICBTa1JlY3QgdG9wQm9yZGVy ID0geyByZWN0LmZMZWZ0LCByZWN0LmZUb3AsIHJlY3Qud2lkdGgoKSwgMSB9OworICAgICAgICBT a1JlY3QgdG9wQm9yZGVyID0geyByZWN0LmZMZWZ0LCByZWN0LmZUb3AsIHJlY3QuZlJpZ2h0LCBy ZWN0LmZUb3AgKyAxIH07CiAgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdCh0b3BCb3JkZXIsIHBh aW50KTsKLSAgICAgICAgU2tSZWN0IGJvdHRvbUJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5m Qm90dG9tIC0gMSwgcmVjdC53aWR0aCgpLCAxIH07CisgICAgICAgIFNrUmVjdCBib3R0b21Cb3Jk ZXIgPSB7IHJlY3QuZkxlZnQsIHJlY3QuZkJvdHRvbSAtIDEsIHJlY3QuZlJpZ2h0LCByZWN0LmZC b3R0b20gfTsKICAgICAgICAgY2FudmFzKCktPmRyYXdSZWN0KGJvdHRvbUJvcmRlciwgcGFpbnQp OwotICAgICAgICBTa1JlY3QgbGVmdEJvcmRlciA9IHsgcmVjdC5mTGVmdCwgcmVjdC5mVG9wICsg MSwgMSwgcmVjdC5oZWlnaHQoKSAtIDIgfTsKKyAgICAgICAgU2tSZWN0IGxlZnRCb3JkZXIgPSB7 IHJlY3QuZkxlZnQsIHJlY3QuZlRvcCArIDEsIHJlY3QuZkxlZnQgKyAxLCByZWN0LmZCb3R0b20g LSAxIH07CiAgICAgICAgIGNhbnZhcygpLT5kcmF3UmVjdChsZWZ0Qm9yZGVyLCBwYWludCk7Ci0g ICAgICAgIFNrUmVjdCByaWdodEJvcmRlciA9IHsgcmVjdC5mUmlnaHQgLSAxLCByZWN0LmZUb3Ag KyAxLCAxLCByZWN0LmhlaWdodCgpIC0gMiB9OworICAgICAgICBTa1JlY3QgcmlnaHRCb3JkZXIg PSB7IHJlY3QuZlJpZ2h0IC0gMSwgcmVjdC5mVG9wICsgMSwgcmVjdC5mUmlnaHQsIHJlY3QuZkJv dHRvbSAtIDEgfTsKICAgICAgICAgY2FudmFzKCktPmRyYXdSZWN0KHJpZ2h0Qm9yZGVyLCBwYWlu dCk7CiAgICAgICAgIGlmIChvbGRGaWxsQ29sb3IgIT0gbV9zdGF0ZS0+bV9zdHJva2VDb2xvcikK ICAgICAgICAgICAgIHNldEZpbGxDb2xvcihvbGRGaWxsQ29sb3IpOwo=