25177 2009-04-13 21:46:06 -0700 HTMLMediaElement: QTMedia not supported in 64-bit QTKit 2009-04-13 22:04:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 eric.carlson webkit-unassigned oldest_to_newest 117420 0 eric.carlson 2009-04-13 21:46:06 -0700 QTTrack's -media method always return NULL in 64-bit QTKit, so MediaPlayerPrivate::disableUnsupportedTracks should get the track type with the track's QTTrackMediaTypeAttribute attribute. 117421 1 29457 eric.carlson 2009-04-13 21:50:18 -0700 Created attachment 29457 proposed patch 117422 2 29457 mrowe 2009-04-13 21:59:55 -0700 Comment on attachment 29457 proposed patch r=me 117425 3 eric.carlson 2009-04-13 22:04:51 -0700 http://trac.webkit.org/changeset/42477 29457 2009-04-13 21:50:18 -0700 2009-04-13 21:59:55 -0700 proposed patch patch.txt text/plain 3181 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjQ3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDYgKzEsMjEgQEAKIDIwMDktMDQtMTMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MTc3CisKKyAgICAg ICAgUVRUcmFjaydzIC1tZWRpYSBtZXRob2QgYWx3YXlzIHJldHVybiBOVUxMIGluIDY0LWJpdCBR VEtpdCwgc28KKyAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlOjpkaXNhYmxlVW5zdXBwb3J0ZWRU cmFja3Mgc2hvdWxkIHVzZSB0aGUgdHJhY2sKKyAgICAgICAgUVRUcmFja01lZGlhVHlwZUF0dHJp YnV0ZSBhdHRyaWJ1dGUgdG8gZ2V0IGEgdHJhY2sncyB0eXBlLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpkaXNhYmxlVW5zdXBwb3J0ZWRUcmFja3MpOgorCisy MDA5LTA0LTEzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCiAgICAg ICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTE1NQogCiAgICAgICAgIE9TIFggc3RhbmRh bG9uZSBtZWRpYSBkb2N1bWVudHMgc2hvdWxkIG5vdCBzd2l0Y2ggZnJvbSA8dmlkZW8+IHRvIDxl bWJlZD4gd2hlbiAKICAgICAgICAgUVRLaXQgbG9hZCBzdGF0ZSBpcyBRVE1vdmllTG9hZFN0YXRl TG9hZGluZyBhcyB0aGF0IGhhcHBlbnMgZnJlcXVlbnRseSB3aGVuIGEgbG9hZGluZwpJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQ cml2YXRlUVRLaXQubW0JKHJldmlzaW9uIDQyNDc1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0JKHdvcmtpbmcgY29weSkKQEAgLTY3 LDYgKzY3LDcgQEAgU09GVF9MSU5LKFFUS2l0LCBRVE1ha2VUaW1lLCBRVFRpbWUsIChsbwogU09G VF9MSU5LX0NMQVNTKFFUS2l0LCBRVE1vdmllKQogU09GVF9MSU5LX0NMQVNTKFFUS2l0LCBRVE1v dmllVmlldykKIAorU09GVF9MSU5LX1BPSU5URVIoUVRLaXQsIFFUVHJhY2tNZWRpYVR5cGVBdHRy aWJ1dGUsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktfUE9JTlRFUihRVEtpdCwgUVRNZWRpYVR5cGVB dHRyaWJ1dGUsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktfUE9JTlRFUihRVEtpdCwgUVRNZWRpYVR5 cGVCYXNlLCBOU1N0cmluZyAqKQogU09GVF9MSU5LX1BPSU5URVIoUVRLaXQsIFFUTWVkaWFUeXBl TVBFRywgTlNTdHJpbmcgKikKQEAgLTk1LDYgKzk2LDcgQEAgU09GVF9MSU5LX1BPSU5URVIoUVRL aXQsIFFUVmlkZW9SZW5kZXJlcgogI2RlZmluZSBRVE1vdmllIGdldFFUTW92aWVDbGFzcygpCiAj ZGVmaW5lIFFUTW92aWVWaWV3IGdldFFUTW92aWVWaWV3Q2xhc3MoKQogCisjZGVmaW5lIFFUVHJh Y2tNZWRpYVR5cGVBdHRyaWJ1dGUgZ2V0UVRUcmFja01lZGlhVHlwZUF0dHJpYnV0ZSgpCiAjZGVm aW5lIFFUTWVkaWFUeXBlQXR0cmlidXRlIGdldFFUTWVkaWFUeXBlQXR0cmlidXRlKCkKICNkZWZp bmUgUVRNZWRpYVR5cGVCYXNlIGdldFFUTWVkaWFUeXBlQmFzZSgpCiAjZGVmaW5lIFFUTWVkaWFU eXBlTVBFRyBnZXRRVE1lZGlhVHlwZU1QRUcoKQpAQCAtOTkyLDI0ICs5OTQsMTggQEAgdm9pZCBN ZWRpYVBsYXllclByaXZhdGU6OmRpc2FibGVVbnN1cHBvcgogICAgICAgICBpZiAoIVt0cmFjayBp c0VuYWJsZWRdKQogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIAotICAgICAgICAvLyBH cmFiIHRoZSB0cmFjaydzIG1lZGlhLiBXZSdyZSBnb2luZyB0byBjaGVjayB0byBzZWUgaWYgd2Ug bmVlZCB0bwotICAgICAgICAvLyBkaXNhYmxlIHRoZSB0cmFja3MuIFRoZXkgY291bGQgYmUgdW5z dXBwb3J0ZWQuCi0gICAgICAgIFFUTWVkaWEgKnRyYWNrTWVkaWEgPSBbdHJhY2sgbWVkaWFdOwot ICAgICAgICBpZiAoIXRyYWNrTWVkaWEpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg Ci0gICAgICAgIC8vIEdyYWIgdGhlIG1lZGlhIHR5cGUgZm9yIHRoaXMgdHJhY2suCi0gICAgICAg IE5TU3RyaW5nICptZWRpYVR5cGUgPSBbdHJhY2tNZWRpYSBhdHRyaWJ1dGVGb3JLZXk6UVRNZWRp YVR5cGVBdHRyaWJ1dGVdOworICAgICAgICAvLyBHZXQgdGhlIHRyYWNrJ3MgbWVkaWEgdHlwZS4K KyAgICAgICAgTlNTdHJpbmcgKm1lZGlhVHlwZSA9IFt0cmFjayBhdHRyaWJ1dGVGb3JLZXk6UVRU cmFja01lZGlhVHlwZUF0dHJpYnV0ZV07CiAgICAgICAgIGlmICghbWVkaWFUeXBlKQogICAgICAg ICAgICAgY29udGludWU7Ci0gICAgICAgIAorCiAgICAgICAgIC8vIFRlc3Qgd2hldGhlciB0aGUg bWVkaWEgdHlwZSBpcyBpbiBvdXIgd2hpdGUgbGlzdC4KICAgICAgICAgaWYgKCFhbGxvd2VkVHJh Y2tUeXBlcy0+Y29udGFpbnMobWVkaWFUeXBlKSkgewogICAgICAgICAgICAgLy8gSWYgdGhpcyB0 cmFjayB0eXBlIGlzIG5vdCBhbGxvd2VkLCB0aGVuIHdlIG5lZWQgdG8gZGlzYWJsZSBpdC4KICAg ICAgICAgICAgIFt0cmFjayBzZXRFbmFibGVkOk5PXTsKICAgICAgICAgICAgIC0tbV9lbmFibGVk VHJhY2tDb3VudDsKICAgICAgICAgfQotICAgICAgICAKKwogICAgICAgICAvLyBEaXNhYmxlIGNo YXB0ZXIgdHJhY2tzLiBUaGVzZSBhcmUgbW9zdCBsaWtlbHkgdG8gbGVhZCB0byB0cm91YmxlLCBh cwogICAgICAgICAvLyB0aGV5IHdpbGwgYmUgY29tcG9zaXRlZCB1bmRlciB0aGUgdmlkZW8gdHJh Y2tzLCBmb3JjaW5nIFFUIHRvIGRvIGV4dHJhCiAgICAgICAgIC8vIHdvcmsuCg==