251749 2023-02-04 20:00:08 -0800 Optimize layout of AbortSignal to reduce padding 2023-02-06 09:19:35 -0800 1 1 1 Unclassified WebKit DOM WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez darin esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer oldest_to_newest 1931175 0 simon.fraser 2023-02-04 20:00:08 -0800 Before: OpenSource % /usr/bin/python3 ./Tools/Scripts/dump-class-layout -c Release WebCore AbortSignal +0 <112> WebCore::AbortSignal +0 < 24> <PADDING: 24 bytes> +24 < 4> WTF::RefCounted<WebCore::AbortSignal, std::__1::default_delete<WebCore::AbortSignal> > WTF::RefCounted<WebCore::AbortSignal, std::__1::default_delete<WebCore::AbortSignal> > +24 < 4> WTF::RefCountedBase WTF::RefCountedBase +24 < 4> unsigned int m_refCount +0 < 24> WebCore::EventTarget WebCore::EventTarget +0 < 8> __vtbl_ptr_type * _vptr +8 < 8> WebCore::ScriptWrappable WebCore::ScriptWrappable +8 < 8> JSC::Weak<WebCore::JSDOMObject> m_wrapper +8 < 8> JSC::WeakImpl * m_impl +16 < 8> WTF::CanMakeWeakPtr<WebCore::EventTarget, WTF::WeakPtrFactoryInitialization::Lazy, WebCore::WeakPtrImplWithEventTargetData> WTF::CanMakeWeakPtr<WebCore::EventTarget, WTF::WeakPtrFactoryInitialization::Lazy, WebCore::WeakPtrImplWithEventTargetData> +16 < 8> WTF::WeakPtrFactory<WebCore::EventTarget, WebCore::WeakPtrImplWithEventTargetData> m_weakPtrFactory +16 < 8> WTF::CompactRefPtrTuple<WebCore::WeakPtrImplWithEventTargetData, unsigned short> m_impl +16 < 8> WTF::CompactPointerTuple<WebCore::WeakPtrImplWithEventTargetData *, unsigned short> m_data +16 < 8> uint64_t m_data +24 < 8> <PADDING: 8 bytes> +32 < 16> WebCore::ContextDestructionObserver WebCore::ContextDestructionObserver +32 < 8> __vtbl_ptr_type * _vptr +40 < 8> WebCore::ScriptExecutionContext * m_scriptExecutionContext +48 < 1> bool m_aborted +49 < 7> <PADDING: 7 bytes> +56 < 16> WTF::Vector<std::__1::pair<unsigned int, WTF::Function<void (JSC::JSValue)> >, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> m_algorithms +56 < 16> WTF::VectorBuffer<std::__1::pair<unsigned int, WTF::Function<void (JSC::JSValue)> >, 0, WTF::FastMalloc> WTF::VectorBuffer<std::__1::pair<unsigned int, WTF::Function<void (JSC::JSValue)> >, 0, WTF::FastMalloc> +56 < 16> WTF::VectorBufferBase<std::__1::pair<unsigned int, WTF::Function<void (JSC::JSValue)> >, WTF::FastMalloc> WTF::VectorBufferBase<std::__1::pair<unsigned int, WTF::Function<void (JSC::JSValue)> >, WTF::FastMalloc> +56 < 8> std::__1::pair<unsigned int, WTF::Function<void (JSC::JSValue)> > * m_buffer +64 < 4> unsigned int m_capacity +68 < 4> unsigned int m_size +72 < 4> uint32_t m_algorithmIdentifier +76 < 4> <PADDING: 4 bytes> +80 < 8> WTF::WeakPtr<WebCore::AbortSignal, WebCore::WeakPtrImplWithEventTargetData> m_followingSignal +80 < 8> WTF::RefPtr<WebCore::WeakPtrImplWithEventTargetData, WTF::RawPtrTraits<WebCore::WeakPtrImplWithEventTargetData>, WTF::DefaultRefDerefTraits<WebCore::WeakPtrImplWithEventTargetData> > m_impl +80 < 8> WTF::RawPtrTraits<WebCore::WeakPtrImplWithEventTargetData>::StorageType m_ptr +88 < 16> WebCore::JSValueInWrappedObject m_reason +88 < 8> JSC::JSValue m_nonCell +88 < 8> JSC::EncodedValueDescriptor u +96 < 8> JSC::Weak<JSC::JSCell> m_cell +96 < 8> JSC::WeakImpl * m_impl +104 < 1> bool m_hasActiveTimeoutTimer +105 < 1> bool m_hasAbortEventListener +106 < 6> <PADDING: 6 bytes> Total byte size: 112 Total pad bytes: 49 Padding percentage: 43.75 % 1931176 1 webkit-bug-importer 2023-02-04 20:12:27 -0800 <rdar://problem/105048992> 1931177 2 464843 simon.fraser 2023-02-04 20:13:20 -0800 Created attachment 464843 Patch 1931399 3 ews-feeder 2023-02-06 09:19:31 -0800 Committed 259897@main (e60034e6433d): <https://commits.webkit.org/259897@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464843. 464843 2023-02-04 20:13:20 -0800 2023-02-06 09:19:33 -0800 Patch bug-251749-20230204201319.patch text/plain 1962 simon.fraser RnJvbSA0MTQ5NDFmYTllMTA0NGM1NTIyNDNkN2FkM2QwMzY4YmIxZDAxZjY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaW1vbiBGcmFzZXIgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CkRhdGU6IFNhdCwgNCBGZWIgMjAyMyAyMDoxMTo0MSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIE9w dGltaXplIGxheW91dCBvZiBBYm9ydFNpZ25hbCB0byByZWR1Y2UgcGFkZGluZwogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MTc0OSA8cmRhcjovL3Byb2JsZW0vMTA1 MDQ4OTkyPgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpSZW9yZGVyIGRhdGEgbWVtYmVy cyB0byBzaHJpbmsgdGhlIHNpemUgZnJvbSAxMTIgdG8gOTYgYnl0ZXMuCgoqIFNvdXJjZS9XZWJD b3JlL2RvbS9BYm9ydFNpZ25hbC5jcHA6CihXZWJDb3JlOjpBYm9ydFNpZ25hbDo6QWJvcnRTaWdu YWwpOgoqIFNvdXJjZS9XZWJDb3JlL2RvbS9BYm9ydFNpZ25hbC5oOgotLS0KIFNvdXJjZS9XZWJD b3JlL2RvbS9BYm9ydFNpZ25hbC5jcHAgfCAyICstCiBTb3VyY2UvV2ViQ29yZS9kb20vQWJvcnRT aWduYWwuaCAgIHwgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQWJvcnRTaWduYWwu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0Fib3J0U2lnbmFsLmNwcAppbmRleCA0ZWU1YjdiMTI4 MzEuLjVjYTBmMDAyYjQ3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Fib3J0U2ln bmFsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQWJvcnRTaWduYWwuY3BwCkBAIC03OCw4 ICs3OCw4IEBAIFJlZjxBYm9ydFNpZ25hbD4gQWJvcnRTaWduYWw6OnRpbWVvdXQoU2NyaXB0RXhl Y3V0aW9uQ29udGV4dCYgY29udGV4dCwgdWludDY0X3QKIAogQWJvcnRTaWduYWw6OkFib3J0U2ln bmFsKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEFib3J0ZWQgYWJvcnRlZCwgSlND OjpKU1ZhbHVlIHJlYXNvbikKICAgICA6IENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyKGNvbnRl eHQpCi0gICAgLCBtX2Fib3J0ZWQoYWJvcnRlZCA9PSBBYm9ydGVkOjpZZXMpCiAgICAgLCBtX3Jl YXNvbihyZWFzb24pCisgICAgLCBtX2Fib3J0ZWQoYWJvcnRlZCA9PSBBYm9ydGVkOjpZZXMpCiB7 CiAgICAgQVNTRVJUKHJlYXNvbik7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v QWJvcnRTaWduYWwuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9BYm9ydFNpZ25hbC5oCmluZGV4IGQy ZTUzZjY5Y2JlZi4uZWYwMGYxYTMwNTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v QWJvcnRTaWduYWwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQWJvcnRTaWduYWwuaApAQCAt ODQsMTEgKzg0LDExIEBAIHByaXZhdGU6CiAgICAgdm9pZCBkZXJlZkV2ZW50VGFyZ2V0KCkgZmlu YWwgeyBkZXJlZigpOyB9CiAgICAgdm9pZCBldmVudExpc3RlbmVyc0RpZENoYW5nZSgpIGZpbmFs OwogICAgIAotICAgIGJvb2wgbV9hYm9ydGVkIHsgZmFsc2UgfTsKICAgICBWZWN0b3I8c3RkOjpw YWlyPHVpbnQzMl90LCBBbGdvcml0aG0+PiBtX2FsZ29yaXRobXM7Ci0gICAgdWludDMyX3QgbV9h bGdvcml0aG1JZGVudGlmaWVyIHsgMCB9OwogICAgIFdlYWtQdHI8QWJvcnRTaWduYWwsIFdlYWtQ dHJJbXBsV2l0aEV2ZW50VGFyZ2V0RGF0YT4gbV9mb2xsb3dpbmdTaWduYWw7CiAgICAgSlNWYWx1 ZUluV3JhcHBlZE9iamVjdCBtX3JlYXNvbjsKKyAgICB1aW50MzJfdCBtX2FsZ29yaXRobUlkZW50 aWZpZXIgeyAwIH07CisgICAgYm9vbCBtX2Fib3J0ZWQgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9o YXNBY3RpdmVUaW1lb3V0VGltZXIgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9oYXNBYm9ydEV2ZW50 TGlzdGVuZXIgeyBmYWxzZSB9OwogfTsK