251726 2023-02-03 16:20:23 -0800 LayoutIntegration::BoxTree::m_renderers wastes 16KB of vector capacity 2023-02-06 09:00:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser koivisto bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1931038 0 simon.fraser 2023-02-03 16:20:23 -0800 Using the patch in bug 186698, and testing on a wikipedia page, we see that LayoutIntegration::BoxTree::m_renderers wastes 16KB of vector capacity: Wasted capacity: 16016 bytes (used 29136 of 45152 bytes, utilization: 64.53%) - 216 allocations 5 0x82651c1a4 WTF::VectorBuffer<WTF::WeakPtr<WebCore::RenderObject, WTF::DefaultWeakPtrImpl>, 1ul, WTF::FastMalloc>::VectorBuffer() 6 0x82651c135 WTF::Vector<WTF::WeakPtr<WebCore::RenderObject, WTF::DefaultWeakPtrImpl>, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::Vector() 7 0x8264fa035 WTF::Vector<WTF::WeakPtr<WebCore::RenderObject, WTF::DefaultWeakPtrImpl>, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::Vector() 8 0x8264f9ec8 WebCore::LayoutIntegration::BoxTree::BoxTree(WebCore::RenderBlock&) 9 0x8264fa90d WebCore::LayoutIntegration::BoxTree::BoxTree(WebCore::RenderBlock&) 10 0x8265479ce WebCore::LayoutIntegration::LineLayout::LineLayout(WebCore::RenderBlockFlow&) 11 0x826547b8d WebCore::LayoutIntegration::LineLayout::LineLayout(WebCore::RenderBlockFlow&) 12 0x827299fde std::__1::__unique_if<WebCore::LayoutIntegration::LineLayout>::__unique_single std::__1::make_unique<WebCore::LayoutIntegration::LineLayout, WebCore::RenderBlockFlow&>(WebCore::RenderBlockFlow&) 1931039 1 webkit-bug-importer 2023-02-03 16:20:44 -0800 <rdar://problem/105025598> 1931324 2 koivisto 2023-02-06 01:57:12 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9680 1931390 3 ews-feeder 2023-02-06 08:59:58 -0800 Committed 259895@main (470080c7ba5f): <https://commits.webkit.org/259895@main> Reviewed commits have been landed. Closing PR #9680 and removing active labels.