251725 2023-02-03 16:16:58 -0800 FloatingState::m_floats wastes 30KB of vector capacity 2023-02-06 12:46:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1931036 0 simon.fraser 2023-02-03 16:16:58 -0800 Using the patch in bug 186698, and testing on a wikipedia page, we see that FloatingState::m_floats wastes 30KB of vector capacity: Wasted capacity: 30888 bytes (used 2392 of 33280 bytes, utilization: 7.19%) - 216 allocations 5 0x82646e57d WTF::VectorBuffer<WebCore::Layout::FloatingState::FloatItem, 0ul, WTF::FastMalloc>::VectorBuffer() 6 0x82646e545 WTF::Vector<WebCore::Layout::FloatingState::FloatItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::Vector() 7 0x82644b9c5 WTF::Vector<WebCore::Layout::FloatingState::FloatItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::Vector() 8 0x82644b91d WebCore::Layout::FloatingState::FloatingState(WebCore::Layout::LayoutState&, WebCore::Layout::ElementBox const&) 9 0x82644ba15 WebCore::Layout::FloatingState::FloatingState(WebCore::Layout::LayoutState&, WebCore::Layout::ElementBox const&) 10 0x826460b4c WebCore::Layout::BlockFormattingState::BlockFormattingState(WebCore::Layout::LayoutState&, WebCore::Layout::ElementBox const&) 11 0x826460be5 WebCore::Layout::BlockFormattingState::BlockFormattingState(WebCore::Layout::LayoutState&, WebCore::Layout::ElementBox const&) 1931037 1 webkit-bug-importer 2023-02-03 16:17:18 -0800 <rdar://problem/105025457> 1931412 2 464866 zalan 2023-02-06 10:02:01 -0800 Created attachment 464866 Patch 1931462 3 ews-feeder 2023-02-06 12:46:31 -0800 Committed 259909@main (f2ad1fd561f5): <https://commits.webkit.org/259909@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464866. 464866 2023-02-06 10:02:01 -0800 2023-02-06 12:46:35 -0800 Patch bug-251725-20230206100200.patch text/plain 4378 zalan RnJvbSAxMDkwZTNkODU5YjA1NWE5YTNiMjM3NTFjOTEwZGUzODJmNjRlOGRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IE1vbiwgNiBGZWIgMjAyMyAwOTo1OTo1OSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEZsb2F0aW5n U3RhdGU6Om1fZmxvYXRzIHdhc3RlcyAzMEtCIG9mIHZlY3RvciBjYXBhY2l0eQogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1MTcyNSA8cmRhcjovL3Byb2JsZW0vMTA1 MDI1NDU3PgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJbnRyb2R1Y2Ugc2hyaW5rVG9G aXQgdG8gQmxvY2tGb3JtYXR0aW5nU3RhdGUgKHdoaWNoIHdlIGFscmVhZHkgaGF2ZSBvbiBJbmxp bmVGb3JtYXR0aW5nU3RhdGUpLgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0 aW5nU3RhdGUuY3BwOgooV2ViQ29yZTo6TGF5b3V0OjpGbG9hdGluZ1N0YXRlOjpzaHJpbmtUb0Zp dCk6CiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmg6CiogU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9ibG9jay9CbG9ja0Zvcm1hdHRp bmdTdGF0ZS5jcHA6CihXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ1N0YXRlOjpzaHJp bmtUb0ZpdCk6CiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9ibG9j ay9CbG9ja0Zvcm1hdHRpbmdTdGF0ZS5oOgoqIFNvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3Jh dGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoKKFdlYkNvcmU6Okxh eW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0Ojpjb25zdHJ1Y3RDb250ZW50KToKLS0tCiBTb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuY3BwICAgICAgICAgICAgICAg fCA1ICsrKysrCiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuaCAg ICAgICAgICAgICAgICAgfCAyICsrCiAuLi4vbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9ibG9j ay9CbG9ja0Zvcm1hdHRpbmdTdGF0ZS5jcHAgfCA1ICsrKysrCiAuLi4vbGF5b3V0L2Zvcm1hdHRp bmdDb250ZXh0cy9ibG9jay9CbG9ja0Zvcm1hdHRpbmdTdGF0ZS5oICAgfCAyICsrCiAuLi4vaW50 ZWdyYXRpb24vaW5saW5lL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAgICAgICAgfCAz ICsrLQogNSBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKaW5kZXgg MzU4MWE1MTkyN2Y0Li43ZTFlNzQ5ZjM3MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNwcApAQCAtMTE1LDUgKzExNSwxMCBAQCB2b2lkIEZsb2F0 aW5nU3RhdGU6OmNsZWFyKCkKICAgICBtX3Bvc2l0aW9uVHlwZXMgPSB7IH07CiB9CiAKK3ZvaWQg RmxvYXRpbmdTdGF0ZTo6c2hyaW5rVG9GaXQoKQoreworICAgIG1fZmxvYXRzLnNocmlua1RvRml0 KCk7Cit9CisKIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMv RmxvYXRpbmdTdGF0ZS5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0 YXRlLmgKaW5kZXggODQ5OWMxOTdjNTE2Li44OTU5NmRkZTNjODIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5oCkBAIC04OSw2ICs4OSw4IEBAIHB1Ymxp YzoKICAgICAvLyBmbG9hdHMgdG8gaW5pdGlhdGUgdGhlIGZsb2F0aW5nIHN0YXRlIGluIHRoZSBp bnRlZ3JhdGlvbiBjb2RlcGF0aCAoaS5lLiB3aGVuIHRoZSBmbG9hdCBjb21lcyBmcm9tIHRoZSBw YXJlbnQgQkZDKS4KICAgICB2b2lkIHNldElzTGVmdFRvUmlnaHREaXJlY3Rpb24oYm9vbCBpc0xl ZnRUb1JpZ2h0RGlyZWN0aW9uKSB7IG1faXNMZWZ0VG9SaWdodERpcmVjdGlvbiA9IGlzTGVmdFRv UmlnaHREaXJlY3Rpb247IH0KIAorICAgIHZvaWQgc2hyaW5rVG9GaXQoKTsKKwogcHJpdmF0ZToK ICAgICBmcmllbmQgY2xhc3MgRmxvYXRpbmdDb250ZXh0OwogICAgIExheW91dFN0YXRlJiBsYXlv dXRTdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbGF5b3V0U3RhdGU7IH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvYmxvY2svQmxvY2tGb3JtYXR0 aW5nU3RhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9i bG9jay9CbG9ja0Zvcm1hdHRpbmdTdGF0ZS5jcHAKaW5kZXggMzg5NWM1YzVhYzM0Li44MmVmZGIw YmY1NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4 dHMvYmxvY2svQmxvY2tGb3JtYXR0aW5nU3RhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mb3JtYXR0aW5nQ29udGV4dHMvYmxvY2svQmxvY2tGb3JtYXR0aW5nU3RhdGUuY3BwCkBA IC00Myw1ICs0MywxMCBAQCBCbG9ja0Zvcm1hdHRpbmdTdGF0ZTo6fkJsb2NrRm9ybWF0dGluZ1N0 YXRlKCkKIHsKIH0KIAordm9pZCBCbG9ja0Zvcm1hdHRpbmdTdGF0ZTo6c2hyaW5rVG9GaXQoKQor eworICAgIG1fZmxvYXRpbmdTdGF0ZS5zaHJpbmtUb0ZpdCgpOworfQorCiB9CiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2Jsb2NrL0Jsb2Nr Rm9ybWF0dGluZ1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRl eHRzL2Jsb2NrL0Jsb2NrRm9ybWF0dGluZ1N0YXRlLmgKaW5kZXggNThlZDAwYjFkNmYyLi42YTM3 OWExMGIxMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29u dGV4dHMvYmxvY2svQmxvY2tGb3JtYXR0aW5nU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2Jsb2NrL0Jsb2NrRm9ybWF0dGluZ1N0YXRlLmgKQEAg LTUxLDYgKzUxLDggQEAgcHVibGljOgogICAgIHZvaWQgY2xlYXJIYXNDbGVhcmFuY2UoY29uc3Qg Qm94JiBsYXlvdXRCb3gpIHsgbV9jbGVhcmFuY2VTZXQucmVtb3ZlKGxheW91dEJveCk7IH0KICAg ICBib29sIGhhc0NsZWFyYW5jZShjb25zdCBCb3gmIGxheW91dEJveCkgY29uc3QgeyByZXR1cm4g bV9jbGVhcmFuY2VTZXQuY29udGFpbnMobGF5b3V0Qm94KTsgfQogCisgICAgdm9pZCBzaHJpbmtU b0ZpdCgpOworCiBwcml2YXRlOgogICAgIEZsb2F0aW5nU3RhdGUgbV9mbG9hdGluZ1N0YXRlOwog ICAgIEhhc2hNYXA8Q2hlY2tlZFJlZjxjb25zdCBCb3g+LCBVc2VkVmVydGljYWxNYXJnaW4+IG1f dXNlZFZlcnRpY2FsTWFyZ2luczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9pbmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5l TGF5b3V0LmNwcAppbmRleCAwZjk5OWExMDkyZTMuLjlhZDFhNDNlNjQ2MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL2lubGluZS9MYXlvdXRJbnRlZ3JhdGlv bkxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9p bmxpbmUvTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcApAQCAtNTk5LDggKzU5OSw5IEBA IHZvaWQgTGluZUxheW91dDo6Y29uc3RydWN0Q29udGVudCgpCiAgICAgICAgIHJlbmRlcmVyLnNl dExvY2F0aW9uKExheW91dDo6Qm94R2VvbWV0cnk6OmJvcmRlckJveFJlY3QobG9naWNhbEdlb21l dHJ5KS50b3BMZWZ0KCkpOwogICAgIH0KIAotICAgIG1faW5saW5lRm9ybWF0dGluZ1N0YXRlLnNo cmlua1RvRml0KCk7CiAgICAgbV9pbmxpbmVGb3JtYXR0aW5nU3RhdGUucmVzZXROZXN0ZWRMaXN0 TWFya2VyT2Zmc2V0cygpOworICAgIG1faW5saW5lRm9ybWF0dGluZ1N0YXRlLnNocmlua1RvRml0 KCk7CisgICAgbV9ibG9ja0Zvcm1hdHRpbmdTdGF0ZS5zaHJpbmtUb0ZpdCgpOwogfQogCiB2b2lk IExpbmVMYXlvdXQ6OnVwZGF0ZUlubGluZUNvbnRlbnRDb25zdHJhaW50cygpCg==