251700 2023-02-03 10:29:01 -0800 DisplayList::ItemBuffer wastes a lot of vector capacity 2023-02-04 17:07:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham heycam simon.fraser webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1930923 0 simon.fraser 2023-02-03 10:29:01 -0800 Using the patch in bug 186698, and testing on a wikipedia page, we see that DisplayList::ItemBuffer::ItemBuffer() wastes a lot of vector capacity: Wasted capacity: 31632 bytes (used 0 of 31632 bytes, utilization: 0.00%) - 659 allocations 1 0x2fd3346e7 WTF::VectorBuffer<WebCore::DisplayList::ItemBufferHandle, 2ul, WTF::FastMalloc>::VectorBuffer() 2 0x2fd3313d1 WebCore::DisplayList::ItemBuffer::ItemBuffer() 3 0x2fd33119c WebCore::DisplayList::DisplayList::itemBuffer() 4 0x2fd3311fe WebCore::DisplayList::DisplayList::setItemBufferWritingClient(WebCore::DisplayList::ItemBufferWritingClient*) 5 0x2fd336a1b WebCore::DisplayList::InMemoryDisplayList::InMemoryDisplayList() 6 0x2fd30735a WebCore::FontCascade::displayListForTextRun(WebCore::GraphicsContext&, WebCore::TextRun const&, unsigned int, std::__1::optional<unsigned int>, WebCore::FontCascade::CustomFontNotReadyAction) const 7 0x2fcc5efd4 WebCore::GlyphDisplayListCache::get(void const*, WebCore::FontCascade const&, WebCore::GraphicsContext&, WebCore::TextRun const&) 8 0x2fcdf55a2 WebCore::TextBoxPainter<WebCore::InlineIterator::BoxModernPath>::paintForeground(WebCore::StyledMarkedText const&) 9 0x2fcdf3efe WebCore::TextBoxPainter<WebCore::InlineIterator::BoxModernPath>::paintForegroundAndDecorations() 10 0x2fcdf3656 WebCore::TextBoxPainter<WebCore::InlineIterator::BoxModernPath>::paint() 11 0x2fc7e0b49 WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox(WebCore::InlineDisplay::Box const&) 12 0x2fc7e0db5 WebCore::LayoutIntegration::InlineContentPainter::paint() 13 0x2fc7e54a8 WebCore::LayoutIntegration::LineLayout::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::RenderInline const*) 14 0x2fcc96d0e WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 1930924 1 webkit-bug-importer 2023-02-03 10:29:26 -0800 <rdar://problem/105011333> 1931125 2 464837 simon.fraser 2023-02-04 12:12:26 -0800 Created attachment 464837 Patch 1931154 3 ews-feeder 2023-02-04 17:07:17 -0800 Committed 259861@main (b7a8c3d2ff89): <https://commits.webkit.org/259861@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464837. 464837 2023-02-04 12:12:26 -0800 2023-02-04 17:07:18 -0800 Patch bug-251700-20230204121225.patch text/plain 1621 simon.fraser RnJvbSA2ZmQyZmQzYmQzOWJhMjgzNjJlMDM3ODRhMTgxMDBkZDU1OGU3NzU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaW1vbiBGcmFzZXIgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CkRhdGU6IFNhdCwgNCBGZWIgMjAyMyAxMjowOToxNyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIERp c3BsYXlMaXN0OjpJdGVtQnVmZmVyIHdhc3RlcyBhIGxvdCBvZiB2ZWN0b3IgY2FwYWNpdHkKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTE3MDAgPHJkYXI6Ly9wcm9i bGVtLzEwNTAxMTMzMz4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVGhlIFZlY3RvcjxJ dGVtQnVmZmVySGFuZGxlLCAyPiBJdGVtQnVmZmVyOjptX3JlYWRPbmx5QnVmZmVycyBnZXRzIGFs bG9jYXRlZCBmb3IgZXZlcnkgR2x5cGhEaXNwbGF5TGlzdENhY2hlCmVudHJ5LCBidXQgaXMgbmV2 ZXIgdXNlZCB0aGVyZS4gSXQncyBhbHNvIHZlcnkgcmFyZWx5IHVzZWQgd2l0aCBHUFUgcHJvY2Vz cyByZW5kZXJpbmcgKEkgbmV2ZXIgc2F3IHVzZSBvZgptX3JlYWRPbmx5QnVmZmVycyBydW5uaW5n IE1vdGlvbk1hcmspLCBzbyBnaXZlIGl0IGRlZmF1bHQgY2FwYWNpdHkgMCwgYW5kIGNhcGFjaXR5 IDIgd2hlbiBpdCBkb2VzIGdldCBhbGxvY2F0ZWQuCgoqIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaDoKLS0tCiAuLi4v cGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0SXRlbUJ1ZmZlci5oICAg ICAgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlz dHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVmZmVyLmgKaW5kZXggYjMxYmM1ZmQ0 ZTkyLi5mMjE4ZjZhMTNjNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdEl0ZW1CdWZmZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtQnVm ZmVyLmgKQEAgLTUwLDcgKzUwLDcgQEAgc3RydWN0IEl0ZW1CdWZmZXJIYW5kbGUgewogICAgIGJv b2wgb3BlcmF0b3IhKCkgY29uc3QgeyByZXR1cm4gIWRhdGE7IH0KIH07CiAKLXVzaW5nIEl0ZW1C dWZmZXJIYW5kbGVzID0gVmVjdG9yPEl0ZW1CdWZmZXJIYW5kbGUsIDI+OwordXNpbmcgSXRlbUJ1 ZmZlckhhbmRsZXMgPSBWZWN0b3I8SXRlbUJ1ZmZlckhhbmRsZSwgMCwgQ3Jhc2hPbk92ZXJmbG93 LCAyPjsKIAogLy8gQW4gSXRlbUhhbmRsZSB3cmFwcyBhIHBvaW50ZXIgdG8gYW4gSXRlbVR5cGUg Zm9sbG93ZWQgaW1tZWRpYXRlbHkgYnkgYW4gaXRlbSBvZiB0aGF0IHR5cGUuCiAvLyBFYWNoIGl0 ZW0gaGFuZGxlIGRhdGEgcG9pbnRlciBpcyBhbGlnbmVkIHRvIDggYnl0ZXMsIGFuZCB0aGUgaXRl bSBpdHNlbGYgaXMgYWxzbyBhbGlnbmVkCg==