<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>251667</bug_id>
          
          <creation_ts>2023-02-02 22:49:30 -0800</creation_ts>
          <short_desc>Implement a more accurate currentStackPointer().</short_desc>
          <delta_ts>2023-02-13 14:39:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=252196</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>berto</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>fujii</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1930773</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2023-02-02 22:49:30 -0800</bug_when>
    <thetext>currentStackPointer() was already accurate for some ports (the ones that support inline assembly), but for others and when using a Debug build, we fall back to a C runtime function that only gives an approximate value.  This patch implements a currentStackPointer() that is accurate for all currently support ports even when using a Debug build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1930774</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-02-02 22:49:54 -0800</bug_when>
    <thetext>&lt;rdar://problem/104993866&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1930775</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2023-02-02 23:00:33 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/9585</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1930882</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-02-03 08:34:11 -0800</bug_when>
    <thetext>Committed 259818@main (7dbed20e73b0): &lt;https://commits.webkit.org/259818@main&gt;

Reviewed commits have been landed. Closing PR #9585 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1931267</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-02-05 18:11:26 -0800</bug_when>
    <thetext>Bug 251770 – [Win] REGRESSION(259818@main) error LNK2019: unresolved external symbol currentStackPointer</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1933005</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-02-12 05:56:19 -0800</bug_when>
    <thetext>OK, this will break Fedora due to missing required architectures ppc64le and s390x, and will likely be worse for Debian since they have tons of architectures. I&apos;ll look closer next week, but ideally we would fall back to generic/inaccurate implementation rather than failing to build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1933301</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2023-02-13 14:39:37 -0800</bug_when>
    <thetext>I found a simple typo causing the build failure. Fix incoming in bug #252196.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>