251648 2023-02-02 16:23:54 -0800 Unable to enter fullscreen in Counterstrike (http://game.play-cs.com) in Safari 16.3 2023-10-10 10:11:19 -0700 1 1 1 Unclassified WebKit New Bugs Safari 16 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=262963 InRadar P2 Normal --- 1 saam aestes aestes jer.noble mmaxfield webkit-bug-importer oldest_to_newest 1930682 0 saam 2023-02-02 16:23:54 -0800 http://game.play-cs.com is a website to play counterstrike in the browser. It's super buggy in Safari: - It doesn't have sound - Fullscreen doesn't work properly. Safari is constantly entering/exiting full screen every second or so. 1930685 1 saam 2023-02-02 16:30:45 -0800 (In reply to Saam Barati from comment #0) > http://game.play-cs.com is a website to play counterstrike in the browser. > It's super buggy in Safari: > - It doesn't have sound > - Fullscreen doesn't work properly. Safari is constantly entering/exiting > full screen every second or so. There are lots of bugs around full screen. It seems to work a bit better if you full screen Safari itself using native macOS UI. But if you press the fullscreen button in the game without full screening the macOS app, that's when I was seeing the above bug. Now, I just encountered a different bug. If I fullscreen in the macOS Safari window UI, and then press the full screen button in the game, sometimes it'll kick me out from the desktop that Safari is full screened in, and take me back to the desktop that doesn't have Safari in it. 1930706 2 webkit-bug-importer 2023-02-02 17:23:01 -0800 <rdar://problem/104984915> 1930707 3 saam 2023-02-02 17:29:22 -0800 I’m seeing this in Safari 16.3 1930708 4 mmaxfield 2023-02-02 17:35:01 -0800 Saam says: "It worked properly my first time through, but playing around with entering/exiting made madness ensue. Repro might not be 100%, though whatever it is my machine seems to hit it every time now. I quit and relaunched, and that didn’t fix it." 1945578 5 465694 ntim 2023-03-30 17:56:29 -0700 Created attachment 465694 Reduced testcase Seems like a visibilitychange event is triggered when entering fullscreen, which triggers an event listener on the page that exits fullscreen. Here is a reduced testcase. 1983915 6 aestes 2023-10-09 21:20:14 -0700 *** Bug 262939 has been marked as a duplicate of this bug. *** 1983916 7 aestes 2023-10-09 21:25:44 -0700 Re-titling to make this about the fullscreen issue. Let's track the audio issue in a new bug. 1983918 8 aestes 2023-10-09 21:43:00 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18883 1984014 9 jer.noble 2023-10-10 09:24:17 -0700 Hi Saam! Aside from Andy's PR, why is play-cs.com exiting fullscreen when visibility changes? That means users can't switch spaces in Mac fullscreen without their game exiting. That's super annoying! 1984016 10 jer.noble 2023-10-10 09:25:17 -0700 For the audio issue, if play-cs.com makes use of WebAudio, this commit may interest you: https://commits.webkit.org/268047@main 1984027 11 aestes 2023-10-10 10:08:38 -0700 Filed https://bugs.webkit.org/show_bug.cgi?id=262963 to track the audio issue. 1984030 12 ews-feeder 2023-10-10 10:11:13 -0700 Committed 269150@main (7e8c765bf94d): <https://commits.webkit.org/269150@main> Reviewed commits have been landed. Closing PR #18883 and removing active labels. 465694 2023-03-30 17:56:29 -0700 2023-03-30 17:56:29 -0700 Reduced testcase fullscreen-visibilitychange.html text/html 198 ntim CjxidXR0b24gb25jbGljaz0iZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50LnJlcXVlc3RGdWxsc2Ny ZWVuKCkiPlJlcXVlc3QgZnVsbHNjcmVlbjwvYnV0dG9uPgo8c2NyaXB0Pgpkb2N1bWVudC5hZGRF dmVudExpc3RlbmVyKCJ2aXNpYmlsaXR5Y2hhbmdlIiwgKCkgPT57CiAgICBkb2N1bWVudC5leGl0 RnVsbHNjcmVlbigpOwp9KTsKPC9zY3JpcHQ+