251577 2023-02-02 04:36:39 -0800 AX: Object IDs should not be generated with AXTreeStore::generateNewID(). 2023-02-06 15:54:41 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white tyler_w webkit-bug-importer oldest_to_newest 1930427 0 andresg_22 2023-02-02 04:36:39 -0800 Fallout from fix for https://bugs.webkit.org/show_bug.cgi?id=249480. 1930428 1 webkit-bug-importer 2023-02-02 04:36:54 -0800 <rdar://problem/104956200> 1930431 2 464813 andresg_22 2023-02-02 04:49:17 -0800 Created attachment 464813 Patch 1930504 3 464813 tyler_w 2023-02-02 09:07:39 -0800 Comment on attachment 464813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464813&action=review I'm surprised that this bug didn't cause any tests to fail. Is it testable in any way? > Source/WebCore/accessibility/AXObjectCache.h:239 > + AccessibilityObject* objectForID(const AXID id) const { return m_objects.get(id); } Why not use a reference here? 1930512 4 andresg_22 2023-02-02 09:28:34 -0800 (In reply to Tyler Wilcock from comment #3) > Comment on attachment 464813 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=464813&action=review > > I'm surprised that this bug didn't cause any tests to fail. Is it testable > in any way? This is going away with the TextMarker reword, so I don't think it is worthy creating a test at this point. > > > Source/WebCore/accessibility/AXObjectCache.h:239 > > + AccessibilityObject* objectForID(const AXID id) const { return m_objects.get(id); } > > Why not use a reference here? because it can be null, i.e., the tree can be requested for an AXID that is no longer there. 1931545 5 ews-feeder 2023-02-06 15:54:38 -0800 Committed 259922@main (c11d33bb0bb2): <https://commits.webkit.org/259922@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464813. 464813 2023-02-02 04:49:17 -0800 2023-02-06 15:54:40 -0800 Patch bug-251577-20230202074916.patch text/plain 3106 andresg_22 RnJvbSA5ZTg1Y2M0MzRjMzcyZWMwZjcwMjE3NzZmMmQwZjJkNTQ3MjEzNTA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXMgR29uemFsZXogPGFuZHJlc2dfMjJAYXBwbGUuY29t PgpEYXRlOiBUaHUsIDIgRmViIDIwMjMgMDc6MjM6NTcgLTA1MDAKU3ViamVjdDogW1BBVENIXSBB WDogT2JqZWN0IElEcyBzaG91bGQgbm90IGJlIGdlbmVyYXRlZCB3aXRoCiBBWFRyZWVTdG9yZTo6 Z2VuZXJhdGVOZXdJRCgpLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjUxNTc3CiA8cmRhcjovL3Byb2JsZW0vMTA0OTU2MjAwPgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpJbiB0aGUgcGF0Y2ggZm9yCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjQ5NDgwCiAgICA8cmRhcjovL3Byb2JsZW0vMTAzNDQ5Mjk0PgoKSSBlcnJv bmVvdXNseSBzd2l0Y2hlZCB0aGUgZ2VuZXJhdGlvbiBvZiBvYmplY3QgSURTIGluIHRoZSBBWE9i amVjdENhY2hlIHRvIHVzZSBBWFRyZWVTdG9yZTo6Z2VuZXJhdGVOZXdJRC4gVGhpcyBpcyB3cm9u ZyBiZWNhdXNlIGdlbmVyYXRlTmV3SUQgY2hlY2tzIHRoZSBwcmVzZW5jZSBvZiB0aGUgSUQgYWdh aW5zdCB0aGUgSURzIG9mIEFYIHRyZWVzIGFuZCBub3QgYWdhaW5zdCBvYmplY3QgSURzLiBUaGlz IHBhdGNoIHJlY3RpZmllcyB0aGlzIGJ5IGJyaW5naW5nIGJhY2sgQVhPYmplY3RDYWNoZTo6Z2Vu ZXJhdGVOZXdPYmplY3RJRCAobmV3IG5hbWUpLgoKKiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FYT2JqZWN0Q2FjaGUuY3BwOgooV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Z2VuZXJhdGVO ZXdPYmplY3RJRCBjb25zdCk6CihXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpnZXRBWElEKToKKiBT b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaDoKKFdlYkNvcmU6OkFY T2JqZWN0Q2FjaGU6Om9iamVjdEZvcklEIGNvbnN0KTogTm8gbmVlZCB0byBwYXNzIEFYSUQgYnkg cmVmZXJlbmNlIHNpbmNlIGl0IGp1c3Qgd3JhcHMgYW4gdW5zZ2luZWQuCi0tLQogU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcCB8IDExICsrKysrKysrKystCiBT b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaCAgIHwgIDMgKystCiAy IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKaW5kZXggMGRhZWI2 NzYxMDBlLi5mZjAzZGU2YTMxNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BWE9iamVjdENhY2hlLmNwcApAQCAtOTc5LDYgKzk3OSwxNSBAQCB2b2lkIEFYT2JqZWN0Q2Fj aGU6OnJlbW92ZShXaWRnZXQqIHZpZXcpCiAgICAgcmVtb3ZlKG1fd2lkZ2V0T2JqZWN0TWFwcGlu Zy50YWtlKHZpZXcpKTsKIH0KIAorQVhJRCBBWE9iamVjdENhY2hlOjpnZW5lcmF0ZU5ld09iamVj dElEKCkgY29uc3QKK3sKKyAgICBBWElEIGF4SUQ7CisgICAgZG8geworICAgICAgICBheElEID0g QVhJRDo6Z2VuZXJhdGUoKTsKKyAgICB9IHdoaWxlICghYXhJRC5pc1ZhbGlkKCkgfHwgbV9pZHNJ blVzZS5jb250YWlucyhheElEKSk7CisgICAgcmV0dXJuIGF4SUQ7Cit9CisKIFZlY3RvcjxSZWZQ dHI8QVhDb3JlT2JqZWN0Pj4gQVhPYmplY3RDYWNoZTo6b2JqZWN0c0ZvcklEcyhjb25zdCBWZWN0 b3I8QVhJRD4mIGF4SURzKSBjb25zdAogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CkBA IC0xMDAyLDcgKzEwMTEsNyBAQCBBWElEIEFYT2JqZWN0Q2FjaGU6OmdldEFYSUQoQWNjZXNzaWJp bGl0eU9iamVjdCogb2JqZWN0KQogICAgICAgICByZXR1cm4gb2JqZWN0SUQ7CiAgICAgfQogCi0g ICAgb2JqZWN0SUQgPSBnZW5lcmF0ZU5ld0lEKCk7CisgICAgb2JqZWN0SUQgPSBnZW5lcmF0ZU5l d09iamVjdElEKCk7CiAgICAgbV9pZHNJblVzZS5hZGQob2JqZWN0SUQpOwogICAgIG9iamVjdC0+ c2V0T2JqZWN0SUQob2JqZWN0SUQpOwogICAgIHJldHVybiBvYmplY3RJRDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmgKaW5kZXggNmYyN2IxNjI5NTExLi5h NWVlNDA0MDQ2NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhP YmplY3RDYWNoZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RD YWNoZS5oCkBAIC0yMzYsNyArMjM2LDcgQEAgcHVibGljOgogICAgIGNvbnN0IEVsZW1lbnQqIHJv b3RBWEVkaXRhYmxlRWxlbWVudChjb25zdCBOb2RlKik7CiAgICAgYm9vbCBub2RlSXNUZXh0Q29u dHJvbChjb25zdCBOb2RlKik7CiAKLSAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBvYmplY3RGb3JJ RChjb25zdCBBWElEJiBpZCkgY29uc3QgeyByZXR1cm4gbV9vYmplY3RzLmdldChpZCk7IH0KKyAg ICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBvYmplY3RGb3JJRChjb25zdCBBWElEIGlkKSBjb25zdCB7 IHJldHVybiBtX29iamVjdHMuZ2V0KGlkKTsgfQogICAgIFZlY3RvcjxSZWZQdHI8QVhDb3JlT2Jq ZWN0Pj4gb2JqZWN0c0ZvcklEcyhjb25zdCBWZWN0b3I8QVhJRD4mKSBjb25zdDsKIAogICAgIC8v IFRleHQgbWFya2VyIHV0aWxpdGllcy4KQEAgLTQ4OCw2ICs0ODgsNyBAQCBwcml2YXRlOgogICAg IHN0YXRpYyBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBmb2N1c2VkSW1hZ2VNYXBVSUVsZW1lbnQoSFRN TEFyZWFFbGVtZW50Kik7CiAKICAgICBBWElEIGdldEFYSUQoQWNjZXNzaWJpbGl0eU9iamVjdCop OworICAgIEFYSUQgZ2VuZXJhdGVOZXdPYmplY3RJRCgpIGNvbnN0OwogCiAgICAgdm9pZCBub3Rp ZmljYXRpb25Qb3N0VGltZXJGaXJlZCgpOwogCg==